From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD7CC433E9 for ; Thu, 14 Jan 2021 18:46:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BEC2123B19 for ; Thu, 14 Jan 2021 18:46:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEC2123B19 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 18F618D0107; Thu, 14 Jan 2021 13:46:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13FC58D00F0; Thu, 14 Jan 2021 13:46:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0547D8D0107; Thu, 14 Jan 2021 13:46:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id E00BE8D00F0 for ; Thu, 14 Jan 2021 13:46:23 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9DFB0180AD81A for ; Thu, 14 Jan 2021 18:46:23 +0000 (UTC) X-FDA: 77705261046.23.price36_0b0792827528 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 7F20E37604 for ; Thu, 14 Jan 2021 18:46:23 +0000 (UTC) X-HE-Tag: price36_0b0792827528 X-Filterd-Recvd-Size: 3749 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 18:46:22 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id u11so7593075ljo.13 for ; Thu, 14 Jan 2021 10:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i55kmmNXG/mnP6m8XIGoPf0V44SCFRh/LGvtlfofL40=; b=lapMs7zi8CvB0F1JvETkhiONIcteEsxjQaOrcFDlnSNWS0doxqybSwdpGq2nGlmPvF 5offYbNwNsAMQ6MwmVCWr0hp+pY/npMgDtah3qtMN1+UdOnNT3+01whafxhh3Pkd/QPx y1bbDKDyjYVGK5awxtI+fF/gusAwJeo3BdThg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i55kmmNXG/mnP6m8XIGoPf0V44SCFRh/LGvtlfofL40=; b=lHmVkvopkEgE+iVpTkOQIbFysT9feggMZJut7K01v/lo7MHiRY+5QZV40/bU6YhtSr H4Z9k+F8f093LIUcYnhQy3fr9ZgdopeUueJFNR/AcEtYO0xi2EcnT5v3HOjQL1i0bo6C TOm/2ZhqlgtI0F8KtvQbzK8PF9cfGScn9SUVlSh+uEdf38PG9TSGRvDQUSQZyBGM5NSd 2+kn3rs3l+TxVAimddGJMtQsU1zJSJ4YhvHmhlJcYljNoRtN0YJK2wCP9fKlKkeg3Wsh gKNw86UXW7L2DfZzzR+l8Jdk4oAExIrkVFAeUZUcUN4+s3srQVsMlHQiqrFQgWKTKbwh 3/8Q== X-Gm-Message-State: AOAM532R24cxX6f3zgK3P34eup0iqpkvnCZdEiFmWO015pGDXQ6BoQak +qUYFK9L2n3NIh/YXtWdD+Lt1eI1lkpUZHJMaQto4A== X-Google-Smtp-Source: ABdhPJyj7pv55dPMgOPybcYVKiAR8TDxeAlRhZBOCbpC4sS+Vn1p7VT5BP1aEizH4bZmwOLiPp5dmboA6ago81c7LSI= X-Received: by 2002:a2e:b0e9:: with SMTP id h9mr3852308ljl.64.1610649981633; Thu, 14 Jan 2021 10:46:21 -0800 (PST) MIME-Version: 1.0 References: <1608894171-54174-1-git-send-email-tiantao6@hisilicon.com> In-Reply-To: <1608894171-54174-1-git-send-email-tiantao6@hisilicon.com> From: Vitaly Wool Date: Thu, 14 Jan 2021 19:46:06 +0100 Message-ID: Subject: Re: [RFC mm/zswap 0/2] Fix the compatibility of zsmalloc and zswap To: Tian Tao Cc: Seth Jennings , Dan Streetman , Andrew Morton , Barry Song , Linux-MM , Mike Galbraith , Sebastian Andrzej Siewior Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 25, 2020 at 12:02 PM Tian Tao wrote: > > patch #1 add a flag to zpool, then zswap used to determine if zpool > drivers such as zbud/z3fold/zsmalloc whether can sleep in atoimc context. > patch #2 set flag sleep_mapped to true indicates that zbud/z3fold can > sleep in atomic context. zsmalloc didin't support sleep in atomic context, > so not set that flag to true. > > Tian Tao (2): > mm/zswap: add the flag can_sleep_mapped > mm: set the sleep_mapped to true for zbud and z3fold > > include/linux/zpool.h | 3 +++ > mm/z3fold.c | 1 + > mm/zbud.c | 1 + > mm/zpool.c | 13 +++++++++++++ > mm/zswap.c | 50 +++++++++++++++++++++++++++++++++++++++++++++----- > 5 files changed, 63 insertions(+), 5 deletions(-) Haven't been able to actually test these yet, but looks good to me so far, so Reviewed-by: Vitaly Wool Please wait a bit for Mike, Sebastian or me to actually test this. Also, keep them CC'd explicitly if you are to come up with a new version for some reason. Best regards, Vitaly