From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF63EC4332F for ; Wed, 30 Nov 2022 15:23:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69E356B0074; Wed, 30 Nov 2022 10:23:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 64E4B6B0075; Wed, 30 Nov 2022 10:23:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53D616B0078; Wed, 30 Nov 2022 10:23:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 43D5D6B0074 for ; Wed, 30 Nov 2022 10:23:18 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 04AA316015B for ; Wed, 30 Nov 2022 15:23:17 +0000 (UTC) X-FDA: 80190477276.11.F179D4F Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf05.hostedemail.com (Postfix) with ESMTP id 654E1100002 for ; Wed, 30 Nov 2022 15:23:17 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id p24so13264135plw.1 for ; Wed, 30 Nov 2022 07:23:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pkpn3JCLkN0zpicy7e0jcgZdD6YYDioTrx8v1I8/jMs=; b=GadttrHS1p84E1qQAQ/UpFhBhO77vSulBRtydG4Pe7Pg5UybNUOiEv+A89EITuLcSQ Wjz1o+kFDLytkP2JFdH9Lzyt+/+4z+7CWNQrxefS8Pjj+B17q/cZfRFJ5C2pVTAKrNi1 TKgCtduuLidkKD1pMQdDdxWD0hUnK6hTlK7zw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pkpn3JCLkN0zpicy7e0jcgZdD6YYDioTrx8v1I8/jMs=; b=S+HVID1qmVCyuezJhUFCzlbIT9zJEsnRz9VBEziGsmumFSEsgTQiN0yB6ZsZHIa5Xt WuqitrVmS+VosqT6s/W7vjGRTQ2RfwJyJehlpBdSdi29DwL/OITEy6JrOJ4SN+MMu9FD BMQkz5W7ST1dMZ/dcKUh0bTOKrTGfdEw/H0hYon8HJ/g/cSNyWWMd/mP/s9i7kaUP+R1 8nNVEr0tew9F5LElxLe4zM25UO0iIVhQLf6KmrHTj7qN7la8EVX1FatCVcgJzluw46C9 lO0BpQlcXGFVNCYxKNSOyNoRyBR6EbIkDJYBe4H86cAcGc4vZr7+pvztqEFfWhS6x/IZ l5Wg== X-Gm-Message-State: ANoB5pmjfrO/9gqkwYDPc77aEgunh+IqJq8ilTAfzCFyFrJMYsBy5jQB aiVs/TIReZq0phedGMGufTMdKgXYNmMCoC2hOUp7JQ== X-Google-Smtp-Source: AA0mqf5ZB+HWPqQCNZ8+DLlEcI0TmMzp56DEdnzGqqMW1Dq9ekan3CYchSohPjtlPTzd3UlL90WWVZM67cIwYPLp7kM= X-Received: by 2002:a17:902:b40a:b0:188:635d:4b43 with SMTP id x10-20020a170902b40a00b00188635d4b43mr46622447plr.69.1669821796123; Wed, 30 Nov 2022 07:23:16 -0800 (PST) MIME-Version: 1.0 References: <20221128191616.1261026-1-nphamcs@gmail.com> <20221128191616.1261026-5-nphamcs@gmail.com> In-Reply-To: From: Vitaly Wool Date: Wed, 30 Nov 2022 16:23:05 +0100 Message-ID: Subject: Re: [PATCH v7 4/6] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order To: Johannes Weiner Cc: Sergey Senozhatsky , Nhat Pham , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, sjenning@redhat.com, ddstreet@ieee.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=GadttrHS; spf=pass (imf05.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669821797; a=rsa-sha256; cv=none; b=7d+KPREAobkf47zXG8wsVcW+SEpA1qCVhcu2wUK6D1sLilH/hzMCCBOezzb9LFOynioBFX 2XPYhh9opU6/8x7Ph+mrpgzVc3ThtzUA9tA4IBd5qW3IIZwk2Y4zCNRpFC+foMBk/8joAl Snv4vgat+YP+bUZK5L50usUNSbdhOX0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669821797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pkpn3JCLkN0zpicy7e0jcgZdD6YYDioTrx8v1I8/jMs=; b=eaN0N8T+0R5ugC8yo44BW1xeXRx7jKBqVNInfUOZMlqyc8WcTEmJlbKFUePeHGF5Dx+R0x EPX1gjorKfcXAL80X0zKa2D5IiI0vOehNLOJP4nq+dwb/8BeP3uzN/Duky8uo3ZFSDybNx ZyW7u1q4AsceR70E0tm5JBG8zkOLDsI= Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=GadttrHS; spf=pass (imf05.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com X-Rspamd-Server: rspam01 X-Stat-Signature: s15x9q7kjxwdwy3d9eja35fu6x5asei6 X-Rspamd-Queue-Id: 654E1100002 X-Rspam-User: X-HE-Tag: 1669821797-113453 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 29, 2022 at 4:54 PM Johannes Weiner wrote: > > On Tue, Nov 29, 2022 at 11:03:45PM +0900, Sergey Senozhatsky wrote: > > On (22/11/29 12:53), Vitaly Wool wrote: > > > I think the amount of #ifdefs here becomes absolutely overwhelming. > > > Not that zsmalloc code was very readable before, but now it is > > > starting to look like a plain disaster. > > > > Presumably most of them will go away once LRU moved from > > allocator to upper level. > > Yes consider it the "cut here" lines for refactoring the LRU into > zswap, which we want to do next. They're not here to stay, and that > work will remove a lot of duplication and complexity from all > backends. So I hope it's acceptable as a transitionary state. I see, thanks for the explanation. ~Vitaly