From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C88FBC433DB for ; Thu, 28 Jan 2021 08:30:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D87564DD1 for ; Thu, 28 Jan 2021 08:30:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D87564DD1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 800386B0005; Thu, 28 Jan 2021 03:30:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 788F96B0006; Thu, 28 Jan 2021 03:30:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677676B006C; Thu, 28 Jan 2021 03:30:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 4A3E26B0005 for ; Thu, 28 Jan 2021 03:30:27 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0BB0A824999B for ; Thu, 28 Jan 2021 08:30:27 +0000 (UTC) X-FDA: 77754512094.04.wish01_6102b582759e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id E543E800DE02 for ; Thu, 28 Jan 2021 08:30:26 +0000 (UTC) X-HE-Tag: wish01_6102b582759e X-Filterd-Recvd-Size: 6836 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 08:30:26 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id 3so5313431ljc.4 for ; Thu, 28 Jan 2021 00:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=25K7bHJvCeCyOnshVpD2z1d8QA+z57prd7TGMOaOaJQ=; b=KEoTaG24oPPi9j5zrk61ODejrZxNENv5T0Oc01gU7iFis8Ke9aP6YKAJhfuWyq0YIS GlYf3KgcUO4VfpbWrEUGXStFxQuW6mcX0uEdgMD2TFIapDsOeBGJOwwYcp1KK56LeEf3 NkahzS8PEi1k5ayoWduPpXbCJt8geX2eJwbfI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=25K7bHJvCeCyOnshVpD2z1d8QA+z57prd7TGMOaOaJQ=; b=HeDCuHFVQ1+VQ8aT5A3WBoqlX+og1L6zD98V3GLGOXe3LS0X7/rLWXa/ok65EuEHuu XHUbhUQ4KzXuCnD4Qycvt7jXOpUQ7YxAU2tcHyYRXfpnFZmOEJ7XikxsoZGtvz0wS2ks sSb9qQr7zw1pAqoQzl2hDGyfjzdylPTACdq86om2UJqBcYz2Mn42QEtXFOAckJVewUVl 6gluAf/wAuz23NPdYc4lR+JKDoIFHQ+t8Bf2lOnszIvdR/5qrxlICGNnnmjIxufk6NAh lorFczox+/HF/scMoKBr9eXo4fqT+Qz/lyT5ycB+h89Ae+Sro0WLv2OrANxbbVSafQ7Q 6p8g== X-Gm-Message-State: AOAM5311jaIaqHdSzQ6Bi8QX6VbAKmFneqTkEeyTzvBVAjl+XGp8PPIf z6Vb2EBGcQrbKpEbd24yNqkyHdpw85uvpApDMIgcxQ== X-Google-Smtp-Source: ABdhPJxLk1XWejl0dbD7ZrAvgrfsMaOeZIVesmgVArlWSK4rbvGiZhbDC9rfa31ObFGezB62ECFbOREeEyEw9A7ie8w= X-Received: by 2002:a2e:b4dc:: with SMTP id r28mr2869424ljm.22.1611822624766; Thu, 28 Jan 2021 00:30:24 -0800 (PST) MIME-Version: 1.0 References: <1611223030-58346-1-git-send-email-tiantao6@hisilicon.com> In-Reply-To: From: Vitaly Wool Date: Thu, 28 Jan 2021 09:30:15 +0100 Message-ID: Subject: Re: [PATCH] mm/zswap: fix variable 'entry' is uninitialized when used To: Souptick Joarder Cc: Tian Tao , Seth Jennings , Barry Song , Dan Streetman , Andrew Morton , Linux-MM Content-Type: multipart/alternative; boundary="000000000000fd8f3405b9f1b29f" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000fd8f3405b9f1b29f Content-Type: text/plain; charset="UTF-8" On Thu, Jan 28, 2021, 5:09 AM Souptick Joarder wrote: > On Thu, Jan 21, 2021 at 3:27 PM Tian Tao wrote: > > > > the entry has not been initialized when it is used, so allocate PAGE_SIZE > > Can you please add the original error msg in change logs ? > I second that. Another option would be to come up with an update of the original patch which would incorporate all the fixes. I believe it should be possible, since the initial patch has not been merged into Linus tree. Best regards, Vitaly > > > > Signed-off-by: Tian Tao > > Reported-by: kernel test robot > > --- > > mm/zswap.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/zswap.c b/mm/zswap.c > > index 6e0bb61..4b7b6ad 100644 > > --- a/mm/zswap.c > > +++ b/mm/zswap.c > > @@ -944,7 +944,7 @@ static int zswap_writeback_entry(struct zpool *pool, > unsigned long handle) > > > > if (!zpool_can_sleep_mapped(pool)) { > > > > - tmp = kmalloc(entry->length, GFP_ATOMIC); > > + tmp = kmalloc(PAGE_SIZE, GFP_ATOMIC); > > if (!tmp) > > return -ENOMEM; > > } > > -- > > 2.7.4 > > > > > --000000000000fd8f3405b9f1b29f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Jan 28, 2021, 5:09 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
On Thu, Jan 21, 2021 at 3:27 PM Tian = Tao <tiantao6@hisilicon.com> wrote:
>
> the entry has not been initialized when it is used, so allocate PAGE_S= IZE

Can you please add the original error msg in change logs ?
=

I second that. An= other option would be to come up with an update of the original patch which= would incorporate all the fixes. I believe it should be possible, since th= e initial patch has not been merged into Linus tree.

Best regards,
=C2=A0 = =C2=A0Vitaly


>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> Reported-by: kernel test robot <lkp@intel.com>
> ---
>=C2=A0 mm/zswap.c | 2 +-
>=C2=A0 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/zswap.c b/mm/zswap.c
> index 6e0bb61..4b7b6ad 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -944,7 +944,7 @@ static int zswap_writeback_entry(struct zpool *poo= l, unsigned long handle)
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!zpool_can_sleep_mapped(pool)) {<= br> >
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tmp =3D kmallo= c(entry->length, GFP_ATOMIC);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tmp =3D kmallo= c(PAGE_SIZE, GFP_ATOMIC);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!tmp)=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0return -ENOMEM;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> --
> 2.7.4
>
>
--000000000000fd8f3405b9f1b29f--