From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 953EAC433F5 for ; Wed, 2 Mar 2022 08:38:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F0D38D000A; Wed, 2 Mar 2022 03:38:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 278988D0009; Wed, 2 Mar 2022 03:38:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1682F8D000A; Wed, 2 Mar 2022 03:38:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 089148D0009 for ; Wed, 2 Mar 2022 03:38:33 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C16BA21FC9 for ; Wed, 2 Mar 2022 08:38:32 +0000 (UTC) X-FDA: 79198794864.14.AFD5A89 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by imf16.hostedemail.com (Postfix) with ESMTP id 14D22180008 for ; Wed, 2 Mar 2022 08:38:31 +0000 (UTC) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-2db2add4516so8878557b3.1 for ; Wed, 02 Mar 2022 00:38:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GlU4TXYlkTTCcgX0TmwwrU9v30UNuB5Nx7hIbvCH79w=; b=Jc66LOst6QR8VL/b95HK7zFdKQGbi3a9Rsgb8DN8HPLYEFm9yQjI6AxDCxDFaSoj6o LHn6vQcwPaw4J6Eja+hMkL4mQaXtZd6l0rKqk3RoLthCBCfFisxtE08wxG4ELRnbIcto Jl6ys1bWQcjvQT75z5urAoFx6XeqJnts1rJBw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GlU4TXYlkTTCcgX0TmwwrU9v30UNuB5Nx7hIbvCH79w=; b=LBYgQBX4FY0tQlFKNPLQZdceAnLtAm3srqwvdLr6bC/ysTEZVQQ/S6OZpFjKbODGg5 JrCDIsBldjL7RSUO9Mokit2pOmh6J9pViXwGx3Qd2qzUGSAK2tQeSBJ/w2/V5ZtreBdA Jg2OZ0XFGe4L0+2iI5FPgE8CYmL6YhL4Dmi8CmvVhmGLAUKPL1jYbX9Pi1MXYctCFO4E n/OhYG4STaQ4RPkao8BXt+ZuJKzMzNZRIZOr5QOeLIY5PC0dN8Xrcu0x+cW8fLB/em3H bVTOeYOmV1IkvJ6M/bQmV5nXbAilwAh1LkGXd2jfnOyfrJpoAPFHRM7/krper5zvQojs a/yg== X-Gm-Message-State: AOAM531s05IvYUe9snIucz5DuLH91X8ujpX8Z/ACJ9KoyxmnNVqMOvVr sRrN2Ia1c9hx/5yRp1DoKbVePxbnvdpxp9agLTLQ2qGBhak= X-Google-Smtp-Source: ABdhPJzYP+esyqhcv/ZQDdGRUAX4qeihGVbzL6ECMljI6IwMc5NLcqqq/4HKvuvzf4G1nwtaSJF6gXScMe7WPzTdZEA= X-Received: by 2002:a81:1143:0:b0:2db:ccb4:b0a1 with SMTP id 64-20020a811143000000b002dbccb4b0a1mr9445925ywr.499.1646210309769; Wed, 02 Mar 2022 00:38:29 -0800 (PST) MIME-Version: 1.0 References: <20220219092533.12596-1-linmiaohe@huawei.com> <20220219092533.12596-8-linmiaohe@huawei.com> In-Reply-To: <20220219092533.12596-8-linmiaohe@huawei.com> From: Vitaly Wool Date: Wed, 2 Mar 2022 09:38:18 +0100 Message-ID: Subject: Re: [PATCH 7/9] mm/z3fold: remove redundant list_del_init of zhdr->buddy in z3fold_free To: Miaohe Lin Cc: Andrew Morton , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 14D22180008 X-Stat-Signature: os94ypbre6pb1z5wuayaxa1w8w5ut9mk Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=Jc66LOst; spf=pass (imf16.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com X-HE-Tag: 1646210311-456926 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 19, 2022 at 10:26 AM Miaohe Lin wrote: > > The do_compact_page will do list_del_init(&zhdr->buddy) for us. Remove this > extra one to save some possible cpu cycles. > > Signed-off-by: Miaohe Lin Reviewed-by: Vitaly Wool > --- > mm/z3fold.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/z3fold.c b/mm/z3fold.c > index 18a697f6fe32..867c590df027 100644 > --- a/mm/z3fold.c > +++ b/mm/z3fold.c > @@ -1244,9 +1244,6 @@ static void z3fold_free(struct z3fold_pool *pool, unsigned long handle) > return; > } > if (zhdr->cpu < 0 || !cpu_online(zhdr->cpu)) { > - spin_lock(&pool->lock); > - list_del_init(&zhdr->buddy); > - spin_unlock(&pool->lock); > zhdr->cpu = -1; > kref_get(&zhdr->refcount); > clear_bit(PAGE_CLAIMED, &page->private); > -- > 2.23.0 >