From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 029A5ECAAA2 for ; Sun, 28 Aug 2022 20:44:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 438D2940008; Sun, 28 Aug 2022 16:44:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E804940007; Sun, 28 Aug 2022 16:44:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B04C940008; Sun, 28 Aug 2022 16:44:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1D09B940007 for ; Sun, 28 Aug 2022 16:44:16 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E7D461C5F0F for ; Sun, 28 Aug 2022 20:44:15 +0000 (UTC) X-FDA: 79850178870.03.34D55BD Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf06.hostedemail.com (Postfix) with ESMTP id 757A0180032 for ; Sun, 28 Aug 2022 20:44:15 +0000 (UTC) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-33dba2693d0so153086887b3.12 for ; Sun, 28 Aug 2022 13:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=GfepdS5O9XYynQjdDpQ2QWfx+aCRCfAcOwJTSIxj1oo=; b=nIoiZdYnTi54Z3ipGUCFn05Bm16+NE3zcN9Yo2UH9sySii3AIRL2YsknrpvYksVydT JaGB2YBYzOJwief0MBPuwPGb6mJL1a5khg12PGgO7/ZuZyD7N0HPMtVeC+mNnAS1UjM8 SIovSMmigxmU115dT9ZD6/ky3DFhy9YOKm7EU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=GfepdS5O9XYynQjdDpQ2QWfx+aCRCfAcOwJTSIxj1oo=; b=O4fomPe+o3CEPLEt/wdEFiUc5nCse6VOYZTGnkKa9mFslVuA6NeiZmaZ0eqHrFLA2a espTIP3tYzP6Y8wDKqxYzDA2x3TGvkdEURE7Q3EA7ZKh3k7vmwCFQONvqP6NXQhKaCs0 4Wj3lDCv6eHXDEjb/lDTLvemo0OEAdjERK+0XG7BppnBOsXM5Qzhi/2TO/9fQVUEs9Wo kDuObWwGh+Iv76c4sNXFHdnkt0vUNKnXra3VsY6oKwoUs/7Z/CjPJESjHzArNXe3TPtc 0D5/3LfhhswFp+xXfY+mSFWoAyuHDpEhCD5OACWWIMNq3COldigzow2BuHioX/L1/nmU K2cw== X-Gm-Message-State: ACgBeo3WdW7ShkHPIp1SU2SP5UNrU9tC6bAiK4w2/iXrViCVdjj2Jmze itrA+bCyyiYKv/VFg8ikUpTLjgqzpwGjGHQ9Hk28Yg== X-Google-Smtp-Source: AA6agR7El3Dd/ECGpH9gMqYL31M+P4NYZrktD7IPQCVdmKHkFSSnExGbXtGXARgfkDcQrw52XW/YAsBXO+Vc1q+Jetc= X-Received: by 2002:a25:cf81:0:b0:695:d67e:bc44 with SMTP id f123-20020a25cf81000000b00695d67ebc44mr5926895ybg.561.1661719454563; Sun, 28 Aug 2022 13:44:14 -0700 (PDT) MIME-Version: 1.0 References: <20220827104600.1813214-1-liushixin2@huawei.com> <20220827104600.1813214-2-liushixin2@huawei.com> In-Reply-To: <20220827104600.1813214-2-liushixin2@huawei.com> From: Vitaly Wool Date: Sun, 28 Aug 2022 22:44:03 +0200 Message-ID: Subject: Re: [PATCH -next v3 1/5] frontswap: skip frontswap_ops init if zswap init failed. To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kefeng Wang Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=nIoiZdYn; spf=pass (imf06.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661719455; a=rsa-sha256; cv=none; b=QaUw2nwaDMEymYrbOwMqJJkChCdkdFe0CfPl0C3KurqB+MfX+YpKwPgFL0d17NJ2O9PioK ivsFeV9t6mMKW1HOP/19j59dn3yf9cClpIRB4CutudTrN2+jrFU4TYVoR4gNiIsM/T3LGZ mPoyKM2p5E47ycNuFfp9sDsiHBoLVTI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661719455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GfepdS5O9XYynQjdDpQ2QWfx+aCRCfAcOwJTSIxj1oo=; b=4lja2wHtWYt+FXZhafvhJ6tvXCTcZ8pN+9wa8pzyWK6PtnbitVvZs9pmYoEctZkVejF3TO pxUoKAOo6K1BVahh7rEBYfmeiLBfD7llVoQlW8R0pIKF1ZuqPLvUb9rGWJV41NzQaS5nr1 gDjG4vaN8BTd143EpOJieJaN4QJOAKA= X-Rspam-User: X-Stat-Signature: wkdck6xis5bdtxjref7p7xc55fdob1aw X-Rspamd-Queue-Id: 757A0180032 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=nIoiZdYn; spf=pass (imf06.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com X-Rspamd-Server: rspam09 X-HE-Tag: 1661719455-870711 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 27, 2022 at 12:12 PM Liu Shixin wrote: > > If zswap initial failed or has not been initial, frontswap_ops will be > NULL. In such situation, swap device would enable failed with following > stack trace: > > Unable to handle kernel access to user memory outside uaccess routines at virtual address 0000000000000000 > Mem abort info: > ESR = 0x0000000096000004 > EC = 0x25: DABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x04: level 0 translation fault > Data abort info: > ISV = 0, ISS = 0x00000004 > CM = 0, WnR = 0 > user pgtable: 4k pages, 48-bit VAs, pgdp=00000020a4fab000 > [0000000000000000] pgd=0000000000000000, p4d=0000000000000000 > Internal error: Oops: 96000004 [#1] SMP > Modules linked in: zram fsl_dpaa2_eth pcs_lynx phylink ahci_qoriq crct10dif_ce ghash_ce sbsa_gwdt fsl_mc_dpio nvme lm90 nvme_core at803x xhci_plat_hcd rtc_fsl_ftm_alarm xgmac_mdio ahci_platform i2c_imx ip6_tables ip_tables fuse > Unloaded tainted modules: cppc_cpufreq():1 > CPU: 10 PID: 761 Comm: swapon Not tainted 6.0.0-rc2-00454-g22100432cf14 #1 > Hardware name: SolidRun Ltd. SolidRun CEX7 Platform, BIOS EDK II Jun 21 2022 > pstate: 00400005 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : frontswap_init+0x38/0x60 > lr : __do_sys_swapon+0x8a8/0x9f4 > sp : ffff80000969bcf0 > x29: ffff80000969bcf0 x28: ffff37bee0d8fc00 x27: ffff80000a7f5000 > x26: fffffcdefb971e80 x25: ffffaba797453b90 x24: 0000000000000064 > x23: ffff37c1f209d1a8 x22: ffff37bee880e000 x21: ffffaba797748560 > x20: ffff37bee0d8fce4 x19: ffffaba797748488 x18: 0000000000000014 > x17: 0000000030ec029a x16: ffffaba795a479b0 x15: 0000000000000000 > x14: 0000000000000000 x13: 0000000000000030 x12: 0000000000000001 > x11: ffff37c63c0aba18 x10: 0000000000000000 x9 : ffffaba7956b8c88 > x8 : ffff80000969bcd0 x7 : 0000000000000000 x6 : 0000000000000000 > x5 : 0000000000000001 x4 : 0000000000000000 x3 : ffffaba79730f000 > x2 : ffff37bee0d8fc00 x1 : 0000000000000000 x0 : 0000000000000000 > Call trace: > frontswap_init+0x38/0x60 > __do_sys_swapon+0x8a8/0x9f4 > __arm64_sys_swapon+0x28/0x3c > invoke_syscall+0x78/0x100 > el0_svc_common.constprop.0+0xd4/0xf4 > do_el0_svc+0x38/0x4c > el0_svc+0x34/0x10c > el0t_64_sync_handler+0x11c/0x150 > el0t_64_sync+0x190/0x194 > Code: d000e283 910003fd f9006c41 f946d461 (f9400021) > ---[ end trace 0000000000000000 ]--- > Well, this issue you are seeing is in fact introduced by the following patch: author Christoph Hellwig 2022-01-21 22:15:10 -0800 frontswap: remove support for multiple ops So I would rather see that one reverted and fixed. Thanks, Vitaly > Reported-by: Nathan Chancellor > Signed-off-by: Liu Shixin > --- > mm/frontswap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/frontswap.c b/mm/frontswap.c > index 1a97610308cb..620f95af81dd 100644 > --- a/mm/frontswap.c > +++ b/mm/frontswap.c > @@ -125,7 +125,8 @@ void frontswap_init(unsigned type, unsigned long *map) > * p->frontswap set to something valid to work properly. > */ > frontswap_map_set(sis, map); > - frontswap_ops->init(type); > + if (frontswap_ops) > + frontswap_ops->init(type); > } > > static bool __frontswap_test(struct swap_info_struct *sis, > -- > 2.25.1 >