From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E13DC433F5 for ; Wed, 2 Mar 2022 08:23:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DEA38D0002; Wed, 2 Mar 2022 03:23:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 08DD88D0001; Wed, 2 Mar 2022 03:23:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE6568D0002; Wed, 2 Mar 2022 03:23:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id DFE0F8D0001 for ; Wed, 2 Mar 2022 03:23:00 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9DD6996768 for ; Wed, 2 Mar 2022 08:23:00 +0000 (UTC) X-FDA: 79198755720.26.22AD633 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf16.hostedemail.com (Postfix) with ESMTP id 16F82180009 for ; Wed, 2 Mar 2022 08:22:59 +0000 (UTC) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-2d07ae0b1c4so8146747b3.11 for ; Wed, 02 Mar 2022 00:22:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rzapgAUyKoJq0tJStFGL7TnQDA9QwFfn3d0fRWN05EI=; b=Mb6EF1IqUQplrdckkYJaWOPWFlbpamBSXlnWHkeFzL5xVU8l9Af4VjCCYjJ1rXGtHF ktCj77UQ8uZK6tLF105LmuwST4YlAMKLP8Vu2XVKUtyhpTap4PpVmLWKOPNdCBp4WNrb nIKcJ2aD+N9+yZAOMdtrZUB8U5akWovR4/vxs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rzapgAUyKoJq0tJStFGL7TnQDA9QwFfn3d0fRWN05EI=; b=46knh+hOl+rG17QGGOnH8XeGH+bZzcRRIjtaEoQ55Speg1CFp6yX0ozwGKs2Wy2fv/ fE4M5Crlj98I044I9FpBadLGszh0T+5Oebt5H93q42o3e0UhEKDxxzWjNAZN2NwnqKZz EiKRLKYdwfei7MjhsvoxXcy+L/7oreTLotQzCDgGFjR6EKFnB0zxNvqeQK8AlRZOiI6U kVZrzwdP32RkrAfVtvdVGC9F0pSYuN02hLYjxppUYSztHdsPe5aXZW5fMQ+nmIKrx6++ XoT0QJ3HuGRKfWu41tiZkAceXS/X8c618sm2Wv3Ci2MrBjeXY8n/jcTgYdxmtgkrlGtT RNIg== X-Gm-Message-State: AOAM533urA+bjuDPSAfyCUS+h6xs3Xtx4uR1xCKjkWOQ+BQpyVZ/2lxr WA0PgaK90MtpCyCAmVcKBbcWbbbwl2eEnaJ/zVXngFMycF0= X-Google-Smtp-Source: ABdhPJzeeVdz4NAS+ovirSZ++TOJF6ZtWiQgMOOEOXtVPqJgdpLR0WgLjmNaqBKPWjmOCGSRyv9eGGJMetKEcbJ704o= X-Received: by 2002:a81:6e44:0:b0:2d0:b675:a0 with SMTP id j65-20020a816e44000000b002d0b67500a0mr28372775ywc.352.1646209379370; Wed, 02 Mar 2022 00:22:59 -0800 (PST) MIME-Version: 1.0 References: <20220219092533.12596-1-linmiaohe@huawei.com> <20220219092533.12596-5-linmiaohe@huawei.com> In-Reply-To: <20220219092533.12596-5-linmiaohe@huawei.com> From: Vitaly Wool Date: Wed, 2 Mar 2022 09:22:48 +0100 Message-ID: Subject: Re: [PATCH 4/9] mm/z3fold: remove unneeded page_mapcount_reset and ClearPagePrivate To: Miaohe Lin Cc: Andrew Morton , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 16F82180009 X-Stat-Signature: jbz1e4d6unzw63a4tbtcd36wq5ryerjr Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=Mb6EF1Iq; spf=pass (imf16.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com X-HE-Tag: 1646209379-440664 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 19, 2022 at 10:26 AM Miaohe Lin wrote: > > Page->page_type and PagePrivate are not used in z3fold. We should remove > these confusing unneeded operations. The z3fold do these here is due to > referring to zsmalloc's migration code which does need these operations. Absolutely, thanks for pointing this out. > Signed-off-by: Miaohe Lin Reviewed-by: Vitaly Wool > --- > mm/z3fold.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/z3fold.c b/mm/z3fold.c > index eb89271aea83..2f848ea45b4d 100644 > --- a/mm/z3fold.c > +++ b/mm/z3fold.c > @@ -420,7 +420,6 @@ static void free_z3fold_page(struct page *page, bool headless) > __ClearPageMovable(page); > unlock_page(page); > } > - ClearPagePrivate(page); > __free_page(page); > } > > @@ -1635,7 +1634,6 @@ static int z3fold_page_migrate(struct address_space *mapping, struct page *newpa > INIT_LIST_HEAD(&new_zhdr->buddy); > new_mapping = page_mapping(page); > __ClearPageMovable(page); > - ClearPagePrivate(page); > > get_page(newpage); > z3fold_page_lock(new_zhdr); > @@ -1655,7 +1653,6 @@ static int z3fold_page_migrate(struct address_space *mapping, struct page *newpa > > queue_work_on(new_zhdr->cpu, pool->compact_wq, &new_zhdr->work); > > - page_mapcount_reset(page); > clear_bit(PAGE_CLAIMED, &page->private); > put_page(page); > return 0; > -- > 2.23.0 >