From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B6FC433F5 for ; Wed, 2 Mar 2022 08:19:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A20D8D0002; Wed, 2 Mar 2022 03:19:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 351238D0001; Wed, 2 Mar 2022 03:19:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2414E8D0002; Wed, 2 Mar 2022 03:19:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 166D08D0001 for ; Wed, 2 Mar 2022 03:19:01 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BD9518249980 for ; Wed, 2 Mar 2022 08:19:00 +0000 (UTC) X-FDA: 79198745640.27.5F55AA7 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by imf04.hostedemail.com (Postfix) with ESMTP id 3E6E540004 for ; Wed, 2 Mar 2022 08:19:00 +0000 (UTC) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-2d07ae0b1bfso8233027b3.6 for ; Wed, 02 Mar 2022 00:19:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=atOhUCKt1iNHeGULDxxyHd5Ye93aTurT561sTor+wwk=; b=UfpqrlNeV8QfcsKl+6EUXinBdkP8H6zxJRyw+c9ua2pryonEjbDZZqNXIyYcCPkdpL lu0/qLKih9YBlC3e4V4WvNw3i9uuZLx/vMPFdaXewq9kiQzhV/R40LpFbnV6RUZcYN25 L2rM/kU7c3YUFgI6hiKKRWKTuQ1CriE843acY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=atOhUCKt1iNHeGULDxxyHd5Ye93aTurT561sTor+wwk=; b=lG2JX2uWHhyQa0QnDdmDg4s9pB/yp3UgXd2Nvy5Y6uY2NFzTESjAow9SYRmfcPivIU G0cUuM5HM2SEjiWuOQulKJfM3V++/sOivZ85H+c3VhOdL3/lOn84WYC04vTkxi7346QD AVVVMW2FclYPsoXOOPGEqDi81h2tcR/SeG4HikVR8Vc0K1OH8S0GkUUimrs/tePKTI0i zlT0rCh6liq0m9YZXmfueKImcMiHlIN3KOmxFTWR0OHoMQIsLhe8PIec51AqzOEsJVT1 YGoEz7DvDt8lB5JfF8zv2Y5TxrT+pPp8rlCmXEjPDKQ5fih4VjA4iyl8VOGAdLBMwPr9 yrqA== X-Gm-Message-State: AOAM530M2LnOEKlvmmV5guGcgSyqS99/PM6DvLJ4AFMMM7MCKf6v5Wpu BKQRw4SjftruPCzdKP2OQ+mPm5sEzmfUs0eF9ZeRLw== X-Google-Smtp-Source: ABdhPJzvda6h0GVBzSzY9PX/SwfJGHPvt6tyXw3+GbJKops158/VF3L6GKAtZE93eje4ejQpI5LRumtLevq8N4uK7Lk= X-Received: by 2002:a81:6e44:0:b0:2d0:b675:a0 with SMTP id j65-20020a816e44000000b002d0b67500a0mr28364295ywc.352.1646209139543; Wed, 02 Mar 2022 00:18:59 -0800 (PST) MIME-Version: 1.0 References: <20220219092533.12596-1-linmiaohe@huawei.com> <20220219092533.12596-3-linmiaohe@huawei.com> In-Reply-To: <20220219092533.12596-3-linmiaohe@huawei.com> From: Vitaly Wool Date: Wed, 2 Mar 2022 09:18:48 +0100 Message-ID: Subject: Re: [PATCH 2/9] mm/z3fold: remove obsolete comment in z3fold_alloc To: Miaohe Lin Cc: Andrew Morton , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3E6E540004 X-Stat-Signature: k4eggro1xw66yhtdjf3xc53ctfpfhuty Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=konsulko.com header.s=google header.b=UfpqrlNe; spf=pass (imf04.hostedemail.com: domain of vitaly.wool@konsulko.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=vitaly.wool@konsulko.com; dmarc=pass (policy=none) header.from=konsulko.com X-HE-Tag: 1646209140-628804 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 19, 2022 at 10:26 AM Miaohe Lin wrote: > > The highmem pages are supported since commit f1549cb5ab2b ("mm/z3fold.c: > allow __GFP_HIGHMEM in z3fold_alloc"). Remove the residual comment. > > Signed-off-by: Miaohe Lin Reviewed-by: Vitaly Wool > --- > mm/z3fold.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/z3fold.c b/mm/z3fold.c > index e86aafea6599..87689f50f709 100644 > --- a/mm/z3fold.c > +++ b/mm/z3fold.c > @@ -1064,9 +1064,6 @@ static void z3fold_destroy_pool(struct z3fold_pool *pool) > * performed first. If no suitable free region is found, then a new page is > * allocated and added to the pool to satisfy the request. > * > - * gfp should not set __GFP_HIGHMEM as highmem pages cannot be used > - * as z3fold pool pages. > - * > * Return: 0 if success and handle is set, otherwise -EINVAL if the size or > * gfp arguments are invalid or -ENOMEM if the pool was unable to allocate > * a new page. > -- > 2.23.0 >