From: Vitaly Wool <vitaly.wool@konsulko.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dan Streetman <ddstreet@ieee.org>,
Seth Jennings <sjenning@redhat.com>,
Linux-MM <linux-mm@kvack.org>, Nhat Pham <nphamcs@gmail.com>
Subject: Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
Date: Wed, 17 Jan 2024 10:53:04 +0100 [thread overview]
Message-ID: <CAM4kBB+A=XmWk3PmvQ1RxpX+y7Gr+Yp_kTF1Z6_KddRz+pyrog@mail.gmail.com> (raw)
In-Reply-To: <CAJD7tkaW=z0nbsj2Cjt4ypND+_tsDLgO_PiT-UF__+XpTRPYgg@mail.gmail.com>
On Wed, Jan 17, 2024 at 4:13 AM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> > > Probably a bit too late, but should we also merge the zpool entry with
> > > the zswap entry? I can send a follow up if we are in agreement.
> >
> >
> > I am afraid we are not. That would be one more step in the wrong direction.
>
> Do you mind elaborating the reason? Zpool is only to abstract the
> zswap allocators, it makes sense that it is tightly coupled with
> zswap, no?
Hmm, I must admit I misread your sentence. Sorry about that.
Please disregard my previous comment, merging zpool with zswap sounds
good to me.
~Vitaly
prev parent reply other threads:[~2024-01-17 9:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 17:43 Yosry Ahmed
2024-01-09 19:02 ` Johannes Weiner
2024-01-09 19:32 ` Nhat Pham
2024-01-10 15:51 ` Dan Streetman
2024-01-10 15:53 ` Dan Streetman
2024-01-10 16:14 ` Seth Jennings
2024-01-14 18:53 ` Yosry Ahmed
2024-01-14 22:47 ` Nhat Pham
2024-01-16 13:14 ` Dan Streetman
2024-01-16 13:46 ` Vitaly Wool
2024-01-17 3:12 ` Yosry Ahmed
2024-01-17 9:53 ` Vitaly Wool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM4kBB+A=XmWk3PmvQ1RxpX+y7Gr+Yp_kTF1Z6_KddRz+pyrog@mail.gmail.com' \
--to=vitaly.wool@konsulko.com \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sjenning@redhat.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox