From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f173.google.com (mail-ig0-f173.google.com [209.85.213.173]) by kanga.kvack.org (Postfix) with ESMTP id AD5556B0036 for ; Wed, 24 Sep 2014 18:45:39 -0400 (EDT) Received: by mail-ig0-f173.google.com with SMTP id l13so7452608iga.6 for ; Wed, 24 Sep 2014 15:45:39 -0700 (PDT) Received: from mail-ig0-x234.google.com (mail-ig0-x234.google.com [2607:f8b0:4001:c05::234]) by mx.google.com with ESMTPS id j1si1245082igo.8.2014.09.24.15.45.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Sep 2014 15:45:38 -0700 (PDT) Received: by mail-ig0-f180.google.com with SMTP id a13so7410411igq.1 for ; Wed, 24 Sep 2014 15:45:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20140924145927.04e8eb7ba6c1410a797293c7@linux-foundation.org> References: <1411200187-40896-1-git-send-email-pfeiner@google.com> <20140924145927.04e8eb7ba6c1410a797293c7@linux-foundation.org> Date: Wed, 24 Sep 2014 15:45:38 -0700 Message-ID: Subject: Re: [PATCH] mm: softdirty: keep bit when zapping file pte From: Peter Feiner Content-Type: multipart/alternative; boundary=bcaec5186b0a5f97750503d771ff Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Cyrill Gorcunov , Pavel Emelyanov , Jamie Liu , linux-mm@kvack.org, Hugh Dickins , linux-kernel@vger.kernel.org --bcaec5186b0a5f97750503d771ff Content-Type: text/plain; charset=UTF-8 On Sep 24, 2014 2:59 PM, "Andrew Morton" wrote: > > On Sat, 20 Sep 2014 01:03:07 -0700 Peter Feiner wrote: > > > Fixes the same bug as b43790eedd31e9535b89bbfa45793919e9504c34 and > > 9aed8614af5a05cdaa32a0b78b0f1a424754a958 where the return value of > > pte_*mksoft_dirty was being ignored. > > > > To be sure that no other pte/pmd "mk" function return values were > > being ignored, I annotated the functions in > > arch/x86/include/asm/pgtable.h with __must_check and rebuilt. > > > > Grumble. > > It is useful to identify preceding similar patches but that isn't a > good way of describing *this* patch. What is wrong with the current > code, how does the patch fix it. > > And, particularly, what do you think are the end-user visible effects > of the bug? This info helps people to work out which kernel versions > need the fix. > Let me think about this and cook up a test case. I'll submit a v2 with a better description. Peter --bcaec5186b0a5f97750503d771ff Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Sep 24, 2014 2:59 PM, "Andrew Morton" <akpm@linux-foundation.org> w= rote:
>
> On Sat, 20 Sep 2014 01:03:07 -0700 Peter Feiner <pfeiner@google.com> wrote:
>
> > Fixes the same bug as b43790eedd31e9535b89bbfa45793919e9504c34 an= d
> > 9aed8614af5a05cdaa32a0b78b0f1a424754a958 where the return value o= f
> > pte_*mksoft_dirty was being ignored.
> >
> > To be sure that no other pte/pmd "mk" function return v= alues were
> > being ignored, I annotated the functions in
> > arch/x86/include/asm/pgtable.h with __must_check and rebuilt.
> >
>
> Grumble.
>
> It is useful to identify preceding similar patches but that isn't = a
> good way of describing *this* patch.=C2=A0 What is wrong with the curr= ent
> code, how does the patch fix it.
>
> And, particularly, what do you think are the end-user visible effects<= br> > of the bug?=C2=A0 This info helps people to work out which kernel vers= ions
> need the fix.
>

Let me think about this and cook up a test case. I'll su= bmit a v2 with a better description.

Peter

--bcaec5186b0a5f97750503d771ff-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org