From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B40C4167B for ; Mon, 30 Oct 2023 18:21:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52E2D6B027B; Mon, 30 Oct 2023 14:21:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B73E6B027E; Mon, 30 Oct 2023 14:21:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37F7C6B027F; Mon, 30 Oct 2023 14:21:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 24F6C6B027B for ; Mon, 30 Oct 2023 14:21:44 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E961E140A09 for ; Mon, 30 Oct 2023 18:21:43 +0000 (UTC) X-FDA: 81402946086.28.2CD2A83 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf06.hostedemail.com (Postfix) with ESMTP id 0393118002C for ; Mon, 30 Oct 2023 18:21:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hWs8WK1U; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of dmatlack@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=dmatlack@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698690102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+/9ggluaJ++InohprDPxvdU7Uw478trPLaD3bhLrtl4=; b=RoWKhr27MyR7eBsGzxupOA7iklz64wDCXmgR0PLCjuaHF/C/Jczh8y6eT3SngipGCzk4Ay G2Hk4dmzw4MIM2Jzo8BMawPkDl5idurJCzI6q4cCl1q5aw8jVONRBnrq7xHAIbp4yGvczJ esjVq0GxLjHkZ9KwmnxDsSt9VzXs1R0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hWs8WK1U; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of dmatlack@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=dmatlack@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698690102; a=rsa-sha256; cv=none; b=5mUT8XnkeWe8e8M9HhutmVsS9Wt5S7f7MuKiAxdLayk4se7TloISuUarLOq1kh1Kd85Uij PhcLJ9rwnoBTMTHqNdFh6sOEY6gve1fbRsUTCaOZo29NgGyKyohhdWsSzGWueHhhdhj0o3 KfXm2Q11Lz+nsIl7DGoGei422NExnVI= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4083dbc43cfso32007605e9.3 for ; Mon, 30 Oct 2023 11:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698690100; x=1699294900; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+/9ggluaJ++InohprDPxvdU7Uw478trPLaD3bhLrtl4=; b=hWs8WK1UEh+qYLESxeZT5hDUcxvsh/LYkXqlfg+442oJg2whHpaMnOHOZiOElxOYSe ASLxyr4MRZ2A0k/MXkADRebIyvE4D2tWg5BXLGo9wnc3+FLmUor6jnoh79vJf05i5R5R VYqUshrNH2HkZa2d82orNbZwaMdPMAAoY5WveHHmC8ZKvM6Y5fUmKh+g3hJYtuuKtmqv H9efVv3qZ3fj46VF3Xyo5C7SQ+LGMJLq1Gs5n2xcBiHeq2sJMRkpOwX3UvO3ZRWh+u+T TFyH++BUPZvVrUqEfDnALrgbREp+H4iVsr/zI+xDEHcjc+ny+kL8mho4b+sBNr217oTW A1GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698690100; x=1699294900; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+/9ggluaJ++InohprDPxvdU7Uw478trPLaD3bhLrtl4=; b=RrCR4kEkr+FgceYGAY1QA777NrH8JJEbeo1K7HGaAtwNX1SeQLWHYQMbGQI5TY194V TBhlzdbYEpctV1Ina1pnRU+8UxJwmz0UR4ExYuB/S7rQ0+rmkvHcAGqS7HrY3SJnqqcu KNLmi1XSJycaX7bK58Owr1Z4joaApT68fq+1oTm8cB3ecX/hG3AF4i/RMuGJXV22oKdF HD76VeQJUCZK5ir6q3cIZqrTfYEa9eDiE/+5qP3eCjW1Ok2px0aU6SVgFIdNmMolBcCk 1125raNqOipnPi+46agzDyFEUogRFeWw47+zwSCiH7hJ0XLSINCLd74gOSpnCzXqRM6A Pefg== X-Gm-Message-State: AOJu0YzKAG+NJP7fldPWg4/+H+YSJ2aG0tSQ03VaHPdEqyMnp4xJEUFY ONAOWmjT7IXmdpXebKZXlnYJY+5cvkLlCxeyg2iZOA== X-Google-Smtp-Source: AGHT+IEmwHEAyRl4O1ADBUXlJ8Ir1QajxdHcmQhP1+JwZ6AL7EQf1l2WpAn/vfiQDkHuuhxFizw+5mWU1UT2yp1CF+k= X-Received: by 2002:a05:600c:524a:b0:408:4160:1528 with SMTP id fc10-20020a05600c524a00b0040841601528mr8760818wmb.30.1698690100370; Mon, 30 Oct 2023 11:21:40 -0700 (PDT) MIME-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-4-seanjc@google.com> In-Reply-To: From: David Matlack Date: Mon, 30 Oct 2023 11:21:12 -0700 Message-ID: Subject: Re: [PATCH v13 03/35] KVM: Use gfn instead of hva for mmu_notifier_retry To: Paolo Bonzini Cc: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0393118002C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: m3wrrpoe49eifydaoi1njkks5fhiefdp X-HE-Tag: 1698690101-398827 X-HE-Meta: U2FsdGVkX1/zZ1/EH3it5CqlWKRLjmmKzYl+289XCQn1CpywTO23iRAlEpp9Hguo8Sf+mQKyIoKQC/+unILwxL8oK5DWZzKZsgltUPbg2TADgVMfjpai2JvhU++/rV46iGPyNmnGhwaQt2MELa0yxLbhYJwx/OcedR2ahVb4e6zlnWbw6fwbWly9/iLL31A7jt2Q5m4/NzDX85nhH/fF79uM9n8LfAhu9Cq5FwiowqSujr3kdUxuYpaWWee+Wktxvdr6tlwbBdnIN3gG6MhumE5n4fcDGNEdoh6s3GLTmTVBnq0oS2wXzpD59a7wihfSEgCBUQslr8Uur3zOy6E4vvdlGxyaoM7RF/wB5Y6LucVU66ZqTRxT2sir01tGEBh7+kWCQ1CbI2nkOIyhHfYklR3ZJN7oM+ALKBLR5UlGKnYREVVN1IPkjKai4sKAd82E38m5ZXcKgLwpgeb+QwbQLDtUOl3MXciA9FE6SXmvIpGOm6JsGBc2kf4ZiqTo4OfCfTmo1UE4KYYkupx5t+3qd82XImsPQ58mYbX7pl6bYT+Z/RR8JbLXIAMRE5DeCGLWvn4QKzM216UJ2IHNoOuDtprH5LqdOE5h25SWWWg8eYJNtV07qR4TzElLmzY9imsbwTLpFqzNeEt7TX6gZYnvuCTyPdeN9kQxNg4qQlAtupPpVeTe/QmUAMaYhY8U6udQnnP7UI1egWdC1s3NpYuoGvUuEJArWBSzdXGtsVwLntCkiRGfVNxvnwShd6ED1dejTJgYHaPp/BS5lephpiQaoxQdrA+gVD8JM+k/iZYJTQhXLFZt0c7J5el6l35KhOmSq5uWaMLr8qfP+/is6NL87Lyp0pq0+wjaPUhF1v5hALLeFwxnbJcfI2/FDRkt5IxsyYFS217g258msyrt0zxAMaW3ENjmeSzN9kpxNm8bY9+0XZAq0cdPsn7YWTdtZ1iNUJJPLFzqFSn8URyFesA m0BYhzGd Jbg+NGmySHNCN0+I/IfpGVIE8XU5i+UkI/tn8Ka4vTTmshxYCS69cVbkE7UN61T4QGnuyqlhqqdVLJJOyfpi61TluvFCqT9jH8xQscL2T5mBVRSocKqMQidreYvzI9745BC5S+iziHJdBREj57mzDeCwe1L4j5PUfxjbZSVoIEDFXjav5BgPpIvVy6fC8xAxTkRebC3P+gSofRzDNXbFVvQ6tiJbDiTrBNXtMQIgYrkWYbEWsgNKBfBKbgcH8oFqpp+zPuSGZLdU9JozuM3gsLzDXKQDk/t1IjMUG9tkj/ZTDBCEJsvHDkZyQtlX1R01WemwigSMv3nCt5yMiS8aAGb7jtnl4TbKTBUUzC8p0SnaYOxGV0VrOYU08XerPXVf9QzLddY0RZMjGo1QcuqwviWcFCUbc7j6St70n X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 30, 2023 at 10:01=E2=80=AFAM Paolo Bonzini wrote: > > On Mon, Oct 30, 2023 at 5:53=E2=80=AFPM David Matlack wrote: > > > > On 2023-10-27 11:21 AM, Sean Christopherson wrote: > > > From: Chao Peng > > > > > > Currently in mmu_notifier invalidate path, hva range is recorded and > > > then checked against by mmu_notifier_retry_hva() in the page fault > > > handling path. However, for the to be introduced private memory, a pa= ge > > ^^^^^^^^^^^^^^^^^^^^^^^^ > > > > Is there a missing word here? > > No but there could be missing hyphens ("for the to-be-introduced > private memory"); possibly a "soon" could help parsing and that is > what you were talking about? Ah that explains it :) > > > > if (likely(kvm->mmu_invalidate_in_progress =3D=3D 1)) { > > > + kvm->mmu_invalidate_range_start =3D INVALID_GPA; > > > + kvm->mmu_invalidate_range_end =3D INVALID_GPA; > > > > I don't think this is incorrect, but I was a little suprised to see thi= s > > here rather than in end() when mmu_invalidate_in_progress decrements to > > 0. > > I think that would be incorrect on the very first start? Good point. KVM could initialize start/end before registering notifiers, but that's extra code.