From: David Matlack <dmatlack@google.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Jordan Richards <jordanrichards@google.com>,
Pasha Tatashin <pasha.tatashin@soleen.com>,
Pratyush Yadav <pratyush@kernel.org>,
Shuah Khan <shuah@kernel.org>, Jason Miu <jasonmiu@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/liveupdate: add end to end test infrastructure and scripts
Date: Thu, 29 Jan 2026 14:51:17 -0800 [thread overview]
Message-ID: <CALzav=dKzsuZe=ZLfVg+ENVS0RbfN2jBcHEn+N5Jic=ykHLmWA@mail.gmail.com> (raw)
In-Reply-To: <aXj28ZAsPhp7s5sm@kernel.org>
On Tue, Jan 27, 2026 at 9:33 AM Mike Rapoport <rppt@kernel.org> wrote:
> On Thu, Jan 22, 2026 at 09:44:27PM +0000, Jordan Richards wrote:
> > diff --git a/tools/testing/selftests/liveupdate/.gitignore b/tools/testing/selftests/liveupdate/.gitignore
> > index 661827083ab6..7dc1e8aec44c 100644
> > --- a/tools/testing/selftests/liveupdate/.gitignore
> > +++ b/tools/testing/selftests/liveupdate/.gitignore
> > @@ -6,4 +6,6 @@
> > !*.sh
> > !.gitignore
> > !config
> > +!config.aarch64
> > +!config.x86_64
This could be:
!config.*
> > !Makefile
>
> Hmm, I missed it when tools/testing/selftests/liveupdate/ was posted.
> I'm not a huge fun of negative logic in .gitignore.
> Why can't we just exclude the patterns we don't want to track?
I'm pretty sure this came from me. It's the pattern we use for VFIO
and KVM selftests .gitignore.
Positive logic requires updating .gitignore for every new executable
(every new selftest). Negative logic requires updating .gitignore for
every new one-off files that don't match the existing negative logic.
In my experience with selftests, the former happens more frequently
than the latter, so the negative logic is easier to maintain.
next prev parent reply other threads:[~2026-01-29 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 21:44 Jordan Richards
2026-01-27 17:33 ` Mike Rapoport
2026-01-29 22:51 ` David Matlack [this message]
2026-02-02 21:48 ` Jordan Richards
2026-02-03 18:24 ` Mike Rapoport
2026-02-05 22:11 ` Jordan Richards
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALzav=dKzsuZe=ZLfVg+ENVS0RbfN2jBcHEn+N5Jic=ykHLmWA@mail.gmail.com' \
--to=dmatlack@google.com \
--cc=jasonmiu@google.com \
--cc=jordanrichards@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox