Re: [PATCH v2] mm/numa_memblks: Use pr_debug instead of printk(KERN_DEBUG)

[Pratyush Brahma <pratyush.brahma@oss.qualcomm.com>]

[-- Attachment #1: Type: text/plain, Size: 2057 bytes --]

On Mon, Aug 11, 2025 at 1:31 PM Mike Rapoport <rppt@kernel.org> wrote:

> On Mon, Aug 11, 2025 at 12:13:54PM +0530, pratyush.brahma@oss.qualcomm.com
> wrote:
> > From: Pratyush Brahma <pratyush.brahma@oss.qualcomm.com>
> >
> > Replace the direct usage of printk(KERN_DEBUG ...) with pr_debug(...) to
> > align with the consistent `pr_*` API usage within the file.
> >
> > Reviewed-by: Joshua Hahn <joshua.hahnjy@gmail.com>
> > Signed-off-by: Pratyush Brahma <pratyush.brahma@oss.qualcomm.com>
> > ---
> > Changes in v2:
> > - Removed printk header as suggested by Joshua.
> > - Link to v1:
> https://lore.kernel.org/r/20250808-numa-dbg-v1-1-2ddd1ec634aa@oss.qualcomm.com
> > ---
> >  mm/numa_memblks.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c
> > index
> 541a99c4071a67e5b0ef66f4136dee268a880003..ed6fcfca057ab4c9a8aa26cd1929551b4ded4a5b
> 100644
> > --- a/mm/numa_memblks.c
> > +++ b/mm/numa_memblks.c
> > @@ -2,7 +2,6 @@
> >
> >  #include <linux/array_size.h>
> >  #include <linux/sort.h>
> > -#include <linux/printk.h>
>
> Please don't, pr_debug is defined there.
>
But I had compile tested this code. I wonder why it didn't throw any error.

>
> >  #include <linux/memblock.h>
> >  #include <linux/numa.h>
> >  #include <linux/numa_memblks.h>
> > @@ -76,7 +75,7 @@ static int __init numa_alloc_distance(void)
> >               for (j = 0; j < cnt; j++)
> >                       numa_distance[i * cnt + j] = i == j ?
> >                               LOCAL_DISTANCE : REMOTE_DISTANCE;
> > -     printk(KERN_DEBUG "NUMA: Initialized distance table, cnt=%d\n",
> cnt);
> > +     pr_debug("NUMA: Initialized distance table, cnt=%d\n", cnt);
> >
> >       return 0;
> >  }
> >
> > ---
> > base-commit: 479058002c32b77acac43e883b92174e22c4be2d
> > change-id: 20250808-numa-dbg-62a8b2092c56
> >
> > Best regards,
> > --
> > Pratyush Brahma <pratyush.brahma@oss.qualcomm.com>
> >
>
> --
> Sincerely yours,
> Mike.
>

[-- Attachment #2: Type: text/html, Size: 3369 bytes --]