From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f200.google.com (mail-qk0-f200.google.com [209.85.220.200]) by kanga.kvack.org (Postfix) with ESMTP id 4DBB36B007E for ; Tue, 19 Apr 2016 14:31:03 -0400 (EDT) Received: by mail-qk0-f200.google.com with SMTP id t184so48073026qkh.3 for ; Tue, 19 Apr 2016 11:31:03 -0700 (PDT) Received: from mail-yw0-x243.google.com (mail-yw0-x243.google.com. [2607:f8b0:4002:c05::243]) by mx.google.com with ESMTPS id n186si15628957ywf.17.2016.04.19.11.31.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Apr 2016 11:31:02 -0700 (PDT) Received: by mail-yw0-x243.google.com with SMTP id i22so3495377ywc.1 for ; Tue, 19 Apr 2016 11:31:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20160419182532.423d3c05@redhat.com> References: <1460928725-18741-1-git-send-email-saeedm@mellanox.com> <1460928725-18741-6-git-send-email-saeedm@mellanox.com> <1460939371.10638.97.camel@edumazet-glaptop3.roam.corp.google.com> <1460983695.10638.113.camel@edumazet-glaptop3.roam.corp.google.com> <1460989033.10638.120.camel@edumazet-glaptop3.roam.corp.google.com> <20160419182532.423d3c05@redhat.com> From: Saeed Mahameed Date: Tue, 19 Apr 2016 21:30:42 +0300 Message-ID: Subject: Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ) Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Jesper Dangaard Brouer Cc: Eric Dumazet , Saeed Mahameed , "David S. Miller" , Linux Netdev List , Or Gerlitz , Tal Alon , Tariq Toukan , Eran Ben Elisha , Achiad Shochat , Mel Gorman , linux-mm On Tue, Apr 19, 2016 at 7:25 PM, Jesper Dangaard Brouer wrote: > On Mon, 18 Apr 2016 07:17:13 -0700 > Eric Dumazet wrote: > >> Another idea would be to have a way to control max number of order-5 >> pages that a port would be using. >> >> Since driver always own a ref on a order-5 pages, idea would be to >> maintain a circular ring of up to XXX such pages, so that we can detect >> an abnormal use and fallback to order-0 immediately. > > That is part of my idea with my page-pool proposal. In the page-pool I > want to have some watermark counter that can block/stop the OOM issue at > this RX ring level. > > See slide 12 of presentation: > http://people.netfilter.org/hawk/presentations/MM-summit2016/generic_page_pool_mm_summit2016.pdf > Cool Idea guys, and we already tested our own version of it, we tried to recycle our own driver pages but we saw that the stack took too long to release them, we had to work with 2X and sometimes 4X pages pool per ring to be able to reuse recycled pages on every RX packet on 50Gb line rate, but we dropped the Idea since 2X is too much. but definitely, this is the best way to go for all drivers, reusing already dma mapped pages and significantly reducing dma operations for the driver is a big win ! we are still considering such option as future optimization. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org