From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B24CBD68BFA for ; Sun, 17 Nov 2024 12:57:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FFC06B00B2; Sun, 17 Nov 2024 07:57:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B0706B00B3; Sun, 17 Nov 2024 07:57:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E917A6B00B4; Sun, 17 Nov 2024 07:57:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C2C646B00B2 for ; Sun, 17 Nov 2024 07:57:01 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 790CF1C33A9 for ; Sun, 17 Nov 2024 12:57:01 +0000 (UTC) X-FDA: 82795584858.19.C1A721F Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf27.hostedemail.com (Postfix) with ESMTP id 97A8C40004 for ; Sun, 17 Nov 2024 12:56:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ua8VaOQs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of sxwbruce@gmail.com designates 209.85.167.68 as permitted sender) smtp.mailfrom=sxwbruce@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731848154; a=rsa-sha256; cv=none; b=ETuxVejJzmdEgRi+EUFg08g1KOT6Up73X+nuIxKcgckryiV8mC2W2YUD55vN/3G6sxgXex Ra36a27lWc1x13eme8gfrE47QV1PBgFHbHOGShLI+ek5OHqwmnfo0GNpaSGisI9enUBUpv QPRcC+CmauDasJJUHe9SRLblhchdVzs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ua8VaOQs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of sxwbruce@gmail.com designates 209.85.167.68 as permitted sender) smtp.mailfrom=sxwbruce@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731848154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=svuhUIea1dsD7kkQf8MYGnky2oc1jwagz62kNPGoCLw=; b=rHh0jXLHJN51Goc05iafCxR2Q4gmBn0yrQk1DX9rDgkY2zDXF+M71pqbuti6ARiJXmEYyE bY8OkiuET150UF8Vs1sQh/MGkUsSfg3PczVEFOrdgGcmPAOFXtpbUs/HqAdzr2ZTBqDBOX e28/Onhr1jK4vbD1+OEmKYxXbrrx3O8= Received: by mail-lf1-f68.google.com with SMTP id 2adb3069b0e04-53da5511f3cso3241540e87.3 for ; Sun, 17 Nov 2024 04:56:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731848218; x=1732453018; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=svuhUIea1dsD7kkQf8MYGnky2oc1jwagz62kNPGoCLw=; b=Ua8VaOQseHBSHbnSXyd6h+XwlqqN3PcRG9JEa2AG9pltRTmvCE0vV2gSg2ZvVxhIMD jP9MxI1aEtZWb+yuptEL+/sTzt7fTSA+DIgpWQZ0IZON2qU551+rdJhz2fyLcM9rfz49 hdQUad0pDeR+pHHg90+YwsmwNVIn3JWLDdaP6R6OsT+sQMxirSro4wRfUeyY+16XwBmN lo1pdQcj3KiFRbIHfmsRvGqvBMgGHv+lK0gKOXKxX5lyJWGz2yTADS1NW0rFFKmRaKrv 6HKlf6FcViOWpbIRQVdpVgROwn7T9U3G8rppEWd5gulf5Gu5ESbk41UHNhke2TbopLeC kblg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731848218; x=1732453018; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=svuhUIea1dsD7kkQf8MYGnky2oc1jwagz62kNPGoCLw=; b=TRbbAeVCIH3i4uubB3ZW0c96LgKzKpj1t19D8z6T++rh9mgcKUdpyGKAquVEpGA7jP LY7kLcgyC8z7KJNSuktYEZXPM29moyNVHaBXR4IFZsTM/sEYX+suiKg3T6zkyY2rLXpY NL1Fddw1nGljoplxYbRNPS8kTn0lp+94COzqpBCelMz3drqIZZPIQM8+c8XgxgmXiNk1 +GHqWdFxZzkJo3Spn4wWjXT3WKHfsABFiExwdRYc2n+WKKQVPILY569Ywq6Hni1SSdGa B2NtFUo44Ji3kn3pxf68n26pbmPhpRMhsCZdwnUX3MzaZgSez3cMORz4sJL+15RmrTKN 9IqQ== X-Forwarded-Encrypted: i=1; AJvYcCXTEjZ8sRJ8FgvnkQFmq4/0fwA5wSOo3spGw9vTTFLfEvHSdAU9ftlrIM3JMQds/qjglD11J5f8Tg==@kvack.org X-Gm-Message-State: AOJu0YzzmIPwRJsDFlK01IEadSbZL7l7Rehv67VMdeErohJwKFsYwy/A mtyE/hglPJL6SkyHf4Rq7PQt4nEC0paAeg3ejWdgrQ8q2Iy8k3CfhHzp7uBELAXNrle87pWwltp ue5Yt548H1Vu4p9V9GuuHFNI6Cg== X-Google-Smtp-Source: AGHT+IENauFXnL9odGy7CG8xGMA6YrZ/aFfz4C1dgiE+a47hpCYrcHW8Fwm0iKV9h8iq5Uz0DKavZjK0t/xe+1M7D+A= X-Received: by 2002:a05:6512:2207:b0:53d:a5c8:aaa6 with SMTP id 2adb3069b0e04-53dab29cc11mr3088530e87.13.1731848217285; Sun, 17 Nov 2024 04:56:57 -0800 (PST) MIME-Version: 1.0 References: <03ec75a9-aade-4457-ac21-5649116afa98@suse.cz> <52be272d-009b-477b-9929-564f75208168@suse.cz> In-Reply-To: From: Xiongwei Song Date: Sun, 17 Nov 2024 20:56:46 +0800 Message-ID: Subject: Re: [GIT PULL] slab updates for 6.13 To: Sasha Levin Cc: Vlastimil Babka , brauner@kernel.org, viro@zeniv.linux.org.uk, Linus Torvalds , David Rientjes , Christoph Lameter , Andrew Morton , "linux-mm@kvack.org" , LKML , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 97A8C40004 X-Rspamd-Server: rspam01 X-Stat-Signature: 3xjhyctw8mjhawh3d7o3qfbyxpi6xo4j X-HE-Tag: 1731848170-350901 X-HE-Meta: U2FsdGVkX1/LmPVfbahOOQgjvzTVMHPCMnlptUOlMSetj2mdS+Lnoheo0P8A6kwVdaZk2YcB6iQHYyEIkyhe7rBhu/TdYN9cI9xQFIVxQGkmLrVhNUvXMAuCXh3upmOt6Xg1wwKKNzQ9yNNto6JISt/SzUY73LT/HmrWHm4KKdkVTuNd9XSAXN2m8r08ZNFhhR+7G2YWe9vRjIBgTK4vz5eEwP+HPQXgHVEHhm+u1978hVFvWjFJSSL0WUV4AiCYz2LfkEofdJ6bUZaHuaDKkyHUPKQT4Ln8V565R3HLfkEEsm3MZM/qTo4a0Qmd/qccKsGKf85DtaGnP0IqodzR+biviUGilBRDCSyqARoThTbR/2YFwYpdjyuPeDhrZmCn8s1lGf4twI+QGEwnEiCPj44slNSkjhkZhVuVikTGCZ/aMprQWotUzfrIuP1zr1c32UbXBERSDCV71D8rGNVJ4phOoQ+Bu+L3ZZ+eslR1ThDF2tmm+VExApqBJmXHuMZBi6WvVDFZ732QWgMcF9mcG5MCWNlLWPNUzcsCmjWgAR44Izpfn451N/0RbHL6KQ7YDnnmbiItPDewWrJrRVbBxUnAFSo1ThCPtHXuXSmB4Xzb42hGZus8g1Kf4fUD6SlrPeWEfdF+CCVttpOkPqy5NJ5YhetxfzoSVqFx/WN6sKNBiMeZR7xqDtxmadA5QEujciMG4SBvL+3piq+dcgEQylXaTq5iTQZ8LKdzXgKY6kUUe6bNqMJ+03BCciDtSS8qaul+h2yXxmFjwCEipQWFMpwSwclI4zuR7zt8U1ZGJO2d5PA0omMdXJjtLLM5GrfZ+vmf/CuOzQiqmqcGgnoJxRKDb60+Ra1ZBvIkmT5iLVxnyvi2XK2Q117L/OHUg+N1VkTSho9gdw0Z/TIY45nx9do5UcQTsLGc4qBHkiVDu0kdCS2BpUadaZ3op4ZDDv/UO4lYqC4APAdI/3sUrOI wnJzZOEg CMpAYy/HYDSf9Asx1KzbzMlkRhTOjaG5ZUyPyh0jAeqVw7DFiaJGAs+XFJ2abgXo83Dx+I8AMbQ6P6heubQdGeQb+HxpZ1QYvCcIPMpWqMfQYQegpqidDHzSs0mmepdUZiXb7p/PAv7GFtw086t6VaUbMRtcnwYG2ff8TTv/A8z1lTQGcQZMZ2GeX+4aXNusWtdB4FEv9/kWMmb5J0MKu/8+SrYEvng8RvhEndmkyNvUTnTd6QnVG7+4brVEdXEWQHYFH0+H0YqW/7xnE2IAChScDhoLyivvKKcfaiN6KB8MYMYgFPgt2Hil9hwiXxg4QHQtKbyAjKAzL7Yv53RdgeSqqBTIwS9io1XS2z9HQxRNKMJ2xM2T0oqjIXXVKhg5b4QzgyDH0pMTV/bUWnD98Yn5G3spUJeuqFTxTLKujx07oyDXfCq42jlwLcoOmnBFECwM4uOpAt9hDmXflo6GnBXqPPazSbHBBcHAAtK3ox73CJGMkBhaDVH7cpVJmJdi79wn3chGwUKFnSwzvhTynHqJRLI44FRGqlpBSn6m0x4AwcdiQuxApwwV2TSkQ6V7D5q6k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It seems there is a conflict between fc0eac57d08c ("slab: pull kmem_cache_o= pen() into do_kmem_cache_create()") and 543c5bde72e9 ("mm/slab: Allow cache creat= ion to proceed even if sysfs registration fails"). The err is initialized to -EINVAL in the entry of do_kmem_cache_create(), sysfs_slab_add() call can assign a value to err normally, but the assignment to err variable has been removed in Hyeonggon's patch, so do_kmem_cache_create() returns -EINVAL normally. We probably can = do the following fix: diff --git a/mm/slub.c b/mm/slub.c index 73eea67a306b..19630a2da8e1 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -6199,9 +6199,11 @@ int do_kmem_cache_create(struct kmem_cache *s, const char *name, if (!alloc_kmem_cache_cpus(s)) goto out; + /* The error code is not needed any more. */ + err =3D 0; + /* Mutex is not taken during early boot */ if (slab_state <=3D UP) { - err =3D 0; goto out; } Regards, Xiongwei On Sun, Nov 17, 2024 at 11:42=E2=80=AFAM Sasha Levin wr= ote: > > On Sat, Nov 16, 2024 at 09:43:07PM +0100, Vlastimil Babka wrote: > >On 11/16/24 16:35, Sasha Levin wrote: > >> [ Obviously I fat-fingered it and didn't add Christian or Al ] > > > >I have found the problem and looks like I managed to force push an older > >broken version of a branch, possibly due to switching between two comput= ers. > >Serves me well for amending in some last minute R-b tags. Doing git diff > >@{u} to check for unexpected suprirses before pushing the result didn't = help > >this time, either I forgot or was blind. > > > >I have deleted the slab-for-6.13 signed tag and pushed the fixed branch = only > >to -next. Thanks a lot Sasha for catching this early and please drop the > >merge from the for-linus tree. > > I've dropped the merge and tests are passing now, thanks! > > -- > Thanks, > Sasha >