From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D088C48260 for ; Tue, 13 Feb 2024 17:02:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A463B6B0088; Tue, 13 Feb 2024 12:02:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CE146B0089; Tue, 13 Feb 2024 12:02:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 847286B008A; Tue, 13 Feb 2024 12:02:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 71ED66B0088 for ; Tue, 13 Feb 2024 12:02:08 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 47E311C0EAA for ; Tue, 13 Feb 2024 17:02:08 +0000 (UTC) X-FDA: 81787398336.11.4F38A09 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf21.hostedemail.com (Postfix) with ESMTP id 436AA1C0028 for ; Tue, 13 Feb 2024 17:02:03 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XclgUZpP; spf=pass (imf21.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707843724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kFEBmVzCDcc62ul2nmKiFx/x08WUXookmiLkT3RdZO0=; b=YId9bWWMi89gxVE4XXVQUIvE+H14RfRC4EaF+7t4VVhUm3yncTtF8S6JyHzT/7TWaMTZlh /1+KUYA8nQVYIyrloRyZgewkiFwZZa6ITaopTvdD8cxC/f8P9DTI99poScdEuxGJoaYEz6 dTx/Vc8KkrGs2TB+lRSCo/4o7pLErAA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707843724; a=rsa-sha256; cv=none; b=o9alpm1wJzjrhQGSP5FBKiZO3ysGjAo7Em+wVBuYeQLcZ3eQVCtKzlhSLJoJR5p9eL3K5f giOVpT3koNWBWRhAnmJuoS1KvFYQ1Urwct3sj0nMjEdf3zzB6pdfWjIzLqrRmFmxdAXPDq F/ODDm64KmetnDbpsSJy+J/tgAIR7Lk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XclgUZpP; spf=pass (imf21.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d93b982761so198705ad.0 for ; Tue, 13 Feb 2024 09:02:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707843722; x=1708448522; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kFEBmVzCDcc62ul2nmKiFx/x08WUXookmiLkT3RdZO0=; b=XclgUZpP2XMviY5lxnYs3iNdmppNDcInEe47RVi41VL13GLA0LjaQnULuWWj70G4kt cedKzypW81cMDv88TZyWjD9V5WALxNnbFybls6zgsmJoaPjUr87VeG6Q8QeTh+pr2LGi 173JFSIlaN8tjgjNPpIx9obXl71xw0csScr3IngnOuMIn13YR04JBgJCXOvwXbbZjEYj rDmUaonRZ1wdce6UXKyD6PNCyrO1aqHxztb9eq80w1h44Mn2AmoCWLin4xLl4ZdywaR2 miQjzKbIeNEKdgkq6cw6zoo1f+E0nehuRsLW/Us9zAlcPX68ixorsVNJdFvd8yKlYjXD wdHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707843722; x=1708448522; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kFEBmVzCDcc62ul2nmKiFx/x08WUXookmiLkT3RdZO0=; b=vQmISYZlmx0rJ26LpzskEfcP8+HTbhGh1QM/daoy/IShd9JZEUA+KFHQ/9ymkNeBct nue1lmUldkYR4fqlyFpeiP8cdoVwR6pUjKOrQBoGJtsi5SbOLa8JxjYPM7fUyx9M2VNk nlDzJB4P4bXX/gXjzx3Ojvmv88vbp0xwfvlza0YKWJzFz60BCjGBhuJK304Feo7BNT2a AhtfhlcpvObPrnqLyv17xdGwz/UT15xdxDyJLj4bj3kfHLtFjQdAKJg5u7Ya2dHRBOj/ xqBjTVYXa9sg7dRyH9UM9vhDiRTle4Mch5dhfTvP0CRkR/1BeMDw2siQANd+VaFvVnEI 6RtQ== X-Forwarded-Encrypted: i=1; AJvYcCVThQuVTdj1jwDD7/M66wSYg1+zuK3K+K9v98aVr2BcxOflubRnd/LiMymG2R1WhAHpwhn77cjR5OJTPohytJF8T10= X-Gm-Message-State: AOJu0YzL7A8xBNh9uAZAVb9HA5kenfqXm57y25dt/d9d8EI6I3JoId/n ctqf3gmhIfwIugusdC4vkK/YeQZxzlo2/A7NXq6FfwmHGGm2b9tFQ1W5nDpU4/jFK9nh+0ExjFj r/ZbiPlbaaVkJkMLt9QOjdU1Tznmt5aj2rZkO X-Google-Smtp-Source: AGHT+IFgCqv/XRtoQtQ4/r0rGFzG9aCmFONaMnDDOPnOxPjhaUUFtNH2qle/Tw8GsuonJ5SI6Oo7o2+2OwCK/Zu/4Dc= X-Received: by 2002:a17:903:33c7:b0:1d8:d90d:c9ae with SMTP id kc7-20020a17090333c700b001d8d90dc9aemr20118plb.1.1707843722210; Tue, 13 Feb 2024 09:02:02 -0800 (PST) MIME-Version: 1.0 References: <20240213081634.3652326-1-hannes@cmpxchg.org> In-Reply-To: <20240213081634.3652326-1-hannes@cmpxchg.org> From: Shakeel Butt Date: Tue, 13 Feb 2024 09:01:48 -0800 Message-ID: Subject: Re: [PATCH] mm: memcontrol: clarify swapaccount=0 deprecation warning To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Jonas_Sch=C3=A4fer?= , Narcis Garcia , Yosry Ahmed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 436AA1C0028 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: eysryahswbs45q1eusaxkdxn7fza88ht X-HE-Tag: 1707843723-186855 X-HE-Meta: U2FsdGVkX1/6gl+HrfZze3xdU1RPJ3g1fYLEOK1EeVnn4KCzP84dgQHdriAYvf6AaIOjEd0Pkj4NwSMMRmASyDi8V5D8Z+3I5Ybmq3EdRiFFMLiVGv+kVVtGS2rZYGNJVufuYthD5RQZz6z+BsxNTSS+5X56uev1J+wIrUbHjoai/1wZxNgSzdNZ+ZH2FFhJKNJatzC+Tyw0JRT4yYkwpMpCvq9P1LyU7suLPcjic3N9F17L44XVYrFkCdIfc62qz+2+vAbrvXsGW2Qd0DfcSrVb6oef2CfoKJSydRyRB8+QjqfDAHU/EvBP/QHzu6QiqSBLJnj6qnhyWIcb5S9L5aIiHysqyvU/tuUd4in6VG0xbHrpEdv8GZ8UAsvr/gJXpzt0ZCApE6BmTaaw/X1lmPWjzgnNoJdU8JtkjjiDTdCkcdZ4E2xXvfhd7utfemZT9k90iukkXQ/ZAcRl9065BuiYQtyW0vwnJtVLm9l+GBnqp48+zP0LyxDSUbgmVF9RHXJ5gxhJ553rRMGzXIQ5GuemiJF11wue3Op0cZfSGDYeSwYTHdT3589pUQ7uwnestsfllKXqb7paypt2ve1f1BULspxOZ6RFc8/g8UXyZvwLWk6WMLBcOq832vfFj0bGBX3mxtB4qbgLSs6UEedlJq7AnE3HpbQcf7atQ6JFzTc27Xulx3jmRqr00L7+gDnPO5pR9uIcRM5GKZhjjgq4e/TE8tGaHtpWXnIoqAZqsXKqW+1VHChmQ0BOmfO1hwIMfLGhbNl/CELsOO+rkQWuJ6XAm6BkQAqzlSwJgU1JUxWME2o5o3x7cS3bpDPqoURaBn+hVC75sszZxYTQnG3Y+Vj61Oi/oV4g/SguXzSkd9SxwQX5pfx4/8hm8hpZ99LcBVBDWSZSF0//9EkVvnRoJfQxNcDmo8pnUDfD5GYSGrHSBCE43UGeFDmLFpIe/nAmkWDlcnDL0OqD3Ynce14 9ZMF+sYC dAR+l3Z4gEwyhChqj1Kccz2fM8CRnFCCRJPu63jniLst2H7B6p66fIXNN1h80wDmfd7/lPl0DewnNQYKskZPmjHORQiUGfTKuOlAvlBcpVpto6vZ+HhiUEUbdjQvpuGOL76MSGeMT6vyLHdG4/ADWQtWlFrJUuJr4FJz5F1fvg1UtlLS1mtralUyLf5Q2z3l1jwOcOf+aiaNZT016o0pBD9f7j21Y/CV92N+KeMlA1WEFGBggAyviyfbuH2EkF39Z55jREGhTvVRcjSQf26/qwHW9B2qLm0hSqPV78A2fRxY5GG83i0AnkduLXaDwytatOFvO6So/GxkZtK+6k0Afvvjl/V9qYGgB6rTfqNurk/KFOwsp9L9CKIL1hZn93cPYapK9jLQ9cXt+gOKwouAxt78FylVcUTUAViNQZc4mNYPDtB7hSbMRQ8YpQX6K4d29DL4a7tB6Oh5DQkTIXq6ZjHDkWo9Ux2av92dc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 12:16=E2=80=AFAM Johannes Weiner wrote: > > The swapaccount deprecation warning is throwing false positives. Since > we deprecated the knob and defaulted to enabling, the only reports > we've been getting are from folks that set swapaccount=3D1. While this > is a nice affirmation that always-enabling was the right choice, we > certainly don't want to warn when users request the supported mode. > > Only warn when disabling is requested, and clarify the warning. > > Fixes: b25806dcd3d5 ("mm: memcontrol: deprecate swapaccounting=3D0 mode") > Cc: stable@vger.kernel.org > Reported-by: "Jonas Sch=C3=A4fer" > Reported-by: Narcis Garcia > Suggested-by: Yosry Ahmed > Signed-off-by: Johannes Weiner Acked-by: Shakeel Butt