From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36BC6C64ED6 for ; Mon, 27 Feb 2023 16:50:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71E536B0071; Mon, 27 Feb 2023 11:50:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CE3C6B0072; Mon, 27 Feb 2023 11:50:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 595BE6B0073; Mon, 27 Feb 2023 11:50:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 483D86B0071 for ; Mon, 27 Feb 2023 11:50:21 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1BAF8400FE for ; Mon, 27 Feb 2023 16:50:21 +0000 (UTC) X-FDA: 80513659842.07.46128D9 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf17.hostedemail.com (Postfix) with ESMTP id 405B240002 for ; Mon, 27 Feb 2023 16:50:19 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jMbv2r0S; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of shakeelb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677516619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yZeTsz2LgmEqTFu2D1y6H+6n8BeVxT4dDCxIvwbJYZY=; b=vnj+ORUlrdpp3Knu7InqqtcjA1R85ElEoqqNPOrCjz5fd0aaRSK9TQ2CeUKSpJ0iFcT+Fo S9Z64mbILJ/YGtuqVIYjgdOqdA+Tp5ZXc2EW9T2822Rrh2nXShF+HCEkZfbEd+bumAPq1x 7HSCp7E3PZw5V4GxEy6yehVe2rXj2BY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jMbv2r0S; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of shakeelb@google.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677516619; a=rsa-sha256; cv=none; b=Yyd5NXxYsflC2nCebVCQnvaCprM6ObUJDMbYXftHm9CfCDR/p523p3CHUlrqJiniId+UwP bAS9zgA1S87kbJjx3wm3i1znFsMr2MmYCXNDuCeiLoDvr2WHWztTc8LzMAxWqYuNW+VUtp BORBmQknJuXXLR1d8s5eqYZUlAYeMPM= Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-5384ff97993so193656417b3.2 for ; Mon, 27 Feb 2023 08:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yZeTsz2LgmEqTFu2D1y6H+6n8BeVxT4dDCxIvwbJYZY=; b=jMbv2r0SjzyLfd/109qTg+Zt8ATsSAGsZlaSIpfCNwq5MIkuMOmLkPrv5s0SX2Niqc MW13m5uCGpMy+WActWyp/aBFjIsABYD7rOJZxYz+L8ev/at3VpEsOl1aSGD/fg9fAxua eJ06FHs9y2Gd2u2RJdup1zDKoxef+VlmA1id7W+V1aNeMurRTMCoKUeuxbOl/2FJMH+K 69ocsLyGP1GZMP839JOIlS0Gn2tFsDBARF/ntfFuAjaNjJAF8gfgd+ru+qMGlRREUcd8 PoQCRdH5cvAnSFFw/+0AoDeKZqRUsNif+iN7CSIiwJgxom+C+kB7bPml9a7g3HDM5xhG H+dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yZeTsz2LgmEqTFu2D1y6H+6n8BeVxT4dDCxIvwbJYZY=; b=POHBqersfw7KuN4rWffREdyj4pMzVGaoIp/GGojDrInwhYpcjow/3Nq57y+1VyGyya zsQ90wHAZUTKCMhypM4s5NNDnjRGtobbrsuPM2WxfzCBAI8WAyL+WP6YH0SC8tIpIv+F xLwvZJ1+hKjX7EgbKNrNZ8a4WsYB/9FG4pqnMNKqKMYMClTHdDD24aJl/u13pj11f4wO K5hON+GgCqDcJPgFsYWAU3caHeijBOHFfdqgQ7086OHafn01f56xIqL5w1mu4k32H4eZ aIXu4pGPnBZ2zqcTWn4WYWdwir41+BRnJQr3lPWsHp0KlFxElTqw020qV1dB+IRAVAut 5Qyw== X-Gm-Message-State: AO0yUKUi+y3l0QjRcQ1lyWVFWOx4e4cPwBKc2+UvD3bBZVqeqPEWUoEX 3N9yXeEoccL/KPzFfaiS3PcgE8jvjV+XFaq0I6j87w== X-Google-Smtp-Source: AK7set8lTXaiez4ACEuOb2wNkB4Dm/JTTL0C1kWWQrm108DPBrKq3P5Ta7PTFE2EKJWgLgv4skNklgr9Jbg7qnJNPeI= X-Received: by 2002:a81:ae52:0:b0:536:155a:b73d with SMTP id g18-20020a81ae52000000b00536155ab73dmr10845609ywk.2.1677516618212; Mon, 27 Feb 2023 08:50:18 -0800 (PST) MIME-Version: 1.0 References: <202301301057.e55dad5b-oliver.sang@intel.com> <20230131052352.5qnqegzwmt7akk7t@google.com> <20230131055743.tsilxx5vfl6gx4dj@google.com> In-Reply-To: From: Shakeel Butt Date: Mon, 27 Feb 2023 08:50:07 -0800 Message-ID: Subject: Re: [linus:master] [mm] f1a7941243: unixbench.score -19.2% regression To: "Yin, Fengwei" Cc: "willy@infradead.org" , "tj@kernel.org" , "dennis@kernel.org" , "akpm@linux-foundation.org" , lkp , "zhengjun.xing@linux.intel.com" , "Huang, Ying" , "linux-mm@kvack.org" , "Tang, Feng" , "linux-kernel@vger.kernel.org" , "m.szyprowski@samsung.com" , "Sang, Oliver" , "linux-trace-kernel@vger.kernel.org" , "oe-lkp@lists.linux.dev" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 405B240002 X-Stat-Signature: 3s1ufucuwfghgirohbjny3o6urt5ottg X-HE-Tag: 1677516618-424487 X-HE-Meta: U2FsdGVkX1/H53nLG8w9itp33KgwBoC7HiyOcG2aoIwvyMFHORKRCVnmrhxp5DAcDES29iNkBTCZRO5koL/zY5eTh4ftiQXWoDXq4uOTuEjIbA388jjas6dp6K+AOswd8/tT2BwfvcEQLiP3eufOXLXB6C6mXz0CSFGRRcOvourhUEreK1vi/cJqLA3B1swWtSvDqmfO7w6SqtGQIl3B4kLI71+ekLjDG+kGEopwuOB8gFqXRANuMj+6HfszWkWJKoZeEaAG6esi3DikTBrNncxer9kgskIUX2NAClB8fm1FQl/fF+rb/hQEg5T3BSoOFAVX3Nwf464H9bOt8Q/kNKSFSfbZaC2sTsEx1tefco5rGwN7d91L3ma2wR/bKEowUzjkKX9pV9tflm+c97BVm7LV4nzv1ouCYO+8qB3ECTegXRw1FDIRWG7c/vVZyX8SvrBWwf8rGTyvVfRMYWpFt7a1Y0rcjcbTlyEIb1yXircTg9K8iG4IFFZtAFqSFOuWZ9PKK4eOS6e4JOPBa/Qf/j7MqewF+GPAqmy8/c3fGHKAndIul7ntnVIMmNZcFKkkinZ2lJQGkmS2yLM4obzF54jsAuUKWtumy1evMHVDvHH9icBs89gmH3/nZj+72dP3rPtv9O1wtsSeZJU5uYYsjb4iwW0ih6uGzyxKMTyULNcHPlxYknfj8mncl1kOPAPqzwqdEQp92olIjJjN3dpgNrpRTBX/wCVZPvRAUvY3xfsaNEdqQSw51bU27Fq5rjZb/BPIL0j72UceoSKYq7fvoRV7wGCshehgkFNx+oHwS+GqhEIZ+6zpoiTBssKl1As9e0Ft9OOOt2wkSYumDqQyaFqkrjF7cFhCCEUSsSpMa4tvJ+zl6/M6pCh8zJcms/lUfp2J8LSp/cVguVc+3K5VGQBZAU+r6MZPd2ffV6jIE98ZcJ+vjRWmto/gOg4yxGqep+m7eqVbSEj6i/y+wZk 5lRbSOsc rdLC+6rub2kflVaul3GG1LRMJtcH2gnejRPEwYuRS1IG27FQU4dEFi8+bYwzUbp/BvOx4g/BVpqwJwGXka4wYFvCnpx2liQsgzyfM1MQBwPpMW9tjb1Yrsiay9vxdbOBTo8Na12BAX+jqt5+EMG05+8lGPNWftkD41p5x9kifFHSXCcr8OwPxffa0cYPU1OcZc5QofXLxDXtjPj2eWWypEFDlbVKJK3KJxCOUosYZwaQfcyjastMRk0rDtB91ikvMNcWf7aDNjCR+OlC3ucoomaa+eFJ5xa547PMPrvcWVaiUkANjX0MjE6BJHHdr4zFnfyIhMLZ30VdfaoDsHhaxEvU7ocMpECJogGYrNP5pqK1m8zR3NCwPXlKvE6td6Us5mRVsmt5yE8MKDJW+GmF+mQw08ZxfDsJJFJqe8WXwunHADq3ArA2OKF9Uoqfo/U8pjT+E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000244, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 26, 2023 at 10:35=E2=80=AFPM Yin, Fengwei wrote: > > Hi Andrew, Shakeel, > > On Tue, 2023-01-31 at 10:26 -0800, Shakeel Butt wrote: > > +per-cpu memory maintainers for FYI. > > > > Thread started at > > https://lore.kernel.org/linux-mm/202301301057.e55dad5b-oliver.sang@inte= l.com/ > > > > On Mon, Jan 30, 2023 at 9:57 PM Shakeel Butt > > wrote: > > > > > [...] > > > > > > > > We could cut down the number of calls to pcpu_alloc() by a factor > > > > of 4 > > > > by having a pcpu_alloc_bulk() that would allocate all four RSS > > > > counters > > > > at once. > > > > > > > > Just throwing out ideas ... > > > > > > Thanks, I will take a stab at pcpu_alloc_bulk() and will share the > > > result tomorrow. > > > > > > > OK, not a one day effort. > > > > Andrew, which option do you prefer? > > > > 1. Keep the patches as the test workload (fork ping pong) is not a > > representative of real world workload and work on improving > > pcpu_alloc() for 6.4+. > > > > 2. Revert the patches for now, improve pcpu_alloc() and re-introduce > > the patches once we confirm that fork-ping-pong is not regressed > > anymore. > This performance regression still can be reproduced on latest master > branch. So we took option1 here. Right? Thanks. > Yes unless some real workload reports regression. Shakeel