From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D10DC761AF for ; Tue, 28 Mar 2023 15:19:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 909B76B0072; Tue, 28 Mar 2023 11:19:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B8526B0074; Tue, 28 Mar 2023 11:19:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77FDF6B0075; Tue, 28 Mar 2023 11:19:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6AB096B0072 for ; Tue, 28 Mar 2023 11:19:47 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 453A0A02DA for ; Tue, 28 Mar 2023 15:19:47 +0000 (UTC) X-FDA: 80618666814.08.8D587B7 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by imf20.hostedemail.com (Postfix) with ESMTP id 7206D1C000F for ; Tue, 28 Mar 2023 15:19:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Ar4Zra7a; spf=pass (imf20.hostedemail.com: domain of shakeelb@google.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680016785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZcS8n/4+59b+VXd6eXMn877oxhRuuiSj8mRyLdeW/tM=; b=qg8PHLxpaf2fXuyaWfqru4K4mNjaXHvcksaNI+V3hrgKfuLkfSpz9IFqoho+YRmQwMeys/ HkxJawrOBeT1HdGcIU4n8hl0nSoM0P8dsYdzavV3HS77uiuyQDtsoaLXjeu81btKkvCqcZ 38nlldOliulHRBPAYhaT2QV1/ucZIOY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Ar4Zra7a; spf=pass (imf20.hostedemail.com: domain of shakeelb@google.com designates 209.85.128.178 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680016785; a=rsa-sha256; cv=none; b=3TRofXZOo7iE+zafWSUFp5iWXBua1brj7RGATfL2n9pl8Y1vplgpRUurp79IS9XGyqMRLL SzcYANcZ8IAFyD/VsvNgR1fEu+5ajSrJu3JaAo0DJjBqy6wqPuE6K+CmSPvBd0AKWx42/L 10EwjJ8FoaudCuQbQ523fUgz8Ts69k8= Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-54184571389so236234117b3.4 for ; Tue, 28 Mar 2023 08:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680016784; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZcS8n/4+59b+VXd6eXMn877oxhRuuiSj8mRyLdeW/tM=; b=Ar4Zra7am34XuPMhOvIUcA5xD0kVon3c99ACx4qVdYKc7PvMpeZbPc7LV4yiktxx93 ugQcjwZKj3vROoqeRauJSOBpb/R7U0idQKpJU7syI6uOUqxt1iBIF8l4r9F7EviaUoDi 5eGZKwhRwKRZxVY+kApK4O0HT7InuJX8mw3M0HfrCXDYjBj5bNd8FOTKy3yI06ZWgwjO HPR0Gz42df+GFqUpBoW8UGumfJGgpC4TxJYcxJ2J6DfmavIUYu4J0xle/MsU2yYWX7OR ESI5YObo7wWB9KiZs8NeKzMtj5Q2PHwXIhtBG2Qb1iBMLwwQvMGYO3D8HHRZ3Q70iOfB d1KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680016784; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZcS8n/4+59b+VXd6eXMn877oxhRuuiSj8mRyLdeW/tM=; b=VdzlHfME44M7Rb0Zt1ukif2mU+SgUftXJyyxU/HfkwhuAxpyRaSvylhyxCUK7g65lr iuDOUDPqi6Ya6TfGQBS+hvN8MTQ+wph9/G/Y4gkzKxXlckdAkJB50X/dtYpzc3gH/jPi yxxP/Xpqt8y1+eXFIWfr7VdejVL40Rq3XtN8E3q5Xf0Ak4dnBdj52w9bPyRwVaVGF8qb QKklAiN5m/Byj3EB/gj5FZmLnthhfPOu5vMNzN5FfEk+yWHjnzWF2AgbBxblmORLdJuo tX1pekW5dqJkObNjWf4939kEQldh46CfuYZIAsmLDbHbo+cacwvSmg9nrZbpNFAbw3mP VSpg== X-Gm-Message-State: AAQBX9dpWpDh9MAOoghm9Y1ZyMZZR0QqqZnWH0Aia14P9EIiiWf/6XRY j8Y2wkDBY47YJwsM2yWdtEOabFrDVS11ny1J9fbg3Q== X-Google-Smtp-Source: AKy350Z9cmGM4H/7sFJEBekvmzlUQ1sUU694LWzJhS2SSks5o5zMh8yAhNT3YmusP5qBVLKJW5eonGGOovifhFPxfcU= X-Received: by 2002:a81:4406:0:b0:546:63a:6e23 with SMTP id r6-20020a814406000000b00546063a6e23mr2281889ywa.0.1680016784433; Tue, 28 Mar 2023 08:19:44 -0700 (PDT) MIME-Version: 1.0 References: <20230328061638.203420-1-yosryahmed@google.com> <20230328061638.203420-9-yosryahmed@google.com> In-Reply-To: <20230328061638.203420-9-yosryahmed@google.com> From: Shakeel Butt Date: Tue, 28 Mar 2023 08:19:33 -0700 Message-ID: Subject: Re: [PATCH v1 8/9] vmscan: memcg: sleep when flushing stats during reclaim To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7206D1C000F X-Stat-Signature: 4xqtffthe3s1urtsbhhuhmfxdmiy8bc4 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680016785-173436 X-HE-Meta: U2FsdGVkX18713aziNdfeLXoI+i3XIyP1tc/NbO1Dd4/VKA7+4Im14ggLYlXh0sMSkUYVFwWeOfRiyTXIwxzW6V6plceWfi7TTDVcIoKztfY96Sbv6oh6O0qPiIIy+zoiN8XNErHv77O/HjTGQDIq18ijzn3HmUeNmO7lpn15E5fp7ko5oPQMZeM68+CT3mUNPSVmllgArU9euADqXdGnQkUHRiYpq4P4YjUXWbSKmfsjJNxeIHaYtHzQ6N/I687O2wngqzHClKooHmMjDju8r2yhvDsqxhCHgSK85zShQ21coQvTCM1nsDJgclxXN2USKaWIWzT0QNGcwz5r0sa0UCRnf7mVlEkm3bCVn68eYCoOfPo+d3F2gcoDKMvgS0T60BheOvpXQF8h/ZG6WK9ENGTRYdbUjUrzBK+SjIYxNpZbhPckHhsTQwjL0bby6U+yCd4OGwwU+Y5VkI1g2M+f+4dRNtP5Fc30Us1lQ9j7yFmAF/bQ7i00RNLIAT4xX+isVEeB1Yrsqb1L0w48WTaGpAlRhilvkKJsV2EFg3bVY4wYYbrn9z+Gp99s84WvMD7FeQEOT0bQDHYySz/fuzCIKALx7SomUO4n5onAljvAVDbkQg7kfKseDjBIkBg71pB94JjVp+Ie2DFyp9hlshFf68H7CQbdqllFvQfa8EQyJZQfsqhPtRR6jmELj31PrIki6olLKJid+MedF8w0HxVer/6Xic9LhcLe++IeqXAhAvzTHxSgK8t4uzxHdojqdDumhpFYX6asG9/WZg2vJ1Xbc/sOfLJSeRh8kLm3IPW9jb46kWbWV7TNItdfPitnbNJxZL++Ao5yEfM3c/51Qsp0WLV2d7AW+JK0zsaNNV5rMyvB0DehCLSGxxPpSD92nhWnhHhBFfSk/fsAk3GcqsUIaTYUK+S2MlB/88kdhpmtx2r9JAniP+Grml7cRFH+mtQhbwn1rWnfiR+VTxmFVA ZjF7+rwO gY+ZIIumpTjJRrTnD/zB06ck/V5Q+dvZhXCxDrcPq27W/XfmP+2L49zMZIn8b3oEWPYM3QPGDUIOuXRtpFR4yY68ywLXThO8IzpL6f6Cygz1dpEI7uUdM1YhXo2ayAY+am2erNE1dVPdk1h1oBeoODA4+cYGPJFDbrUTUpLaBfSbRCW0x1QXW5ZijO/Ep/aww16tK5IkjUCs9PnfXAGJb5c5qtJy4hXRfwr9aVM0Hu6p3Ig5hGnGFc2YnHCHv2SRbk+0hTM2nXHHx0Sc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 27, 2023 at 11:16=E2=80=AFPM Yosry Ahmed wrote: > > Memory reclaim is a sleepable context. Allow sleeping when flushing > memcg stats to avoid unnecessarily performing a lot of work without > sleeping. This can slow down reclaim code if flushing stats is taking > too long, but there is already multiple cond_resched()'s in reclaim > code. > > Signed-off-by: Yosry Ahmed Acked-by: Shakeel Butt > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index a9511ccb936f..9c1c5e8b24b8 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2845,7 +2845,7 @@ static void prepare_scan_count(pg_data_t *pgdat, st= ruct scan_control *sc) > * Flush the memory cgroup stats, so that we read accurate per-me= mcg > * lruvec stats for heuristics. > */ > - mem_cgroup_flush_stats_atomic(); > + mem_cgroup_flush_stats(); I wonder if we should just replace this with mem_cgroup_flush_stats_ratelimited().