From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22D5AC433E0 for ; Sat, 11 Jul 2020 03:25:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ABE772075D for ; Sat, 11 Jul 2020 03:25:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UI+5RvQl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABE772075D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 380B78D0002; Fri, 10 Jul 2020 23:25:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 330CE8D0001; Fri, 10 Jul 2020 23:25:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21F618D0002; Fri, 10 Jul 2020 23:25:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0126.hostedemail.com [216.40.44.126]) by kanga.kvack.org (Postfix) with ESMTP id 0BB718D0001 for ; Fri, 10 Jul 2020 23:25:02 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A20888248047 for ; Sat, 11 Jul 2020 03:25:01 +0000 (UTC) X-FDA: 77024353602.20.debt49_261240826ed3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 68F57180C07A3 for ; Sat, 11 Jul 2020 03:25:01 +0000 (UTC) X-HE-Tag: debt49_261240826ed3 X-Filterd-Recvd-Size: 3811 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jul 2020 03:25:00 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id m26so4248238lfo.13 for ; Fri, 10 Jul 2020 20:25:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8CSoNKqf2/F0Tp9hw/Q3tOqmnKdqJohhTGwykA5078E=; b=UI+5RvQlJ7Y4QrAO5eQmJs5SxFTK/evUap+folss4m3gXvNyiErzjs9cgqLbt1+WBw jFy/83zKBi7lPpxgS651R89gffrCvA3YIJYDUiy4T5l8u91TUmrWw6Du5owAiBX1V5nF M+QeZqFW4xn2glgMfN9eg/zIoq7cq38ThTMTnNkpNmICH6KQEiiO5aRdFkfY2mkwgceQ oHiWi8S0q3tMRPAZmvpcTtzIWvwGh09/4B29R7CSsNMu4rWnN8kjhfojUi3aVnBfwBkX qqTGf+nMWjW4wtY3Xq1+aAGAQNQ6Rqs0JZeaWIEWgI59Mf+0Kpinv/MU76AihdXgclva F1hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8CSoNKqf2/F0Tp9hw/Q3tOqmnKdqJohhTGwykA5078E=; b=K3OIc//UoV725MY3lamd2HAOrS4dYf+amsSQ5h+dSMoNBdaCGpi4IAgvNrl4owH8aP HcLLtk6wnsssGS+oZjhh0dnZvkRbNrCM54rDXSqLddFDxDERQVoMtmrDPA3o815E+Fj6 iwQJnBLSCeWxZLFxxYWZkJfEUEnF3XaEWwZ1uHeJf2t4UFCyMvLeKKcTxZeS6gPd2tCI 24ZzWEY4XfkjXSPicEt2ryiLQGLYxWUM/qZZK9cm9roqxcIUohnfVtywTmIyJOrNl1Wk Zionll+ko+u0AMDLN7BHOfaBlosDppadR8ULkDTs+6jzGZikNiS6KCPvBy46lSkAfFW4 Jfxg== X-Gm-Message-State: AOAM533zwVAYaEiYb49ukXBXvBpbSouArzKzI09ddPWsIcM2ciVqRyA6 CeKdB3p6lk+z0rM0aySsgR64IrssEiakyG6XGdiFtQ== X-Google-Smtp-Source: ABdhPJy0KtX0wD02BqHvdV4WP9jlGiyLFJKoXzUPvHEy9ODhEGagwn6D7dnj57cxdy/l3dIUlSkjrETKVulpVw/1HWQ= X-Received: by 2002:a05:6512:482:: with SMTP id v2mr44598950lfq.3.1594437899004; Fri, 10 Jul 2020 20:24:59 -0700 (PDT) MIME-Version: 1.0 References: <20200711011459.1159929-1-shakeelb@google.com> <20200711023151.GA388137@carbon.lan> In-Reply-To: <20200711023151.GA388137@carbon.lan> From: Shakeel Butt Date: Fri, 10 Jul 2020 20:24:47 -0700 Message-ID: Subject: Re: [PATCH] mm: vmscan: consistent update to pgrefill To: Roman Gushchin Cc: Johannes Weiner , Michal Hocko , Yafang Shao , Chris Down , Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 68F57180C07A3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.172194, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 10, 2020 at 7:32 PM Roman Gushchin wrote: > > On Fri, Jul 10, 2020 at 06:14:59PM -0700, Shakeel Butt wrote: > > The vmstat pgrefill is useful together with pgscan and pgsteal stats to > > measure the reclaim efficiency. However vmstat's pgrefill is not updated > > consistently at system level. It gets updated for both global and memcg > > reclaim however pgscan and pgsteal are updated for only global reclaim. > > So, update pgrefill only for global reclaim. If someone is interested in > > the stats representing both system level as well as memcg level reclaim, > > then consult the root memcg's memory.stat instead of /proc/vmstat. > > > > Signed-off-by: Shakeel Butt > > So you went into the opposite direction from the "previous version" > ( https://lkml.org/lkml/2020/5/7/1464 ) ? > Yes because we already had those stats in the root memcg and exposing root memcg's memory.stat resolved the issue. > Acked-by: Roman Gushchin Thanks a lot.