From: Shakeel Butt <shakeelb@google.com>
To: Henry Burns <henryburns@google.com>
Cc: Vitaly Wool <vitalywool@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vitaly Vul <vitaly.vul@sony.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Xidong Wang <wangxidong_97@163.com>,
Jonathan Adams <jwadams@google.com>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v3] mm/z3fold.c: Lock z3fold page before __SetPageMovable()
Date: Tue, 2 Jul 2019 17:59:03 -0700 [thread overview]
Message-ID: <CALvZod7udORRrz7wzQPRa2Eya5TfrVh9kG037GKsAsSkRJPx7Q@mail.gmail.com> (raw)
In-Reply-To: <20190702233538.52793-1-henryburns@google.com>
On Tue, Jul 2, 2019 at 4:35 PM Henry Burns <henryburns@google.com> wrote:
>
> Following zsmalloc.c's example we call trylock_page() and unlock_page().
> Also make z3fold_page_migrate() assert that newpage is passed in locked,
> as per the documentation.
>
> Link: http://lkml.kernel.org/r/20190702005122.41036-1-henryburns@google.com
> Signed-off-by: Henry Burns <henryburns@google.com>
> Suggested-by: Vitaly Wool <vitalywool@gmail.com>
> Acked-by: Vitaly Wool <vitalywool@gmail.com>
> Acked-by: David Rientjes <rientjes@google.com>
> Cc: Shakeel Butt <shakeelb@google.com>
> Cc: Vitaly Vul <vitaly.vul@sony.com>
> Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
> Cc: Xidong Wang <wangxidong_97@163.com>
> Cc: Jonathan Adams <jwadams@google.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
We need a "Fixes" tag.
Reviewed-by: Shakeel Butt <shakeelb@google.com>
prev parent reply other threads:[~2019-07-03 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 23:35 Henry Burns
2019-07-03 0:59 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod7udORRrz7wzQPRa2Eya5TfrVh9kG037GKsAsSkRJPx7Q@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=henryburns@google.com \
--cc=jwadams@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=vitaly.vul@sony.com \
--cc=vitalywool@gmail.com \
--cc=wangxidong_97@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox