From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 539E4FC6194 for ; Thu, 7 Nov 2019 02:28:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 142A62077C for ; Thu, 7 Nov 2019 02:28:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uSDVaazM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 142A62077C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AACCC6B0003; Wed, 6 Nov 2019 21:28:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A5DEA6B0006; Wed, 6 Nov 2019 21:28:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94D636B0007; Wed, 6 Nov 2019 21:28:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 7BF4F6B0003 for ; Wed, 6 Nov 2019 21:28:26 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 2704A181AEF1F for ; Thu, 7 Nov 2019 02:28:26 +0000 (UTC) X-FDA: 76127897412.06.bath10_66b371104b851 X-HE-Tag: bath10_66b371104b851 X-Filterd-Recvd-Size: 6354 Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Nov 2019 02:28:25 +0000 (UTC) Received: by mail-ot1-f67.google.com with SMTP id r24so640588otk.12 for ; Wed, 06 Nov 2019 18:28:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wS6OdC+S2z/PBQgR4YDbDDYhyL0XvvxGi7c5qPyDE0Y=; b=uSDVaazM9cyqGwRXCwrtjFi/nHUtZ2J26+AP1pK5t+J0d+/Tj7/Z1yUPw5jdywtHtw 9HQP5ZcwqS0nMABJOIGE5EnPGMvomAgZELvKeJYd8O3dlqz9ZYsSGyWRiBuBUoSeBl6U vCRHFFi3U5GslJ40zsWHEcZlIrh6664iU/1LGaiAmEtJtacFVvswhNjlN0e3klHMBTdv YXlYs16vjS6IC9YLlku6Q2dYcySVxTO6pVtV7DLXuTbP5LimO/KlLarf7UmNGnKq8Hln uz0tuIjijpI1f8Z2Ul6YaCIva9zraCKef9iJ0Egiw+E6ilQSWVpHbCqAfn2vS/AAeTAj MeCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wS6OdC+S2z/PBQgR4YDbDDYhyL0XvvxGi7c5qPyDE0Y=; b=M8NqvcjKWmIW6ZUGWApH6QzntQKIq71PFu4PycvqIya8D/2uHC5ADwuLyMTmigQAMd wtuoVK0jfHJvTBVFXtMr8CXuz4YNnyCo2u9E2AGt42vE2oCEbxbqyUYipbdkdcVh8aUO BNEENC+Q0z8/rRSMBUABNXw1Ms3Nm4MEgo2QS3OdUz1Yxw6Chv/9OuVM9rwCjOUJHklJ AZUF6f8d3CHdZ3wI9eIFnhgPxR9MSpYz77ucpIhgNzsuwuowEkDe6r/hZy6WCbnvTn+X sDHKSsh1XR4z4R/+xMxLiAXPkVi2HH7nI+iR9e5wNs5jnHEeVAWm9ZUc0odfWT3hqWCw yizA== X-Gm-Message-State: APjAAAWwmeXISi4bBVD8XO73bjbTYW6g5/YpGQcfyMwGCrUJW0JCnpTE rce5vY86T0upXIlShB0YCEP5uxwkzKAXkhHLnOGtOejC X-Google-Smtp-Source: APXvYqxM3DVIoAFqmXRE/YkhMyMJgK2jWrlkdOL0UapC3KZIYGFGZxk0cHboKIbfF893h/cqlowss7WaPRbfFTJZrKk= X-Received: by 2002:a9d:5e10:: with SMTP id d16mr812912oti.191.1573093704582; Wed, 06 Nov 2019 18:28:24 -0800 (PST) MIME-Version: 1.0 References: <20191106225131.3543616-1-guro@fb.com> <20191107002204.GA96548@cmpxchg.org> <20191107014307.GA1158@castle.dhcp.thefacebook.com> In-Reply-To: From: Shakeel Butt Date: Wed, 6 Nov 2019 18:28:13 -0800 Message-ID: Subject: Re: [PATCH 1/2] mm: memcg: switch to css_tryget() in get_mem_cgroup_from_mm() To: Roman Gushchin Cc: Johannes Weiner , Linux MM , Andrew Morton , Michal Hocko , LKML , Kernel Team , "stable@vger.kernel.org" , Tejun Heo Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 6, 2019 at 6:21 PM Shakeel Butt wrote: > > On Wed, Nov 6, 2019 at 5:43 PM Roman Gushchin wrote: > > > > On Wed, Nov 06, 2019 at 05:25:26PM -0800, Shakeel Butt wrote: > > > On Wed, Nov 6, 2019 at 4:22 PM Johannes Weiner wrote: > > > > > > > > On Wed, Nov 06, 2019 at 02:51:30PM -0800, Roman Gushchin wrote: > > > > > We've encountered a rcu stall in get_mem_cgroup_from_mm(): > > > > > > > > > > rcu: INFO: rcu_sched self-detected stall on CPU > > > > > rcu: 33-....: (21000 ticks this GP) idle=6c6/1/0x4000000000000002 softirq=35441/35441 fqs=5017 > > > > > (t=21031 jiffies g=324821 q=95837) NMI backtrace for cpu 33 > > > > > <...> > > > > > RIP: 0010:get_mem_cgroup_from_mm+0x2f/0x90 > > > > > <...> > > > > > __memcg_kmem_charge+0x55/0x140 > > > > > __alloc_pages_nodemask+0x267/0x320 > > > > > pipe_write+0x1ad/0x400 > > > > > new_sync_write+0x127/0x1c0 > > > > > __kernel_write+0x4f/0xf0 > > > > > dump_emit+0x91/0xc0 > > > > > writenote+0xa0/0xc0 > > > > > elf_core_dump+0x11af/0x1430 > > > > > do_coredump+0xc65/0xee0 > > > > > ? unix_stream_sendmsg+0x37d/0x3b0 > > > > > get_signal+0x132/0x7c0 > > > > > do_signal+0x36/0x640 > > > > > ? recalc_sigpending+0x17/0x50 > > > > > exit_to_usermode_loop+0x61/0xd0 > > > > > do_syscall_64+0xd4/0x100 > > > > > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > > > > > > > > > The problem is caused by an exiting task which is associated with > > > > > an offline memcg. We're iterating over and over in the > > > > > do {} while (!css_tryget_online()) loop, but obviously the memcg won't > > > > > become online and the exiting task won't be migrated to a live memcg. > > > > > > > > > > Let's fix it by switching from css_tryget_online() to css_tryget(). > > > > > > > > > > As css_tryget_online() cannot guarantee that the memcg won't go > > > > > offline, the check is usually useless, except some rare cases > > > > > when for example it determines if something should be presented > > > > > to a user. > > > > > > > > > > A similar problem is described by commit 18fa84a2db0e ("cgroup: Use > > > > > css_tryget() instead of css_tryget_online() in task_get_css()"). > > > > > > > > > > Signed-off-by: Roman Gushchin Forgot to add: Reviewed-by: Shakeel Butt > > > > > Cc: stable@vger.kernel.org > > > > > Cc: Tejun Heo > > > > > > > > Acked-by: Johannes Weiner > > > > > > > > The bug aside, it doesn't matter whether the cgroup is online for the > > > > callers. It used to matter when offlining needed to evacuate all > > > > charges from the memcg, and so needed to prevent new ones from showing > > > > up, but we don't care now. > > > > > > Should get_mem_cgroup_from_current() and get_mem_cgroup_from_page() be > > > switched to css_tryget() as well then? > > > > In those case it can't cause a rcu stall, so it's not a so urgent. > > But you are right, we should probably do the same here. I'll look > > at all remaining callers and prepare the patchset. > > > > I'll also probably rename it to css_tryget_if_online() to make obvious > > that it doesn't hold the cgroup from being onlined. > > > > SGTM