From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B02AC76196 for ; Tue, 28 Mar 2023 13:24:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E089F6B0072; Tue, 28 Mar 2023 09:24:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB8D96B0074; Tue, 28 Mar 2023 09:24:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C815F6B0075; Tue, 28 Mar 2023 09:24:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B82B86B0072 for ; Tue, 28 Mar 2023 09:24:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 87BB812024C for ; Tue, 28 Mar 2023 13:24:50 +0000 (UTC) X-FDA: 80618377140.03.A26DBFE Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf27.hostedemail.com (Postfix) with ESMTP id CD24D40007 for ; Tue, 28 Mar 2023 13:24:48 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=iLIlR3Vy; spf=pass (imf27.hostedemail.com: domain of shakeelb@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680009888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ntULfQJggmdaqbZLqK7ncFbPSNSEXt5TzQS/aFU/5Pc=; b=dvQuRyLG5QfmEOUOKmX2Ri7EQIKB5XvVMVw5OO0LNQFvPoOwYKTftIPJlfcUthjUj6tDbS 9ImM3QFSBnfzUfx+L6ZlnNQ07rbUOcCPSo0GbLs6QA/6vR6y6k0G8QpsK6jG6HDxKztSk4 JcxXnVoTqwG/0oYsf8atf2BalPaJxBk= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=iLIlR3Vy; spf=pass (imf27.hostedemail.com: domain of shakeelb@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680009888; a=rsa-sha256; cv=none; b=URPJvj1226Hh5KvIjPtwYWYMDs5KpEkTNCK+ogFM1AekhKW6oM4Mbeg6tQsBhqTiHD0gxm q8bJf3LfPq++Bg7/chvvNVFgFBTjuhSoYLWELtBGMhqbx+WAmDZOFY4bpdQTkPSVEw5QBE LbmZdvDWUo25/zi8jIjeIfMW/DAGhnQ= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-544f7c176easo229027387b3.9 for ; Tue, 28 Mar 2023 06:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680009888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ntULfQJggmdaqbZLqK7ncFbPSNSEXt5TzQS/aFU/5Pc=; b=iLIlR3VysUqN2n+K7Rz9WKfCcJLSTSx4NXO9I1yXLrlfhLgH5+IkJOW/OExv+tAp2p KLwmq425It8H20dpM0ac09a+vLFQBsaodZP50nnSdn4NPSgU/FnP4IoWbe2linipSeqz gXPndO8BQ9boGvc7auVZsdo8oEo2nNNubeOewSk0lDqJmSYfpk9BL0NvDdeBZ/+eYbYt vCoep2rw0xDCxlAUelFlpn+OMs11ce2T2shwo+AdP9qIAH/gH8oGDJNKaJLz4JCsPJcy 3O/lx+x7RQmoTNPuwkKIytNaDqU/QTxCL4tT2Daz/Dep3lWyEoL5WhB/cC0yuxcgmIG1 Cdkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680009888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ntULfQJggmdaqbZLqK7ncFbPSNSEXt5TzQS/aFU/5Pc=; b=2fMEqV82qte4kPjCKjMrOdu0FWg703IVuD5+1GsE4Dvg/w6Nxvk/xemAJRXm757N4N X+2PKJQGHJaNo4a1uWdpqvf1l37l1bmwLnQ2fS6bFwSLevQPYHOf3WN5HfaZlm2XODzR BemGjlF2ch6cvTqHcCi6VQRHlOGAVnJhAc+CaEbAR6SK4Scw5k8fdrg1uRrU8HoZrmvR 4WU0Iy1W24dlAjVDgtjrBsU8oYHwWNkUYULT0+ayJtr0Q8+Yh79AhxOYWQaAOBbVdTBO wsV2dUDddSc51SqDrw1kPbx5H5MbZYMRc1xuUQ0FGmaygJSGma7mi9zxANcoP6mw+qA0 wIuQ== X-Gm-Message-State: AAQBX9f1aPWBW1tBEdib5V5wuLdeYeduH9IFkEs6qkfT2ayn+t7ZM7nN UaMfW8NzN8rN5rpHbS9oqCNrlqQR70v0xn/US6QIRg== X-Google-Smtp-Source: AKy350ZbQ5L3cvQeH+/uAiEzez0+L4i4KA3mwR2j+xMSO9YwlPgoHcvCiIw0v9a5U7lB87sYMPJen1Av3A82DPd1VBw= X-Received: by 2002:a81:af60:0:b0:544:b8c2:3cf4 with SMTP id x32-20020a81af60000000b00544b8c23cf4mr7307084ywj.1.1680009887781; Tue, 28 Mar 2023 06:24:47 -0700 (PDT) MIME-Version: 1.0 References: <20230328061638.203420-1-yosryahmed@google.com> <20230328061638.203420-2-yosryahmed@google.com> In-Reply-To: <20230328061638.203420-2-yosryahmed@google.com> From: Shakeel Butt Date: Tue, 28 Mar 2023 06:24:36 -0700 Message-ID: Subject: Re: [PATCH v1 1/9] cgroup: rename cgroup_rstat_flush_"irqsafe" to "atomic" To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CD24D40007 X-Stat-Signature: ko1bczox7ec61prdko1q6fo3ccjgzh1q X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680009888-114141 X-HE-Meta: U2FsdGVkX1+3vvJVYSlVLeR7WtY/ZcQRQ88sx4h3IifcS/hQhFFZsIV62eRzCc9VXyCZsF5D2v/U+gdKSwMSIruEL8EXsyihDFBfqBVF/FU05YifyFcvIWOg+IyG3efIXUCM9K3CvFDuBf4z9ONPIyg+RWo3k+9qdYG8Fvm5Z7Cfud1stLijtHKCr/8/xjgiBS7wbsDYLDJwl17Nr8pLKDDSOuzxHkqUF04qE1pnV51OdajrucuIlISo6lWjGwbcfUaE+MohEOrbtlIPKFgJglyBMJrum5Es11Ig/W4lYoWJF6/D00uDfJZ+GLYyo99s4uZTYQIRKJALTnmOt9S31W9n2IJuFSiwby54hmoPDJ+YkrxzqUkTh51Hr5nD2lz2MtHdwbEnFSewiQYnvELgrtRwN7J7PiWxKd+plMARiqeTifspaSHqASYvGd+PnRKhWH4d/LM3Xf3/66n0ML1vZtwbCDd9br3OS1zuqDsSNoFaYtTKXRMrRXosE2ZqmQM7IT27lBAKKBtRr5mI33AL8m6nzqX0PUhDUGQ3zDRfZ2Dp67i33BXsRopVJlze5vfbj81YvSPnVaUKveEsq4Jf3mHvkK5ZkVmlt7j7zAGD3MV3r4E02a+HdEwwgriZiy6JPyaqEHU0jT604a4O65RmS5SuobWC6QGf/tXYa4OI8psMv3M4PjqA+JaUkHLoEX2MiFltis2dCoAcBJBkHFblROIaskx86qRdgkIUNdE9y5/RC0aPAVGr7Hf/SvBE8xUlrmtwx7zKvzCnLyzDrKelW/oowpc/h/lvtH1nlIxJmdRne6Ys+crlVlNWTjhoU6q1iRtt3Os1bM2q3McVtsRGB8bvz8V6aN5X+mW7CqE8L4nEr8kCzX2x5Jl01MiiGNMToPRIhkwT7C3ZsiPC6py7vMKeAHohuCCiq8J5xpYiAx9v8MjheQCV0o3W68F1q6JGilk+eJNosyp+vYLxl4l YuTmz0ar TNlUi2I/IdcDEKavj3xhUc5QWNPsap8IJo+i0M1QPolTiwpz4Owx9EqHb8ilPAUsb/AZcbZLvK+MKhFDBJElJUgIf5REqbZxREhndB/T64X8np8jJRoGYINW5wS+YEIB64z6inYs2bRNmHol/oMsMRFD8FBRKJAAah2DO3k1ifsRyT1MF84hEpHl57HXI3AkF+nZ62JpsJPwbsK+7ZiBG+7JoN/M6bScad7xb3o6uZLbTEf5dS5etiRo3Kl592xe7iGm0U2Y7COo2uH6ErZMUKX5FkPraIrBHUijXXks7uF3nY3QkM5qWQr2wYdTHABXvamVX8dXrQiV3+/MZor2O/dUjZbHfKgdvRGcYbLQ9IzUB64Xy5hcIGYnnlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 27, 2023 at 11:16=E2=80=AFPM Yosry Ahmed wrote: > > cgroup_rstat_flush_irqsafe() can be a confusing name. It may read as > "irqs are disabled throughout", which is what the current implementation > does (currently under discussion [1]), but is not the intention. The > intention is that this function is safe to call from atomic contexts. > Name it as such. > > Suggested-by: Johannes Weiner > Signed-off-by: Yosry Ahmed Acked-by: Shakeel Butt