From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7616C43461 for ; Thu, 17 Sep 2020 01:12:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5FEAC206DB for ; Thu, 17 Sep 2020 01:12:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hCWvmjET" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FEAC206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AA6A38E0003; Wed, 16 Sep 2020 21:12:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A579E8E0001; Wed, 16 Sep 2020 21:12:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91E858E0003; Wed, 16 Sep 2020 21:12:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 7939B8E0001 for ; Wed, 16 Sep 2020 21:12:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 38925362E for ; Thu, 17 Sep 2020 01:12:51 +0000 (UTC) X-FDA: 77270778942.11.chain54_2b0f0462711e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 01401180F8B80 for ; Thu, 17 Sep 2020 01:12:50 +0000 (UTC) X-HE-Tag: chain54_2b0f0462711e X-Filterd-Recvd-Size: 5010 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Sep 2020 01:12:50 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id c2so491654ljj.12 for ; Wed, 16 Sep 2020 18:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mVFEQ2ojzPXsy6/BeRJx9bRw+Riz8xGIOrZymfMmFx0=; b=hCWvmjETmGnj8dUIeEh40To0bivwiX4baV3SR2d+cyGlVkknWwoi6Y+qun6337DBn3 6vkj+oNBHIvrog4mWgYHGc1SHsSTVZOo9flRSF7hlnkIxSv04V4sQXiXlkddxIFiu++W qclMQQaZarvaopfB5zwebgXTvvXK2+yqK3ZPBEnoTmz/wDoWbdZOauruH+KPcLwYO7lH 4pzDhGIDAPMWaZFoPW8FMDDsSFCM0nJUv4puoYBtq8Y/8fKLHvSo0i/eT1JLoFqxmC+V PPMJ7Dr+J98VTyKN2NhTgEh8GhFMx0MbbLSn3s7QtluAj87WfYg3ktn2mRD19++UB0/J 0iTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mVFEQ2ojzPXsy6/BeRJx9bRw+Riz8xGIOrZymfMmFx0=; b=n10lhB7iwrzNiUBsEJgGeBoKtLEcQTicgthxC0QbMOrNZujNxiE9PBWuQfwZnuU2VY 1oJrszJakQZDXN5s6rwdZWU4T72x1R5FWFhyRoB64qfYDtDCnIiHGhJZDz4CwgUwJnH7 f8rnC3Cd0BFBPcQZnjrvdfCoiWKODp/HlVlQAaLgLDEKicmSOBdK3+Zj/scpS0LcGuKV QZJJNLE1+n+sNv/skz0JZ43KwBHuRF/jpe/aIJ9lS7iaZ3FCwGm9YOrtE3a0gPh803ZZ tHqUiexIQv1YCsRvDCvdld54Qcy1cZzbznbjXUbJg8BtoB5FZj1zQSChva2V5R2Zky14 FiOQ== X-Gm-Message-State: AOAM532xgAnKXCM/3TjIdP6WoJYzCpytAvMKybMtBuLuyQHXaRBi1OpW YubtHsKklXvIjKdBmz03gVbAwA6sA8tsLVzM2APpfg== X-Google-Smtp-Source: ABdhPJz5EIVwc296/t23ooatEw7C3O5jedtlzyePX2E6TSDGKVSVz/hsQc16mfeeNDN1rP+EeMd6vcK2o0IJLrqcj2E= X-Received: by 2002:a2e:3511:: with SMTP id z17mr8747331ljz.58.1600305168793; Wed, 16 Sep 2020 18:12:48 -0700 (PDT) MIME-Version: 1.0 References: <20200910202659.1378404-1-guro@fb.com> <20200910202659.1378404-4-guro@fb.com> In-Reply-To: <20200910202659.1378404-4-guro@fb.com> From: Shakeel Butt Date: Wed, 16 Sep 2020 18:12:37 -0700 Message-ID: Subject: Re: [PATCH rfc 3/5] mm: memcontrol/slab: use helpers to access slab page's memcg_data To: Roman Gushchin Cc: Andrew Morton , Linux MM , Johannes Weiner , Michal Hocko , Kernel Team , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 01401180F8B80 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 10, 2020 at 1:27 PM Roman Gushchin wrote: > > To gather all direct accesses to struct page's memcg_data field > in one place, let's introduce 4 new helper functions to use in > the slab accounting code: > struct obj_cgroup **page_obj_cgroups(struct page *page); > struct obj_cgroup **page_obj_cgroups_check(struct page *page); > bool set_page_obj_cgroups(struct page *page, struct obj_cgroup **objcgs); > void clear_page_obj_cgroups(struct page *page); > > They are similar to the corresponding API for generic pages, except > that the setter can return false, indicating that the value has been > already set from a different thread. > > Signed-off-by: Roman Gushchin Nit below. Reviewed-by: Shakeel Butt > --- > include/linux/memcontrol.h | 48 ++++++++++++++++++++++++++++++++++++++ > mm/memcontrol.c | 4 ++-- > mm/slab.h | 27 +++------------------ > 3 files changed, 53 insertions(+), 26 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 0997220c84ce..48d4c2c1ce81 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -375,6 +375,54 @@ static inline void clear_page_mem_cgroup(struct page *page) > page->memcg_data = 0; > } > I think adding comments on these functions would be helpful. > +#ifdef CONFIG_MEMCG_KMEM > +static inline struct obj_cgroup **page_obj_cgroups(struct page *page) > +{ > + return (struct obj_cgroup **)(page->memcg_data & ~0x1UL); > +} > + > +static inline struct obj_cgroup **page_obj_cgroups_check(struct page *page) > +{ > + unsigned long memcg_data = page->memcg_data; > + > + if (memcg_data && (memcg_data & 0x1UL)) > + return (struct obj_cgroup **)memcg_data; > + > + return NULL; > +} > + > +static inline bool set_page_obj_cgroups(struct page *page, > + struct obj_cgroup **objcgs) > +{ > + return !cmpxchg(&page->memcg_data, 0, (unsigned long)objcgs | 0x1UL); > +} > + > +static inline void clear_page_obj_cgroups(struct page *page) > +{ > + page->memcg_data = 0; > +}