linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Shakeel Butt <shakeelb@google.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	broonie@kernel.org, linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	linux-next@vger.kernel.org, Michal Hocko <mhocko@suse.cz>,
	mm-commits@vger.kernel.org,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: mmotm 2018-03-07-16-19 uploaded (UML & memcg)
Date: Wed, 7 Mar 2018 18:41:04 -0800	[thread overview]
Message-ID: <CALvZod7qDS7YN1P45uaOwMK3qPBv=VSMC=8TZSRE_DTaspXxjA@mail.gmail.com> (raw)
In-Reply-To: <CALvZod53CV+R0CeVPDJ=3JAtFjyOfSSSrr3x0tqAWHec0AshTA@mail.gmail.com>

On Wed, Mar 7, 2018 at 6:34 PM, Shakeel Butt <shakeelb@google.com> wrote:
> On Wed, Mar 7, 2018 at 6:23 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>> On 03/07/2018 06:20 PM, Randy Dunlap wrote:
>>> On 03/07/2018 04:20 PM, akpm@linux-foundation.org wrote:
>>>> The mm-of-the-moment snapshot 2018-03-07-16-19 has been uploaded to
>>>>
>>>>    http://www.ozlabs.org/~akpm/mmotm/
>>>>
>>>> mmotm-readme.txt says
>>>>
>>>> README for mm-of-the-moment:
>>>>
>>>> http://www.ozlabs.org/~akpm/mmotm/
>>>>
>>>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>>>> more than once a week.
>>>
>>> UML on i386 and/or x86_64:
>>>
>>> defconfig, CONFIG_MEMCG is not set:
>>>
>>> ../fs/notify/group.c: In function 'fsnotify_final_destroy_group':
>>> ../fs/notify/group.c:41:24: error: dereferencing pointer to incomplete type
>>>    css_put(&group->memcg->css);
>>>                         ^
>>>
>>> From: Shakeel Butt <shakeelb@google.com>
>>> Subject: fs: fsnotify: account fsnotify metadata to kmemcg
>>
>>
>>
>> or x86 any time that CONFIG_MEMCG is not enabled.
>>
>>
>
> Sorry about that. Replacing this with mem_cgroup_put(group->memcg)
> should solve the issue on the mm tree.

Andrew, do you want me to extract mem_cgroup_put() API from Roman's
patches as a separate patch?

  reply	other threads:[~2018-03-08  2:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08  0:20 mmotm 2018-03-07-16-19 uploaded akpm
2018-03-08  2:20 ` mmotm 2018-03-07-16-19 uploaded (UML & memcg) Randy Dunlap
2018-03-08  2:23   ` Randy Dunlap
2018-03-08  2:34     ` Shakeel Butt
2018-03-08  2:41       ` Shakeel Butt [this message]
2018-03-08  2:41   ` Andrew Morton
2018-03-08  5:06     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALvZod7qDS7YN1P45uaOwMK3qPBv=VSMC=8TZSRE_DTaspXxjA@mail.gmail.com' \
    --to=shakeelb@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=mm-commits@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox