From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47AE3C433F5 for ; Sun, 22 May 2022 22:09:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D66DB8D0005; Sun, 22 May 2022 18:09:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D17218D0001; Sun, 22 May 2022 18:09:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2C538D0005; Sun, 22 May 2022 18:09:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B57918D0001 for ; Sun, 22 May 2022 18:09:54 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id D5F166091F for ; Sun, 22 May 2022 05:42:26 +0000 (UTC) X-FDA: 79492283892.23.FC60516 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf23.hostedemail.com (Postfix) with ESMTP id DDEDD140023 for ; Sun, 22 May 2022 05:42:02 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id t11-20020a17090a6a0b00b001df6f318a8bso14751992pjj.4 for ; Sat, 21 May 2022 22:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bBI59+/Mk1qcvOSbPvYhnqJ5zoTVecAGEJlppXiLu6Y=; b=O/ph2IYRp0V2AhfsaXi9hMpSgWZnCWLqgH2Y1fhsQ4BTcb29O2tpqYIvertEUoZJvU 2KyONSlo9FbFjT/ZgjQcJ2mXq9Ax980XqP34dHTA7HV/j9BfKN6Tbwdgtz++f51xT9vI aRe0v+4hxg4W+myKeX1IARf5Adt41maG9WVkk5N4nzzBp9yG2MxFucBsNn2MlDcpPMrZ 8ERA+hOm01p9hg38D7aZcddaBNMl3OhjzwM4fwCmDLB15Yzx0onEil3kIcst6U2oqXtA JYtmPIOrcvaQEjIHl40Sl7arNZbd5D0olOBrO2HH0W0Riy+P+PGQMlu7aA4PcA+vVJRq GJ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bBI59+/Mk1qcvOSbPvYhnqJ5zoTVecAGEJlppXiLu6Y=; b=Hy6jmy/aQZN5JMzL04/2wv1jddRReeYVf6IL3FmzAGMlp559/fsiPiHGtgldgBm+wW +8iK9BGlivOsW0bkY3YZO+Jo5AIjAHB4VgUFBGDvEhf1km/CW/zy8ZBXlUDe8tt+4GUv Piepj+aH1gFdsxVwetK/mLzvebVd4+PorZ0egB49FixMP71yirSqyhtIcmMkwPsfso7u mQJmT07DJeP/QFwU3mXBGGtENTOy4+TDUKZQj3mRcGz1OzN2N968+Sm1udKTbH1M642y Gb1bdeN+RFeWmsDD/gTVy+FR+47kymZjtdg36MBuUnps33GZP2hl/rkMkOG7yTEweEuS Q4nw== X-Gm-Message-State: AOAM530Em9F8VSTzBiQtYn1hxfxweNCQC1CxZObz5gSnn7tkCcoIVH3V yRBb5bTMn/GOV5W9hDw607+rgbmG2C+1ZYYkBoSdNA== X-Google-Smtp-Source: ABdhPJwR4FMIytVbwpKHhsZNCCzLlAtdPgrtrkhOElmwuPvCrD2KIe9ndhBtVpJiB5yO0xWGi24/9ogYkEZNoiZ8TZY= X-Received: by 2002:a17:902:b094:b0:15c:dee8:74c8 with SMTP id p20-20020a170902b09400b0015cdee874c8mr17212912plr.6.1653198141149; Sat, 21 May 2022 22:42:21 -0700 (PDT) MIME-Version: 1.0 References: <0c73ce5c-3625-6187-820e-1277e168b3bc@openvz.org> <1621d82a-439d-0657-2b7e-5e90c42c2087@openvz.org> In-Reply-To: From: Shakeel Butt Date: Sat, 21 May 2022 22:42:10 -0700 Message-ID: Subject: Re: [PATCH v4] tracing: add 'accounted' entry into output of allocation tracepoints To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Vasily Averin , Andrew Morton , kernel@openvz.org, LKML , Steven Rostedt , Ingo Molnar , Linux MM , Roman Gushchin , Vlastimil Babka , Matthew Wilcox , Joonsoo Kim , David Rientjes , Pekka Enberg , Christoph Lameter , Michal Hocko , Muchun Song Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 37itsiay199p6k5p1jdab3ornfjf433e X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="O/ph2IYR"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of shakeelb@google.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: DDEDD140023 X-HE-Tag: 1653198122-349328 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 21, 2022 at 10:19 PM Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: > [...] > > No strong opinion but just a concern that maybe later someone want add > something similar like 'reclaimable=true/false', 'dma=true/false', ... > and I would prefer more general solution. (especially if we'll not > change tracepoints after release because of backward compatibility) > There is no contract for tracepoints to be stable and can be changed. > > For my task it's not important to know SLAB flags, I just need to understand, > > is current allocation accounted or not. > > SLAB_ACCOUNT, SLAB_RECLAIM_ACCOUNT, SLAB_DMA, ... etc are SLAB flags. > > 'if current allocation is accounted or not' depends on SLAB_ACCOUNT > flag is set or not. > allocation can be accounted due to __GFP_ACCOUNT as well.