From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB02C77B75 for ; Tue, 9 May 2023 18:17:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62ED76B0071; Tue, 9 May 2023 14:17:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B8656B0072; Tue, 9 May 2023 14:17:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 431806B0074; Tue, 9 May 2023 14:17:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 308C46B0071 for ; Tue, 9 May 2023 14:17:56 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 04FAB140451 for ; Tue, 9 May 2023 18:17:55 +0000 (UTC) X-FDA: 80771525352.14.B2A6827 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf26.hostedemail.com (Postfix) with ESMTP id 0AB1B140003 for ; Tue, 9 May 2023 18:17:53 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Mli6sJjz; spf=pass (imf26.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683656274; a=rsa-sha256; cv=none; b=QR/zzMDyR3GatAZ1b9DmnO0VYiflmeyyYQBb5xQORyItbyf1FReyj/4uid32iE5AjmBLJq O/9iUJ6dER4MdxIVSxaGHCERQHZ8KK+cnEA1m9rbD2Vw2CCc83rR+1byqhQaC3jlOH+4JY dp6WEUUOJpcjx0JSD+lZ61v3T5vWJsk= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Mli6sJjz; spf=pass (imf26.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683656274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S2UHCATH3G4CuSJf4Vt2XimiowlnQCvyva4J0Y6pMkg=; b=aMocJWHIjAeCKF3nKbxaHQJIdBDhgKDU2EgaH4q4rRRdoUk1NvP4X+s+iyO2gFv6LhaCTO CNsuYydoP68V5BsOCaf9ZT1KS/eMlAWf8beAjkDLexUbaQrgDXCqocXlPqafMQUVNujOGZ s1VpA8HUTwPfk+waHSc/8/JCoXFWocI= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-3f396606ab0so266921cf.0 for ; Tue, 09 May 2023 11:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683656273; x=1686248273; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=S2UHCATH3G4CuSJf4Vt2XimiowlnQCvyva4J0Y6pMkg=; b=Mli6sJjznQpwgkxl03KMv9Ha9Q0uVZi6usPfIE7bV5rhYWG3rMpH/tXFlJYEQAtrPe C8cQFSATIeyaRKBBearzQRWEPXqK4RTh2/pbm/3KotJawrCfoQAMmqG6KHFGv0+LInVD xe2zW+twGzSmkzZHHYOFM1isS8rlNC90pLpUbUTUQeMewuWnwYvdzuDokXbe4dHMx/Ft QRR4TS0bsiIz2PJzZtMS0BqZJuILhC++3fY+TwB5CHWXhg6KMfPMzKGe55CFAOY+VZT9 L1AHCrAVtuGUJ+NyEGBiFau844G7zH2uAbHNSHYGDfSFROX3VTT1dBqC6uhn3hbpyNxi ZDbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683656273; x=1686248273; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S2UHCATH3G4CuSJf4Vt2XimiowlnQCvyva4J0Y6pMkg=; b=N4O1s4YuSRxklFUcL7IgjIMRdxGCJazGMww5VRDV++CAJY2l7R5ZuP/yuqUuXR43sM pMdkN2wlJiLydhIeQ866xsb7jBWJGt4P4e8BKKc3bgNZPhJVwn8zOGuBI49nQ44CqcEO 0COarGgagpnzcrfTN6mxE3JZsfwKLChdvFljY6AegL/paX3+zfuuLsNoRDy83mdhhr8z tueVP9MSmiLmrSuIyW2YxCZkiFJeiRLW7e2KEm8mTm2J4DzSlge8Q4k4OB5YNJq61p2S qLIs94sJxG3gVDyGMwVKTl6kM00cg7VYbq9oEzxAjLKB/RhS31scLC9lUb8g7joVc8RO HRdQ== X-Gm-Message-State: AC+VfDwBTIZZOO71/VzjCLila00rR7BOlmD3XiGuBLQjm2mGfzyowV4i xWNsfd017XM1mGD+l+ko3DBgD0Nz3j4/ITsOH1N9D/2diilo82LDt2U= X-Google-Smtp-Source: ACHHUZ7G3A1pxETvCDMCgi5l0cfgkN5QkyBZAAL1qT1lH27vzhUsZzS/gxx89nyDdD3eGuZO5abz0LGlDhqNrNGqX24= X-Received: by 2002:a05:622a:cb:b0:3e0:c2dd:fd29 with SMTP id p11-20020a05622a00cb00b003e0c2ddfd29mr42041qtw.4.1683656273106; Tue, 09 May 2023 11:17:53 -0700 (PDT) MIME-Version: 1.0 References: <20230508020801.10702-1-cathy.zhang@intel.com> <20230508020801.10702-2-cathy.zhang@intel.com> <20230509171910.yka3hucbwfnnq5fq@google.com> In-Reply-To: From: Shakeel Butt Date: Tue, 9 May 2023 11:17:42 -0700 Message-ID: Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size To: "Chen, Tim C" Cc: "Zhang, Cathy" , "edumazet@google.com" , "davem@davemloft.net" , "kuba@kernel.org" , "pabeni@redhat.com" , "Brandeburg, Jesse" , "Srinivas, Suresh" , "You, Lizhen" , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" , "linux-mm@kvack.org" , "cgroups@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0AB1B140003 X-Stat-Signature: d7twnazpap3ajuqe3dtso84zheqt9cn1 X-HE-Tag: 1683656273-356550 X-HE-Meta: U2FsdGVkX1+aqP9l+Dy2ugopbF/mJDBaJb6LEhSE/2Ikdg7Twe+mZqCgQZQoC4VM7hEYWAGoeswd891rJWe7zJ5Zh8Xjdo5W/ZJLPWo6YyKiqk621QYyNKAYo/g2qlp0UdBrgzGQAIthPhbSriI/cW6nhp2l0mVj/KYVx32ZhWwr/bsSUnoyhaFJHJKt7gXwYyZFUn1unLnwINp92R6LE5rvAN/sf1La9pNkOXCRUS3rIV9NhlIpstR23o62H7fwrJbSr9lU+MM4O7P7DyWbsrKbgw3ICm0z8Ngni9Anr4404jzR9g51FsgSrbPjHtu3OtXeVuMN2vjmU6GiwqzEQoM5zfLB3HcrxtTmBHnkQ7+iH6cNOwNodpsDHsEjaus99WHKb292gkqqwT0gGDjy4xiJ68aUY/v6D9D+jTQMLC0rZ8hmmmitEEnsWadf7XP7sjxBjYeAp4bbw31zIfvR1lfFh/2ixOIf6lV4YlVomUtzyorsh+qF5XfUlEx8ExdJ614HO4UPy8RXkj0+bo2ALknOIq9qZ0vkjTcZ50rLmMzneLwkNTLBvTqV/JeFmw7pGVNObCqnLvMAFF0vBoIcLF3Bwyck5dFp+X7tN5AbNNGP3+igaF4iN225k3LJRfF8W9Lhs9aZPzaEtQNR5z7t+5BCxcENlxZK95Sn2wRiL8Q8NVMGjwwBOi6vbIabeUZsmPlZcgFgNQUDJWs5v3rqdhmB/US+7e1yHrOcPq31U7j3BthDU9wwAmC7MEe3jfxSkszx1p8ovxa3Bfkm3s2TXQO4PdrvVjxu/VhjTzhjVJMuS7PQ3rkN1UUM8egA1YwuHWijmCZWJ5EtD0J7oy0hLb86szYBxcokiweHvNz7Nd8D3UH06XgWLr22JvPOgksYrcbGeiKiMLgZDeDApAQ7yYW6I9HJKOPnS2b5vlMM4CeeeKDpmJ6WJvFfxfKmts9Z4tcBhMNar8lDwXgYrqa sAiqzK0u YtKly9uKQSdgDW95N/yiJyTh/wLSscDEY4i2cry3V7mBY/uBhZQb5nMtTJxOyi7IQ4/vz+c8ZREWj9h78z0w9Pzw+oEpK7kOWXTpPtMub6sLIBOqDqhEJdJ6R3vj7vtS8ga1V5Zzm/wj+whK4/79Yf3zbaBd/LjCiajz1YFUVI++cGO+emA3Azx4yiZpqdzAoaSxYeqiv/VLWzBWu4L7ORFfaKriPWmOkyk3zWYnsi64HLafEHbcJxK6o3GBUob6G2OlCmmOzCypJj/Pe6EgZsHVerjMDdtZkpHBbgRpn5x9Dp1+N6W1eyLiWL0lHhzaLHiws9yBdabL9dDcgVRlIWcSmv80L+GhFHuuq1BBKYFRGxnO2LfQeBIoaSO/UtEuQdksUcmY/8ipWq/ReYzrZ7EfRHg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 9, 2023 at 11:04=E2=80=AFAM Chen, Tim C = wrote: > > >> > >> Run memcached with memtier_benchamrk to verify the optimization fix. 8 > >> server-client pairs are created with bridge network on localhost, > >> server and client of the same pair share 28 logical CPUs. > >> > > >Results (Average for 5 run) > > >RPS (with/without patch) +2.07x > > > > > >Do you have regression data from any production workload? Please keep in= mind that many times we (MM subsystem) accepts the regressions of microben= chmarks over complicated optimizations. So, if there is a real production r= egression, please be very explicit about it. > > Though memcached is actually used by people in production. So this isn't = an unrealistic scenario. > Yes, memcached is used in production but I am not sure anyone runs 8 pairs of server and client on the same machine for production workload. Anyways, we can discuss, if needed, about the practicality of the benchmark after we have some impactful memcg optimizations. > Tim