From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77B8EC77B7D for ; Mon, 15 May 2023 04:13:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88538900003; Mon, 15 May 2023 00:13:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8339E900002; Mon, 15 May 2023 00:13:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FB6D900003; Mon, 15 May 2023 00:13:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5E0C1900002 for ; Mon, 15 May 2023 00:13:35 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 16263161262 for ; Mon, 15 May 2023 04:13:35 +0000 (UTC) X-FDA: 80791170390.13.01E6C54 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf02.hostedemail.com (Postfix) with ESMTP id 4E02980003 for ; Mon, 15 May 2023 04:13:32 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=7SCyQfiT; spf=pass (imf02.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684124012; a=rsa-sha256; cv=none; b=50nlwwf91Zcju5tEYYyXg9iOJp/YbeqB+1kVnjRR7Dp9neLNyoHLhnmEPqNrC8K2e6J8yr Cu9Lr9T/OnuDIvCqg9RxskVr5ghlmiCQHRzKFSwzGN2SC+wb9QEZEcM13zDy1/kjJ+AA5D ybtKHd+21fCr0GvJJZzSJIqRqhwEOYQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=7SCyQfiT; spf=pass (imf02.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.178 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684124012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YStTJgpJxghtuoBZk87RzSQY/v+lqurPQ0sgyIhp1Ps=; b=avmpCmkiP0ASQ7cxStewXKxVgWekvPQVhdWu71LaarK7qkucxNGV7ICjAIo4mBAMYeLRc4 UJ1yAmDntYUA2Q6edE/G4r8gCc605YHg1zO3FZu3zKI8/x0yQoD6hpC7z7kozR/Zq0by20 XfM0Ws4Fp2TIsRDBNSzX76uEAPdSAHs= Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-3f396606ab0so1355811cf.0 for ; Sun, 14 May 2023 21:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684124011; x=1686716011; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YStTJgpJxghtuoBZk87RzSQY/v+lqurPQ0sgyIhp1Ps=; b=7SCyQfiTw4tckZw3oxtRgm3S34UkIVRMsMkishGxaYF42kqIOh9pOrwcNY8jsGk2+X ViLkd+/8VsMrSaCScA6bvCPgpEshi1LK7YjW8cvAueeSF9E194mlh9pFfiPVe68yO34P BXiEtC4ThZO5lrRoIy4NpWgOET9HuSbGTUwXM5hGC82mJxfcdWoorRGZ9oy9+XjtnH+A uQrmk5y1LopWW9xCt17bquSWitNv9qWhbLYwLzFJAnYh4LH1n3RyKQUWnzfO8/Ev1Is0 JoUlKgdNqD1Wk2xHBUs/wKI3btKgUzNhwAuS5oFVszmlzYoHGwa8nU/79RCx/EgnhX3E sBNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684124011; x=1686716011; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YStTJgpJxghtuoBZk87RzSQY/v+lqurPQ0sgyIhp1Ps=; b=Dknx1MiQRhvdJq7kt5/Wl4RVNtezT67OxuRq4rJVxvMB5XppkZ67ohxF67qmS+cy7G kQWbWWNEDLCPcJranDUQQVNPlKqeYd5shjbxOIEEDJA3MMuofzrfZpvCX0N0xX1XpWSt pRbUsPHmeNuXKi2TO/KQEt/xbOnb/03gjPvQYbElg5y418YWYVH0LRpnFvtzlHA5a0d9 d7R3am5plzY1tYkd4fGsh+zuY9FlpmnuE/km6ni4VZ5N2BMU+wNErbhiqR5j18UsXZd2 g9aXfVKS2EtJk6KOVVJTOARz6NjuLodi3TZSyPQHZDTjoyZwiEghrjsO8sl70FwH8QOL Ak8A== X-Gm-Message-State: AC+VfDzqtlrS4kwqkNFcKn8clw/uSTQH5cctu+SubH8hkQgj0p//nPTh jvjTupbeHix20XfCD0ypXa8eV5Rhu9m8M74rMscdaQ== X-Google-Smtp-Source: ACHHUZ5ykYW2V6yWJQUZ51vyxTbY8cpo7eQrQ6U4bKjnsJLqpza5H8K01Tv4A9QRgZPm4hJ2ctiEFpsU4DiUiSzF1jo= X-Received: by 2002:a05:622a:14cf:b0:3e0:c2dd:fd29 with SMTP id u15-20020a05622a14cf00b003e0c2ddfd29mr1061107qtx.4.1684124011324; Sun, 14 May 2023 21:13:31 -0700 (PDT) MIME-Version: 1.0 References: <20230512171702.923725-1-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Sun, 14 May 2023 21:13:20 -0700 Message-ID: Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size To: "Zhang, Cathy" Cc: Eric Dumazet , Linux MM , Cgroups , Paolo Abeni , "davem@davemloft.net" , "kuba@kernel.org" , "Brandeburg, Jesse" , "Srinivas, Suresh" , "Chen, Tim C" , "You, Lizhen" , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4E02980003 X-Stat-Signature: ru8fbajjwhar8b6c3uyo1zkzjgcn7u87 X-HE-Tag: 1684124012-93079 X-HE-Meta: U2FsdGVkX1+/7lmWnzqsQFSFf8fqOcJ1oRGARdQwDc78oFUy2V1h3SdP/BJ6e8Yo3VD5wl/YSBRlfTbNN9q+Vzg1+X67o/byhIEMuFwCnFUoBL1RdqdnbkAjnxCBIA83YC2A69/d67ssoBgNKvwXui52HhFigMzK0jcnRt2zljo+3JG80bHqoxARXY8dEJgC5WHw+GZA/5QG93qFVatBsjCykNpnb6djv3K7BbrfsIlHYpx55t7ApzBhzMYYdfNMth4OTqIP9Zh//fx5YDutF10ZU0VDEo9H+L48DRy/fuxw/YqJgiqTv8JWZWParN1hx1IC+ht/p3U0J1tEcVv0U4GMdi1cdpexc+q2uM37bjLs3777B+mvmOICCqQMP3C7x8k7b+3Qgkm9mW7zRCB5ACArCDCev2x50gq8fo5dpEkvA1VPYzT6Q3pFG5kyj8HWBQlAw2GsmaJ/Zol2RuMEkG5aEH/jH80+E+BtFeT5r7tybqJ8eshfCrK4VJP0EpvUFVe9dnz1XKkoq8cGq14wadsEOZCk8KWXOZ/mrjDbwhMctbP6sTl9FpZPGTWNLRP4wiCN4QPq1ukFQWCIFuG4P1n9Lf56GFwCEX3xrNjYgEVQa2voC1OGfjL0pLs0NcLBEUMnM+I0gTkJojtkjHwyx2HeTetjEe0+PkZ7qPPrbmla4GVVO8drEjqmpXBzjeUc/HDbYSsPnv2u9SSh7EYzGFpwoXpjq3PD+RMO0UviPJbMfp7uvWY1wTv5hPu2MZehKGcJ0+rEJN90yf3xHHLj7+JQphRzHHWuMzMcZqG45dihqq5bg5eqiINP9QLMyVHkz86LUM9HK3FfEJ/nNAsvLowTaoZ7Tc7CDvCZ6Hp5baIUxJ4jH4QDVC0mPyv5mci3yn/wsm5m60WHvpRHo/SYW8drH+FNhYmmt1WW3MMMkWsIGYrwtvimOP9wyxgoxka13EvZvyf4u2lTVg3h88P 6YJ+QrZX 4Viq7vcJ/aczAFvwKSBz1WqS0oZNr7EeyfWJDYCESjXk8Qph3RyWRaXWGzXvOQumgx4A7PJJMrdHH8u6mgNibu18+MnLz/0v3zLeicZVU55Nor/wXw1zUUNuI11jhd2sZFc8U8kP2PtUOQO6YFMC0RMoabGiuKvUgU8gCUMxmSabHSGrQJxqOXsxjuVtg2LaYXHss578Lzn4NXjfPl6HjXVnR3LHwZI174gwvCW+frMUzXLtJiiQVY8wxVH1GHrI06IDN/uzSYVHvU2qJZFm8chX4OLUPYGzSwt6uIFXqqSAFLq/yzrfw7TLyizwOCGAvWKnv4GyzD6pkRW4Y+VL/cEZ4DYOc/vS9HTQxlUCxqHniTuNaFWLvbgRmV8xfIWAGj2rH8ek6fPYgipzl/7EMdEYdDqpxWnpZR+pCNqxt+T1tochU4SP/hdJbsDwzLI8xMWdjK9Yeh5O0I/kaPvrCTEh45Kd22a/3mOaXgelq3PSEsobkadu4udL/c3ZJLVy8gjxnkgujAE2cX/Q9eg2Tp+ve8FtPUVF1xcMvyTKVNNkOt194+mcJFQlhuJkebdmZO60OXYbyHhyg4veVnpJqWhT9AyOQOe/mFcK4EfqV7k6uHuwiuFMKIHZ/ggURQt6A5gcqj/kCBDZDbTNtsbdujB2A6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 14, 2023 at 8:46=E2=80=AFPM Zhang, Cathy wrote: > > > > > -----Original Message----- > > From: Shakeel Butt > > Sent: Saturday, May 13, 2023 1:17 AM > > To: Zhang, Cathy > > Cc: Shakeel Butt ; Eric Dumazet > > ; Linux MM ; Cgroups > > ; Paolo Abeni ; > > davem@davemloft.net; kuba@kernel.org; Brandeburg@google.com; > > Brandeburg, Jesse ; Srinivas, Suresh > > ; Chen, Tim C ; You, > > Lizhen ; eric.dumazet@gmail.com; > > netdev@vger.kernel.org > > Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a p= roper > > size > > > > On Fri, May 12, 2023 at 05:51:40AM +0000, Zhang, Cathy wrote: > > > > > > > > [...] > > > > > > > > Thanks a lot. This tells us that one or both of following scenarios > > > > are > > > > happening: > > > > > > > > 1. In the softirq recv path, the kernel is processing packets from > > > > multiple memcgs. > > > > > > > > 2. The process running on the CPU belongs to memcg which is > > > > different from the memcgs whose packets are being received on that = CPU. > > > > > > Thanks for sharing the points, Shakeel! Is there any trace records yo= u > > > want to collect? > > > > > > > Can you please try the following patch and see if there is any improvem= ent? > > Hi Shakeel, > > Try the following patch, the data of 'perf top' from system wide indicate= s that > the overhead of page_counter_cancel is dropped from 15.52% to 4.82%. > > Without patch: > 15.52% [kernel] [k] page_counter_cancel > 12.30% [kernel] [k] page_counter_try_charge > 11.97% [kernel] [k] try_charge_memcg > > With patch: > 10.63% [kernel] [k] page_counter_try_charge > 9.49% [kernel] [k] try_charge_memcg > 4.82% [kernel] [k] page_counter_cancel > > The patch is applied on the latest net-next/main: > befcc1fce564 ("sfc: fix use-after-free in efx_tc_flower_record_encap_matc= h()") > Thanks a lot Cathy for testing. Do you see any performance improvement for the memcached benchmark with the patch?