From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 522A1C433DB for ; Tue, 16 Mar 2021 04:29:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CDB20650A7 for ; Tue, 16 Mar 2021 04:29:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDB20650A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4F2FC6B006E; Tue, 16 Mar 2021 00:29:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4906C6B0070; Tue, 16 Mar 2021 00:29:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309EA6B0071; Tue, 16 Mar 2021 00:29:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id 145BC6B006E for ; Tue, 16 Mar 2021 00:29:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BD390180AD837 for ; Tue, 16 Mar 2021 04:29:50 +0000 (UTC) X-FDA: 77924459340.11.5C61A75 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf30.hostedemail.com (Postfix) with ESMTP id 5E7D4E0011D2 for ; Tue, 16 Mar 2021 04:29:50 +0000 (UTC) Received: by mail-lj1-f173.google.com with SMTP id r20so18898850ljk.4 for ; Mon, 15 Mar 2021 21:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3zzhDPqLig+/Zw9qmQx4u8x639EaQw4NkATkHqrVPa8=; b=bqOgR2ygnLQuRVD06CKj/ojYEyQPqN2mj140AA8RMfI0Vgdf5feZXBlzco50UxnYGj oz1mRBKDJh6BIn7QDi3dOeOGXKxhOUjLq4SKwMp9V0URMK1qEOYem4FIqLZdCEMg1SDk PQgWTWfQV4jzFgG4cMKL7ZEZG+oAhhVNTQa0WavQ4F3TrE+0RyHHBT5muwCHpm48nrmA f6ICyig6uJWhZxGmiWjgvlu47UYKGrmaEhKj6U0po4wNfyw7HsjU41NBTO6pQarA//vj XHn4IU3dw2YBXpy8bBwpqbOWtB44DLNCQxpdSOtfW99iMMdFEAJUvYtZO75DwB9RwiTd 8t8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3zzhDPqLig+/Zw9qmQx4u8x639EaQw4NkATkHqrVPa8=; b=XOBW3A26g5/t2iDxu5unLEhn/VeCw5oWxySqZHr0rN1ZY055t9VaQmULbDFfeUXl0w Tp+hxxZ7OilG0pYMUP2sXKkhhdBiFMYhDPl4SavvLkeAsfhzTxc+IWYB58fww6Yxd0RC x9ml4W7hJfVLHiqJZEBGBTwj5BZSgi7ICBIyDp3/bEV1Rs2NL5C7loMkej/LcNW/imLJ +Dvcm4kT9ghdl/IQUPReOdpKWBLavLlqgyVh+E6u82c+1M4DjJJuGObXUf/7xs4CPP8y UkYOuSY7TnvrAySO1A3fMV+mvqnwBGxGG5iRojgE4NqpsVdxuhrhjCLEnBGyNQbsEXZm 8V4Q== X-Gm-Message-State: AOAM533CnRZnJJ6GOZsZB5WxZnVvinZZIGx0yirts2EC3kbzkYfZY7c9 lb0CD8S0T5b4vJVtNvSLz2H7Pkoh/4OvUwRiyLoXpA== X-Google-Smtp-Source: ABdhPJxE/9OXY+BATVh6jHpB/W+8fFtp8mihEtkF4sbk+eO5Tos1LV39X6fVYgzO+Dr290vJgbfvvukclx2H/wCEOBQ= X-Received: by 2002:a2e:9195:: with SMTP id f21mr1358078ljg.160.1615868988607; Mon, 15 Mar 2021 21:29:48 -0700 (PDT) MIME-Version: 1.0 References: <20210316041645.144249-1-arjunroy.kdev@gmail.com> In-Reply-To: From: Shakeel Butt Date: Mon, 15 Mar 2021 21:29:37 -0700 Message-ID: Subject: Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy To: Arjun Roy Cc: Arjun Roy , Andrew Morton , David Miller , netdev , Linux Kernel Mailing List , Cgroups , Linux MM , Eric Dumazet , Soheil Hassas Yeganeh , Jakub Kicinski , Michal Hocko , Johannes Weiner , Yang Shi , Roman Gushchin Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: fiztrth85ifyzcsto8zkho76hxrcjo7b X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5E7D4E0011D2 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=mail-lj1-f173.google.com; client-ip=209.85.208.173 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615868990-807543 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 15, 2021 at 9:20 PM Arjun Roy wrote: > [...] > > > > Apologies for the spam - looks like I forgot to rebase the first time > I sent this out. > > Actually, on a related note, it's not 100% clear to me whether this > patch (which in its current form, applies to net-next) should instead > be based on the mm branch - but the most recent (clean) checkout of mm > fails to build for me so net-next for now. > It is due to "mm: page-writeback: simplify memcg handling in test_clear_page_writeback()" patch in the mm tree. You would need to reintroduce the lock_page_memcg() which returns the memcg and make __unlock_page_memcg() non-static.