From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15B89C433DB for ; Thu, 18 Mar 2021 01:49:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6DD3664E83 for ; Thu, 18 Mar 2021 01:49:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DD3664E83 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B76766B006C; Wed, 17 Mar 2021 21:49:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B15B96B0070; Wed, 17 Mar 2021 21:49:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9693B6B0071; Wed, 17 Mar 2021 21:49:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 7A7816B006C for ; Wed, 17 Mar 2021 21:49:42 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 32A69180ACF6C for ; Thu, 18 Mar 2021 01:49:42 +0000 (UTC) X-FDA: 77931313362.02.683D5A4 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf01.hostedemail.com (Postfix) with ESMTP id 1761C5001526 for ; Thu, 18 Mar 2021 01:49:40 +0000 (UTC) Received: by mail-lj1-f170.google.com with SMTP id z8so5516124ljm.12 for ; Wed, 17 Mar 2021 18:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4xHmq2XoV/s1xEpGRgQqZUn6nwBJwQqPjdRmhDS6YEU=; b=fnHp91LtiDnoR2885o7D4gbA2sNsp4eRo+TdhccAdypYtx1V4uvKugJDuvuEGWXKtg uaiGeCrFH83CkSKSJNOK3ZdvVXaA0JFbNDp/3rLOf+QAFU/Cph3ZbbHfWndOkpqUb3nq ebKJ2HhvP8It6GQj5+GdzAIDhSJ3b8EQULEuvhc7XL6oxWdCWPBH5tz38eOsybIZJgX4 ldJEgqzQ+fefXiZ4Q2gpSTLWtfyq/LkIA4Gf51CSnCqZ5T7EtNCT+ZVBICI+YmXE6VnN a8lZvq5sI8wR7KUOV5zG4Hqf+myj0XbTTbPxs+zQEU0fz+9sKU+x1JTOQc6A0tCEJ3sI 5KBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4xHmq2XoV/s1xEpGRgQqZUn6nwBJwQqPjdRmhDS6YEU=; b=C88jHZJIUUUdg4bAbYgpN+wK/iV2nYEhbbmumFvbTKT4nwZMzP9cEEntvR/Z/OYpBR 3rcG1+EKzalc85GNYt0ELe6psxgBH2HL91Xa/0QxmBjR5vaJZaFyJ4x+Wphc/uN5IWd3 R4Kxs9mxNJmsxAE1KmlbOx1DbQ/AU/Df1zYx+WfCFCc3ZTqZ+uE+/FhsFdHrv5ttItYt 467y9qmGUhQvJBGlZBsNlAWByLhYwYCz4uLahzhMGEWdI0YEPNlhVLKNp0e+e6FIkEK/ MNNtuZ6mtVLFkIz7ZAyXkH7Rx6nl/wm/b2yijFCwiyxDbq7W7V4icaa140xpw6lu/1V2 Vv1Q== X-Gm-Message-State: AOAM532CXXqt+Nm8T87jVcWyWCxItGT4FxGbzuHFiXP/m3ArR+JFrGV+ 9OGTD3SI+vnRW7fKr3wq1vjYcXXRD/NWmdz4N0WRCw== X-Google-Smtp-Source: ABdhPJwtftCCbIbCpnVReoVkpBk43koVkbcrQQuH3ZjchcpdKjpdEulN08SLg/DuzhxBRN1Yct0PmJfv3CfguBFllKI= X-Received: by 2002:a2e:7d03:: with SMTP id y3mr4025907ljc.0.1616032180098; Wed, 17 Mar 2021 18:49:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Shakeel Butt Date: Wed, 17 Mar 2021 18:49:27 -0700 Message-ID: Subject: Re: [BUG -next] "memcg: charge before adding to swapcache on swapin" broken To: Minchan Kim Cc: Heiko Carstens , Andrew Morton , Roman Gushchin , Johannes Weiner , Hugh Dickins , Juergen Christ , Christian Borntraeger , Vasily Gorbik , Linux MM , Linux-Next Mailing List Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: mx6mqoe5sp1tte1hi3buerapc788ggog X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1761C5001526 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf01; identity=mailfrom; envelope-from=""; helo=mail-lj1-f170.google.com; client-ip=209.85.208.170 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616032180-477929 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 17, 2021 at 6:31 PM Minchan Kim wrote: > [...] > > > > The simplest solution I can think of is to do set_page_private(page, > > entry.val) before swap_readpage(page, true) and set_page_private(page, > > 0) after. > > Since I did't read the bug in detail, I couldn't come up with how the > missing reset is connected the problem while missing set_page_private > with entry.val is clear. This particular bug is about missing set_page_private(page, entry.val). I was wondering if we should always reset page->private or just leave it as is? I think it is safer to reset.