From: Shakeel Butt <shakeelb@google.com>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: Michal Hocko <mhocko@suse.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] mm: memcontrol: do not try to do swap when force empty
Date: Wed, 2 Jan 2019 13:45:49 -0800 [thread overview]
Message-ID: <CALvZod7X6FOMnZT48Q9Joh_nha6NMXntL3XqMDqRYFZ1ULgh=w@mail.gmail.com> (raw)
In-Reply-To: <1546459533-36247-3-git-send-email-yang.shi@linux.alibaba.com>
On Wed, Jan 2, 2019 at 12:06 PM Yang Shi <yang.shi@linux.alibaba.com> wrote:
>
> The typical usecase of force empty is to try to reclaim as much as
> possible memory before offlining a memcg. Since there should be no
> attached tasks to offlining memcg, the tasks anonymous pages would have
> already been freed or uncharged.
Anon pages can come from tmpfs files as well.
> Even though anonymous pages get
> swapped out, but they still get charged to swap space. So, it sounds
> pointless to do swap for force empty.
>
I understand that force_empty is typically used before rmdir'ing a
memcg but it might be used differently by some users. We use this
interface to test memory reclaim behavior (anon and file).
Anyways, I am not against changing the behavior, we can adapt
internally but there might be other users using this interface
differently.
thanks,
Shakeel
next prev parent reply other threads:[~2019-01-02 21:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 20:05 [RFC PATCH 0/3] mm: memcontrol: delayed " Yang Shi
2019-01-02 20:05 ` [PATCH 1/3] doc: memcontrol: fix the obsolete content about " Yang Shi
2019-01-02 21:18 ` Shakeel Butt
2019-01-02 21:18 ` Shakeel Butt
2019-01-03 10:13 ` Michal Hocko
2019-01-02 20:05 ` [PATCH 2/3] mm: memcontrol: do not try to do swap when " Yang Shi
2019-01-02 21:45 ` Shakeel Butt [this message]
2019-01-02 21:45 ` Shakeel Butt
2019-01-03 16:56 ` Yang Shi
2019-01-03 17:03 ` Shakeel Butt
2019-01-03 17:03 ` Shakeel Butt
2019-01-03 18:19 ` Yang Shi
2019-01-02 20:05 ` [PATCH 3/3] mm: memcontrol: delay force empty to css offline Yang Shi
2019-01-03 10:12 ` [RFC PATCH 0/3] mm: memcontrol: delayed force empty Michal Hocko
2019-01-03 17:33 ` Yang Shi
2019-01-03 18:13 ` Michal Hocko
2019-01-03 18:40 ` Yang Shi
2019-01-03 18:53 ` Michal Hocko
2019-01-03 19:10 ` Yang Shi
2019-01-03 19:23 ` Michal Hocko
2019-01-03 19:49 ` Yang Shi
2019-01-03 20:01 ` Michal Hocko
2019-01-04 4:15 ` Yang Shi
2019-01-04 8:55 ` Michal Hocko
2019-01-04 16:46 ` Yang Shi
2019-01-04 20:03 ` Greg Thelen
2019-01-04 20:03 ` Greg Thelen
2019-01-04 21:41 ` Yang Shi
2019-01-04 22:57 ` Yang Shi
2019-01-04 23:04 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALvZod7X6FOMnZT48Q9Joh_nha6NMXntL3XqMDqRYFZ1ULgh=w@mail.gmail.com' \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox