From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 241F6C433DB for ; Wed, 23 Dec 2020 21:01:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C4002246B for ; Wed, 23 Dec 2020 21:01:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C4002246B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C81488D004E; Wed, 23 Dec 2020 16:01:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C30D68D0026; Wed, 23 Dec 2020 16:01:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B472F8D004E; Wed, 23 Dec 2020 16:01:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9E7FA8D0026 for ; Wed, 23 Dec 2020 16:01:21 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6B679824999B for ; Wed, 23 Dec 2020 21:01:21 +0000 (UTC) X-FDA: 77625767562.14.chair28_43022af2746b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 46B3A18229835 for ; Wed, 23 Dec 2020 21:01:21 +0000 (UTC) X-HE-Tag: chair28_43022af2746b X-Filterd-Recvd-Size: 3913 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Dec 2020 21:01:20 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id m25so361580lfc.11 for ; Wed, 23 Dec 2020 13:01:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g36tAmTEjSaA0vpBKIUlCpStJerd4pisa8lbF6yxKNQ=; b=kn3BVILCed5+28QuNVyEq3hRiqw3fts33Is0SKnBnm17qBAVZ6oxU+DgC7uMmunsTH 2a8wsM30fyoKI6v9GWohnvTMO5TYWEKkVvE4s/DF3tT8r5sdLksMQxtNkyWi0AcTFDW4 hzsZELBW0HTOt7N1u6bEzGc/JOnkLsHiAVA5rj/vh/uyWPVcX86QX6MXrj/vEh+tO/wr 0sSNB2ZbmhP1LDMvMU6ZvEQDpTyGMYClmNF1sruJq5YfeMV7C8cqn0Px8HjHsQIdLbk8 5GRLH2bKy5K4w+EZF35tH6U5vIO0TqDfdYVDaxNJu/ntR7m/JgE56e2Kf41SGSmLlpc3 h6Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g36tAmTEjSaA0vpBKIUlCpStJerd4pisa8lbF6yxKNQ=; b=TVF/XJmsRfnAvTHVhhSRJYbpt/CrKRb+mN6vv2wzVjtbeZ2mjr+KuQJZYH6ghI+QWq b2X8A+b7YHAR0Rys96HY8ycKY0yJqJyV8OiEq8CZnTAtArAe4CfPbdL19RR5eQA2dUEu foj4vDdUlf2hySiEOYEjmidXfAGAzx+qvqiWf5Xd+u6tYJap0DV4Wfv73AHcKWsygN+5 eC1Khjlw0XgeJihxLlj0LtaeCC/XWjKKANDu36ad5RPnU3yL9Q5qiJfgOXQfLV66PHmg 8pniJ9xXfQxoc18al4BAn9Q/UMMt7JYa7Os7MD6IGsnI+pCpSt290j8MU/JPfIi37moa xYvg== X-Gm-Message-State: AOAM533TnftfDc+drkfcGS7sX5EADvUpOZPymI4k/rirSvhjGkrhV8vn Y4wRzD1fIJAlwNeMvft/+PZ6iZcYo3YRuMgVmGsxoQ== X-Google-Smtp-Source: ABdhPJzUj3Wj8zvd/BiNPBjip+KqSkpO464X2X8czRYKgivNp/qw7V05sLyQmik/Lb/Q79cNJkjuGGYHdZ2ec0Abdnk= X-Received: by 2002:a05:6512:687:: with SMTP id t7mr10984209lfe.432.1608757278987; Wed, 23 Dec 2020 13:01:18 -0800 (PST) MIME-Version: 1.0 References: <20201217034356.4708-1-songmuchun@bytedance.com> <20201217034356.4708-2-songmuchun@bytedance.com> In-Reply-To: <20201217034356.4708-2-songmuchun@bytedance.com> From: Shakeel Butt Date: Wed, 23 Dec 2020 13:01:07 -0800 Message-ID: Subject: Re: [PATCH v5 1/7] mm: memcontrol: fix NR_ANON_THPS accounting in charge moving To: Muchun Song Cc: Greg Kroah-Hartman , rafael@kernel.org, Alexey Dobriyan , Andrew Morton , Johannes Weiner , Michal Hocko , Vladimir Davydov , Hugh Dickins , Roman Gushchin , Sami Tolvanen , Feng Tang , Neil Brown , Joonsoo Kim , Randy Dunlap , LKML , linux-fsdevel , Linux MM , Cgroups , Michal Hocko , Pankaj Gupta Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 16, 2020 at 7:45 PM Muchun Song wrote: > > The unit of NR_ANON_THPS is HPAGE_PMD_NR already. So it should inc/dec > by one rather than nr_pages. > > Fixes: 468c398233da ("mm: memcontrol: switch to native NR_ANON_THPS counter") > Signed-off-by: Muchun Song > Acked-by: Michal Hocko > Acked-by: Johannes Weiner > Acked-by: Pankaj Gupta > Reviewed-by: Roman Gushchin Reviewed-by: Shakeel Butt