From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13C22C4167B for ; Tue, 20 Dec 2022 19:53:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E8728E0003; Tue, 20 Dec 2022 14:53:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 070638E0001; Tue, 20 Dec 2022 14:53:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2C4E8E0003; Tue, 20 Dec 2022 14:53:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CEE818E0001 for ; Tue, 20 Dec 2022 14:53:38 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A62B680CFA for ; Tue, 20 Dec 2022 19:53:38 +0000 (UTC) X-FDA: 80263734516.29.582F8F3 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf30.hostedemail.com (Postfix) with ESMTP id 0A80880005 for ; Tue, 20 Dec 2022 19:53:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=N3VO6fan; spf=pass (imf30.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671566017; a=rsa-sha256; cv=none; b=poqYa4zWk29KqHhBIkLHOJORu1xiBieaUrz/U1LEezXC22VxrLW9Hg4dZe15YMssFupRuS AdE/rqAQ+RdIfLaDAu1o/CjzOyXywcbP3sagk/fvDNQnqs5bkaw3tv7kx9dLJuiPTA0j1o G6rVweo4bDqoV3Y7qvr+Z9A8ZXuUNFs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=N3VO6fan; spf=pass (imf30.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671566017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cwnFJcsPqbI2VW6I+d19akHrm08uYcpLxkV9m2vTx7w=; b=lechMT/JKXYoN5HH82LFaZtNmRRrGExZXRyqJmG3T0geqIcwcy2A1XXLBJkPs0UwXJVIlk 7gFlCD4K4YZiSbWSnHCBN6bxH6LHOPibjvsR/KZktknFOFMLybwYgi4fAO5SZLpfME9opl I2Tnh8FUsilKnI/upOxhm5JpXh2Wlmk= Received: by mail-yb1-f169.google.com with SMTP id v126so14192355ybv.2 for ; Tue, 20 Dec 2022 11:53:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cwnFJcsPqbI2VW6I+d19akHrm08uYcpLxkV9m2vTx7w=; b=N3VO6fanbQzcFw59rJk0rVdplAN7v/iHLbeJj+WFonDxzSeTtb0ll+pVmlMqhBYsl4 SJ3CxZ0uhpHf7rNAKLG8lei3eumcjLyNQrqGRCiqT7hq7GwYWrSfWeouZaBZB7VIHQTq JC5OAOzb2isd15RQvajiIZOtGFHt1Bks++0AQdaLrIQR62gzFD7KJ8oot/Ipp773F9SN GULsheIgURn7bGYRfPlPtkgOJJczRme9Oz9FT0+AAmgw/da/hLFxyLdipTc46iWG90kJ Pt1QnGTQiaOKEL98hdGcqlDwXQwOzHToZA1GGEwc3qujLTZCso5E6yq6V2yYmAuYZIiL 7QEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cwnFJcsPqbI2VW6I+d19akHrm08uYcpLxkV9m2vTx7w=; b=W8kxY0xZtfXAoXcxK7Kwx6IEhY2lxjcdV46yOmCKTHr4p4b8cHvUkqW5Md2CD2l9gX LZjjK0RXclztVrQ/gMQhzLLNKAnZQAZt8fKj8Q8GdvtiEFG6VYTzwZ+/TgxOqxsfLuBT MkIquAeEn084F1xby3JarmtYDx1UqjIoM/nYp75FtWdlhikfzyezcF+GEzbss7UM8F/y lrL9OwWhmV6VLOegrRJQNAYF46cXSd6oT8we1ulQN9mNp6pADxSD6tHzzJXC6RGfOvgG U/pMaxo5v1F1h+w2TGxisoHnl/js9NSb2ld3HFR1NYWjYP4iXJJMN8B3Xv/biZ5TtQ+w TmiA== X-Gm-Message-State: AFqh2krmKx24D+VNklEnMEbONeixT/k4mwfznIel3wx22cybqC/EGDkX c6VfeUyti2JeFdmYgLmuEO0mKf842wBdO1rpNtQsaA== X-Google-Smtp-Source: AMrXdXten50mZXwWCtKExqPt0K7Es831NSWlVxmiQDT2EWU7O5xHDwK71SO8HCl1Op7eIvZmf0R5iZOgwen/jai4Qgs= X-Received: by 2002:a25:9847:0:b0:733:af24:fe57 with SMTP id k7-20020a259847000000b00733af24fe57mr1508197ybo.228.1671566016054; Tue, 20 Dec 2022 11:53:36 -0800 (PST) MIME-Version: 1.0 References: <20221220184813.1908318-1-roman.gushchin@linux.dev> In-Reply-To: <20221220184813.1908318-1-roman.gushchin@linux.dev> From: Shakeel Butt Date: Tue, 20 Dec 2022 11:53:25 -0800 Message-ID: Subject: Re: [PATCH RFC] ipc/mqueue: introduce msg cache To: Roman Gushchin , Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song , Andrew Morton , Waiman Long , Sven Luther Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 0A80880005 X-Rspamd-Server: rspam01 X-Stat-Signature: edrtsuygru89eor9o1x57d34ekouy5i3 X-HE-Tag: 1671566016-150377 X-HE-Meta: U2FsdGVkX1+mWB/fbg8VhsTeMjHMmYdMP7C8Q6J5GYXYON8enCj6V7ava8DEnmTYeEv28/KMN9pGdubxyFJ5+VANO4g+ZpShFIF/NQrrmcB1Bzgp5/PPRupn9HvC20bSEFc5f+2rKq+YqRtoxOib4XnTQ3pR+Ba+pOc34hkFQ6Kj+j+o80rTMCaRpI2gqpVtF7Yj7wZJN5k5dE81Kk49dhIoe5NeFL+iAxOR6lnQg3/rNr6BlvYGTEM8iEO31r2S5QufAkKvUg5Dpun/b6VGmJDfSKVnxTAFxKsHhbS7xtlwm5O7+ruJ7SBKS5KFmu7cgSkmg7a8zXauY8J+JIP4vuqscZpH7O9aMDJWCe9kZrcTdBIyL/f4ch0/+q6VCn8a/oHyV+DiXpTeWT4feAF3B689E2KSOE63mOv8F5wxvH6C1fWfW/ZfIa9Cajp1nS8EYqarscawJgaPPLTE8ip7sdHNM6lYE0E7PYU/GIBu56TFL1TNcZCxbhItEmASVWqh+3z3mWe+nEqxxhGoQYE+aR1iX2H9NqB/HuVj76YQQOSLjby6pmIis/tYaGFh14ZL7FJUteWUflrGURlyIpGiHi2aLs4uAsA/1OW3E7Zr6hdpAU0oSmLSC+viczRA0ddzOlXPbe7fBYxzFKr9EhiBtntvgA2b4V2R+9aeiWg1csBuuQ1DjVpeIv11D35wtIhtWtI5HefM/boQ+1oI2bCvfBrj/ZrLtXFi00Dne1/OxZ5/kzwCJL033L2yqJo7cXafn1Fs4/TQ4NabLvkO/p9CII+l4snQPF5mQGTqE09AzSmY0ko6zPGH07nAUrLGqwG+cbIvkKKz3WDoUn9Uz89i5K7JveLfFADb4gv0fdN2/+riukKYab6V8MThJfji/+BYi0df4fQtVLLzX2G36SJy0lydXuYq3aK9M/qh0h2PsSuqMtYopQt8W8hBYWneBSF3b81bRfsjQf8CbVpEVf0 OlGAfWfS vX0c8gTXD9iuqNk4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: +Vlastimil On Tue, Dec 20, 2022 at 10:48 AM Roman Gushchin wrote: > > Sven Luther reported a regression in the posix message queues > performance caused by switching to the per-object tracking of > slab objects introduced by patch series ending with the > commit 10befea91b61 ("mm: memcg/slab: use a single set of kmem_caches for all > allocations"). > > To mitigate the regression cache allocated mqueue messages on a small > percpu cache instead of releasing and re-allocating them every time. > Seems fine with me but I am wondering what is stopping us to do this caching in the slab layer for all accounted allocations? Does this only make sense for specific scenarios/use-cases?