From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C306FC38142 for ; Tue, 31 Jan 2023 18:27:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FCD16B0071; Tue, 31 Jan 2023 13:27:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0863A6B0072; Tue, 31 Jan 2023 13:27:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E41C16B0074; Tue, 31 Jan 2023 13:27:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D15646B0071 for ; Tue, 31 Jan 2023 13:27:05 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9D57B40C90 for ; Tue, 31 Jan 2023 18:27:05 +0000 (UTC) X-FDA: 80415926010.13.511A99F Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf26.hostedemail.com (Postfix) with ESMTP id E88DC14000F for ; Tue, 31 Jan 2023 18:27:03 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=tQEMNZ1+; spf=pass (imf26.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675189623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HkHNPqnVxAIY/tqIt7qZnRTR4WfHWVZtazfgEEVLA1k=; b=tsliufDmY+pszxz654J1zFIflWn+b9k5h2BK9X3l+G1lk4Wh1R3izNZ9GLitEEMSJ2TYeg u6OXZvXuBGa8q5NzmNndk+nTt3GDm5uUMpHZKrXqTo5SUoxfNAUGfFlnghqP3rrpDG2aD5 //dkM4veH+O9yJDsjPHBeHoFWNP3boM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=tQEMNZ1+; spf=pass (imf26.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675189624; a=rsa-sha256; cv=none; b=QneLbzJPlGcLbXniHV08WkO4ysv9NjZXB3KUsR3sAjjUBHSwASRpAKX3LRchfBs9OlxJzi t/PkEqqD0pzbJj4+WOz7ABtpLX3mYp0k13Qeg2Mdus+Saq2Sdt8QgJEqxZkWYBL0WvhlR/ V988m+mENW5oPGBu9Hnw24ucJvnoRUg= Received: by mail-yb1-f169.google.com with SMTP id 129so19327571ybb.0 for ; Tue, 31 Jan 2023 10:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HkHNPqnVxAIY/tqIt7qZnRTR4WfHWVZtazfgEEVLA1k=; b=tQEMNZ1+yeDZEj71B07fcjB50jM1i6aOuywWS/FEjrOnp3EcR69hAad3lu7vZn711m rWFCK+MRQGo98+OX7Z5YJLQhXxWxcbseEzjAKbTV3mnOpdwwmNbpFwvbdi+eNLV/KuMk sNXJc8FHml2fwt05JkbGF5OXq5QschNyjjqDrAvpuG6zFZbmRhPSLQnUptA+sed4s+4u /ShnkTt4PmvgX5jmo1mCcs2pWa08grni3e3ApLv3uhCKCxfacTcGLbncAhJRnWaiVYSm tdI+8rQTbvf6cG+WE0yUEx2Rdr8MDao7T3rRNVqVLCHHtQydcDhp9f9RmGWkoukyc4Oq rcuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HkHNPqnVxAIY/tqIt7qZnRTR4WfHWVZtazfgEEVLA1k=; b=21ND+Vm01DEnZ8JEwMiV2TLxOZnsSLrxlNBLKbfjc0oEH3ku8BJT/CKOYSAgYqArbN RtzaTO3mH+M2Sujv16ZpONh4DMHhpm7Q0oOYv6Kf0N66OEBQLZ+obm9FyNyMgmQu2aSn dd6lkkvHpzVD+jB1ztOXgCaFPqdGRcEqKcjLSSpYdyduBrxzwCD5U0mcPGRaHF/413uz yXd5gKJq+1rDAf1qpYeB1I6z6yOdP9vV9OJOvimjZFkPPLbFzmwG025TWbRlYVEUCd9x 4GB1LLZjq3E5HLeb12AYmruXE/6x5idgMpzlWAsk5TcT6+zuVhVPkpCAszPl8YD2NkhW Ud4A== X-Gm-Message-State: AO0yUKUHxQ3AK6GijeeCqoCx+AaDOWcOKsmDed6/FfL+ql8gmZaz98XU IedzHwCn4oAar5a4mQqqjXqv48kdFOUyBd+w4CefqA== X-Google-Smtp-Source: AK7set9Wi/SxOYBU/ud8H+po+UJzdx1g7/5fVkPjA4w3dbgGjnozI/UIgrAp4ux9zJMjoCX+yuiExNDq7TyEEr9b0cI= X-Received: by 2002:a25:bfc4:0:b0:80b:877c:7a56 with SMTP id q4-20020a25bfc4000000b0080b877c7a56mr2044611ybm.368.1675189622981; Tue, 31 Jan 2023 10:27:02 -0800 (PST) MIME-Version: 1.0 References: <202301301057.e55dad5b-oliver.sang@intel.com> <20230131052352.5qnqegzwmt7akk7t@google.com> <20230131055743.tsilxx5vfl6gx4dj@google.com> In-Reply-To: <20230131055743.tsilxx5vfl6gx4dj@google.com> From: Shakeel Butt Date: Tue, 31 Jan 2023 10:26:52 -0800 Message-ID: Subject: Re: [linus:master] [mm] f1a7941243: unixbench.score -19.2% regression To: Matthew Wilcox , Tejun Heo , Dennis Zhou Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Marek Szyprowski , linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, zhengjun.xing@linux.intel.com, fengwei.yin@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E88DC14000F X-Stat-Signature: rxoxrprstokyozfn47whcguuaknn1taz X-Rspam-User: X-HE-Tag: 1675189623-230185 X-HE-Meta: U2FsdGVkX18oMi2wtF8DPaPh3W8LGcjKxDqphY9lYyZ9RmrzWZNwn/IjRvZWoSo4iGQA/rZi4jGSeuIJ0Q7FXCS3f/R3gKGo+dTUJo9xfJKpI68ykZqeuCJaj7ho6k6F1FmjZ5LG8wY6J+xotS4Ko+4w072LcR8kvKLQTzxjT/bfyRH352HztuaPt09cLeIpPPfTR8gtjVmFIy7sn91BNWK2m6CgnylBcM5t2gQFXffwxcdX2XYtOgnONATZVni3JX34xEDII3a3p2Qfxh3djx0wEyUoZMymkJtRPqJJHtDXd8OkWHQVom75/untuxtkQYJK1h8oZUtuUGAp786PwR/jJZGT53ojhCVszpzlchedR7mhcGE73SS7/eL349aDlGBw8fsf9ev+9dxBfR81+RipccCWTwFsw/Fs8YIy5zBHBWRc6DTJkBzmVCxUv8vuC+A4VFboorBEBUkxjwflKpRvcAYIwAeCZzM3GIKseciBvzmy737IR2bI72xNNS+BtNfEqtPDlDGvknqoXnmh1unVxZmsFgXFjpFCEsVmxUwCkHfzi3h3Rlud1EqdJHls2h3Tz0peSZleemhxgjAnm2W3XhqXqjOYHoE200iIj/2X+E1Rvxylgtk+h6vAbQCgX/WOEk2NwAKI6wFLaOHDTKKywURCZ4ed3RV6gS3nyejyFveg6mKfd1Yc7yIPqcf56YbaEYJQx9ZbMNGjWG0jONCRtYWL/BbOaljrsuH2Zelfllz3p4iqkCXaWnpjlTUW4RiBv0Tj18DUhfLjoGi5BQ2qbKUYMUhBx3SGB/FlcjvcLsO++yhRrQxX74K9uWyFVTQ4PFdu+7TwhujbrpvCGCK1QdRAoRHP87zi47+cKup3XZ/GszoWW5gCZXVT/2/06HAXoLYzTA+e2ZJj9rF+okmlj1P5ezsU5aH+oiNRISkDRk5VbSc8AlC4hHQuJuAhZyePV9Z0effrwrF42oh tkrWYA+n HCgX2S92Ky9PsNMwQ02js/vp8aP3wodye17EOCKHP1EC5Vk7pR0oyCVpPbIZJlRUflIrwYtylRYm1cCQyxn7w8uqRcAQg2Zq1mTs49IU9Sd7mG3BGSQTsMeOIF/63Wb8jbOYeydZ1eyA5CG0Tnf/LLDf7jN++E0pSUhSkWfjcpRAgEk+i9ecS33iM0rN2SVIgT0W44jjnoPU62RGK03tVgCoMARmzVygKfby2Tj9TqvMbEL5j5GbAQwXPf3HFceVGtuicmAL8hq0hN+M6UfaUF2btpd19ucFiND0ydA9EhcWK5MMVI+J64h7PDT5TuoV0XJjnEZ+2nP6uQppQpHk2v4Bw7owCLhzqnKG4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: +per-cpu memory maintainers for FYI. Thread started at https://lore.kernel.org/linux-mm/202301301057.e55dad5b-oliver.sang@intel.com/ On Mon, Jan 30, 2023 at 9:57 PM Shakeel Butt wrote: > [...] > > > > We could cut down the number of calls to pcpu_alloc() by a factor of 4 > > by having a pcpu_alloc_bulk() that would allocate all four RSS counters > > at once. > > > > Just throwing out ideas ... > > Thanks, I will take a stab at pcpu_alloc_bulk() and will share the > result tomorrow. > OK, not a one day effort. Andrew, which option do you prefer? 1. Keep the patches as the test workload (fork ping pong) is not a representative of real world workload and work on improving pcpu_alloc() for 6.4+. 2. Revert the patches for now, improve pcpu_alloc() and re-introduce the patches once we confirm that fork-ping-pong is not regressed anymore. thanks, Shakeel