From: Shakeel Butt <shakeelb@google.com>
To: Matthew Wilcox <willy@infradead.org>, Tejun Heo <tj@kernel.org>,
Dennis Zhou <dennis@kernel.org>
Cc: kernel test robot <oliver.sang@intel.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org,
ying.huang@intel.com, feng.tang@intel.com,
zhengjun.xing@linux.intel.com, fengwei.yin@intel.com
Subject: Re: [linus:master] [mm] f1a7941243: unixbench.score -19.2% regression
Date: Tue, 31 Jan 2023 10:26:52 -0800 [thread overview]
Message-ID: <CALvZod7TuaJ7pCc2nJKehwGkcuvsvjdL+4hs6qC3bZsOmGzXzg@mail.gmail.com> (raw)
In-Reply-To: <20230131055743.tsilxx5vfl6gx4dj@google.com>
+per-cpu memory maintainers for FYI.
Thread started at
https://lore.kernel.org/linux-mm/202301301057.e55dad5b-oliver.sang@intel.com/
On Mon, Jan 30, 2023 at 9:57 PM Shakeel Butt <shakeelb@google.com> wrote:
>
[...]
> >
> > We could cut down the number of calls to pcpu_alloc() by a factor of 4
> > by having a pcpu_alloc_bulk() that would allocate all four RSS counters
> > at once.
> >
> > Just throwing out ideas ...
>
> Thanks, I will take a stab at pcpu_alloc_bulk() and will share the
> result tomorrow.
>
OK, not a one day effort.
Andrew, which option do you prefer?
1. Keep the patches as the test workload (fork ping pong) is not a
representative of real world workload and work on improving
pcpu_alloc() for 6.4+.
2. Revert the patches for now, improve pcpu_alloc() and re-introduce
the patches once we confirm that fork-ping-pong is not regressed
anymore.
thanks,
Shakeel
next prev parent reply other threads:[~2023-01-31 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 2:32 kernel test robot
2023-01-30 4:15 ` Matthew Wilcox
2023-01-31 5:23 ` Shakeel Butt
2023-01-31 5:45 ` Matthew Wilcox
2023-01-31 5:57 ` Shakeel Butt
2023-01-31 18:26 ` Shakeel Butt [this message]
2023-02-27 6:35 ` Yin, Fengwei
2023-02-27 16:50 ` Shakeel Butt
2023-02-28 0:32 ` Yin, Fengwei
2023-01-31 6:11 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod7TuaJ7pCc2nJKehwGkcuvsvjdL+4hs6qC3bZsOmGzXzg@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=dennis@kernel.org \
--cc=feng.tang@intel.com \
--cc=fengwei.yin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=m.szyprowski@samsung.com \
--cc=oe-lkp@lists.linux.dev \
--cc=oliver.sang@intel.com \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox