From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6116FC388F7 for ; Thu, 22 Oct 2020 16:51:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B53AF2463F for ; Thu, 22 Oct 2020 16:51:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LrjBvKpu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B53AF2463F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 32CC76B006E; Thu, 22 Oct 2020 12:51:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 304756B0070; Thu, 22 Oct 2020 12:51:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 241036B0071; Thu, 22 Oct 2020 12:51:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id ECF8A6B006E for ; Thu, 22 Oct 2020 12:51:14 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 924228B490FF for ; Thu, 22 Oct 2020 16:51:14 +0000 (UTC) X-FDA: 77400151668.19.move97_0015e6527252 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 6A2831AD1A3 for ; Thu, 22 Oct 2020 16:51:14 +0000 (UTC) X-HE-Tag: move97_0015e6527252 X-Filterd-Recvd-Size: 3389 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Thu, 22 Oct 2020 16:51:13 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id l2so3136267lfk.0 for ; Thu, 22 Oct 2020 09:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xd+wFurjGt8mIia5D9RdI7kEY/qSyqqqpi8eDO7fd4U=; b=LrjBvKpulM/XMhJARW83BKyF12g1Mqfl10AXRgIMcG9LM7S6kcl4R6MlFwlFkEA/1a d/KzVeD+H36kd9k/4RiTQHrYtLgqMyf+qBYv/N8Ex//ESFw0YXOyN4StOv1ukEWWqeQr hyGdvREaI2zbnlt9ny7p45Sad/Gd/FFkejzXvXodXkc/tufjFz7F4cjPQcROrIrimbjt LDcWSPR2XQzbiqwiz3VAllqfZ39xfPGZTzfanQ2bJ2679ENBpGehMgtEagxaUfdusjuu Lz0bsQ5wNKlvGwK2a5JbDUGAVjzXcEQHfzg7+ZdDyW2WOdOAoN5ovZXyr1aABAUXxX9U T/Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xd+wFurjGt8mIia5D9RdI7kEY/qSyqqqpi8eDO7fd4U=; b=MsTGNzJ9Abam50jjdjFkLb+vJR1JamgseokKj025iC5z3exCZV0vBiFA2u6yDWkifH Ksz7TRtomH56Cc6EfhSSWo8b2HQjVYqCH721c36wo7h2atsFHjjUcFjxPYBb2cCQD93a 66dw1BEv3knWIz6fdexAXgopQGrwsRpAq0PHdRzTtPMyA8k6irQGs1axD7ENFL/tG5u4 44NshtveNfBHPuH/ggZPY5Dh6ulLRIVqlp7A7Gur0FClTnO0a9IPWT0Bf+NePXKTo8YB 2ykgFxZ0UTj5P0izuNaLb45id1ehV7XSzqy35ny+f+AMZjqqBqxpDaPRiyCTAAVIB/+B wt5Q== X-Gm-Message-State: AOAM532NbvpntFZ0SJ+E1oVpZCkbbTllhZ5c+UqykTabc+uy/spNrTK9 +gKONdteT0+lxIJA+ffpR9PqU3QMpF+gpBueCU0dqw== X-Google-Smtp-Source: ABdhPJzgbjVJ6Q48WyyWENn3/RiEAe7m2DvqcU64UZBUNM7R05PvMjOPYcsfbg596U8Of0MqHkurd7hguMBbdaqIN80= X-Received: by 2002:a19:84d3:: with SMTP id g202mr1289904lfd.346.1603385472165; Thu, 22 Oct 2020 09:51:12 -0700 (PDT) MIME-Version: 1.0 References: <20201022151844.489337-1-hannes@cmpxchg.org> In-Reply-To: <20201022151844.489337-1-hannes@cmpxchg.org> From: Shakeel Butt Date: Thu, 22 Oct 2020 09:51:01 -0700 Message-ID: Subject: Re: [PATCH] mm: memcontrol: add file_thp, shmem_thp to memory.stat To: Johannes Weiner Cc: Andrew Morton , Michal Hocko , Linux MM , Cgroups , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000193, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 22, 2020 at 8:20 AM Johannes Weiner wrote: > > As huge page usage in the page cache and for shmem files proliferates > in our production environment, the performance monitoring team has > asked for per-cgroup stats on those pages. > > We already track and export anon_thp per cgroup. We already track file > THP and shmem THP per node, so making them per-cgroup is only a matter > of switching from node to lruvec counters. All callsites are in places > where the pages are charged and locked, so page->memcg is stable. > > Signed-off-by: Johannes Weiner Reviewed-by: Shakeel Butt