From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5487EC28B2B for ; Fri, 19 Aug 2022 17:09:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B52CC8D0003; Fri, 19 Aug 2022 13:09:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B01868D0002; Fri, 19 Aug 2022 13:09:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C8BE8D0003; Fri, 19 Aug 2022 13:09:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8CE528D0002 for ; Fri, 19 Aug 2022 13:09:12 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6AECBAC732 for ; Fri, 19 Aug 2022 17:09:12 +0000 (UTC) X-FDA: 79816977744.24.28963E8 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf03.hostedemail.com (Postfix) with ESMTP id 1CDE620005 for ; Fri, 19 Aug 2022 17:09:11 +0000 (UTC) Received: by mail-pg1-f178.google.com with SMTP id s206so4167734pgs.3 for ; Fri, 19 Aug 2022 10:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=9tclK/v9g50KwV+RLBZQMeHODjCGNk5Pk0kzAABIBN4=; b=SVUHc0QVIE7RwsM5tECaG+ih+zr0KA2/p4V2kDsO+fKZzFpSkLcK7ni5sebA18KMa7 LF32TyIIkLMiWoAyP7mOKXdDveWyTioev61RmCh2dJ9tm/bIbyIy3BmAWHKIy+cRCANY jeFS66lDeohKToWNEqjUJc7FegMW5N/BeHtbz33h/7ARPr4W4QF2loU8kebWe1GgCdBv vFvSwvh3wpb20YoxbdoSuJx4F4DBmsVN6xQwKK1DBMYHMIPUr4SJRVCBDmtpSBJ5qn6x 1qLMqYfqyHIZb8OoX4Gv6TpFYcHKr4D1oudJJV/17juQUTWSIE+cK9rLIdXTPf9pwQs7 f7dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=9tclK/v9g50KwV+RLBZQMeHODjCGNk5Pk0kzAABIBN4=; b=wvdzpDWsaGbj8UmFlLgVLg5Sw7sJpb8zuTuUkRv6gjuRDEg/SaViWqfLfOXll/g4zg 4yC4+omL3EtoxVIetjdUfdBI/in3EjbXrKs4EUivbWd0isg3q9F/WJF4c78fxS9gf8VL 7qdTDtKKbsdgYsFWJCRKbLZyJmqUZFF0tqo+pykF5uhUBT2cMQHJcWKiZTvuu99cC9i8 MEp4uaWVJkJjMIuy5tejKJpgNUzCme8jUyjSJdiLzLGm7J84Izn3rbZItKzwSMB18hxn zBoB1g8ctLjNpHpaMR1ykkCi5lq6BSSxWUsljLxyEJ6JzDAqhZVZMrT2vVoWb5QFRSCX htiA== X-Gm-Message-State: ACgBeo3+e1ovC4GEF96m8qxm2c8N7q8GdTkUZVXYUI0mBTK6mnOKsuE9 x4nNNK4LwosFfPcY6c0m2gODlpSqhkFAz0pPylAwmA== X-Google-Smtp-Source: AA6agR4r6nOr7e7UHjQKukfhDciN5qxxdsKDLpTaOyGNSooGQW2n6IZHFTj/AwKK7s6dobuh/iNS4vy52dqr29ga0As= X-Received: by 2002:a62:6497:0:b0:52e:e0cd:1963 with SMTP id y145-20020a626497000000b0052ee0cd1963mr8818122pfb.58.1660928950562; Fri, 19 Aug 2022 10:09:10 -0700 (PDT) MIME-Version: 1.0 References: <1660908562-17409-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: From: Shakeel Butt Date: Fri, 19 Aug 2022 10:08:59 -0700 Message-ID: Subject: Re: [RFC PATCH] memcg: use root_mem_cgroup when css is inherited To: Tejun Heo Cc: "zhaoyang.huang" , Johannes Weiner , Michal Hocko , Zhaoyang Huang , Linux MM , LKML , Cgroups , ke.wang@unisoc.com, Zefan Li , Roman Gushchin , Muchun Song Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660928952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9tclK/v9g50KwV+RLBZQMeHODjCGNk5Pk0kzAABIBN4=; b=u9Bv03Ks6EXMfyi0tHMjqz6s/X3il4rAgHxluuwAcMhOICidJq7w8y3csnIAwqXnweyubf wFbZMf5eupFDqBfjpJCrlXED/6PtXxJ3a7nxvXGfTHYxhms+duQPR1V4x/qAdr8RZSwSsB 1x1/lRvGRiRNFnalH0eoPN/Tjgdv/dg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SVUHc0QV; spf=pass (imf03.hostedemail.com: domain of shakeelb@google.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660928952; a=rsa-sha256; cv=none; b=JI2TXtRKXdpk9HV0mo8n8zsfMPrCr5DWTrjpLHf3vZB4Bci7YsWYvl7fTjcqFoltBaSoJE z1v5DGsn8RiXkt/zl/TXAWch6SQx1fLgz7WA2aZCHbCjWhKl8IUursiQ0pTtuSTAqfrCRp I9QX1prjp7/Y7j4r4XsUAjO85T2lbUo= X-Rspam-User: X-Rspamd-Queue-Id: 1CDE620005 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=SVUHc0QV; spf=pass (imf03.hostedemail.com: domain of shakeelb@google.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: uay6mwjw3bbuwtikep8i4pei17bp9hok X-Rspamd-Server: rspam10 X-HE-Tag: 1660928951-24809 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000500, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 19, 2022 at 9:29 AM Tejun Heo wrote: > > On Fri, Aug 19, 2022 at 07:29:22PM +0800, zhaoyang.huang wrote: > > From: Zhaoyang Huang > > > > It is observed in android system where per-app cgroup is demanded by freezer > > subsys and part of groups require memory control. The hierarchy could be simplized > > as bellowing where memory charged on group B abserved while we only want have > > group E's memory be controlled and B's descendants compete freely for memory. > > This should be the consequences of unified hierarchy. > > Under this scenario, less efficient memory reclaim is observed when comparing > > with no memory control. It is believed that multi LRU scanning introduces some > > of the overhead. Furthermore, page thrashing is also heavier than global LRU > > which could be the consequences of partial failure of WORKINGSET mechanism as > > LRU is too short to protect the active pages. > > > > A(subtree_control = memory) - B(subtree_control = NULL) - C() > > \ D() > > - E(subtree_control = memory) - F() > > \ G() > > > > Signed-off-by: Zhaoyang Huang > > Just in case it wasn't clear. > > Nacked-by: Tejun Heo > > Thanks. > Was there a previous discussion on this? The commit message is unreadable.