From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A3CBC433EF for ; Tue, 19 Oct 2021 20:03:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DAC0C611EF for ; Tue, 19 Oct 2021 20:03:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DAC0C611EF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 592D86B006C; Tue, 19 Oct 2021 16:03:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 544D06B0071; Tue, 19 Oct 2021 16:03:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 431B6900002; Tue, 19 Oct 2021 16:03:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 368DA6B006C for ; Tue, 19 Oct 2021 16:03:46 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D438C18091B68 for ; Tue, 19 Oct 2021 20:03:45 +0000 (UTC) X-FDA: 78714262410.13.705854F Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf27.hostedemail.com (Postfix) with ESMTP id 4497870000AD for ; Tue, 19 Oct 2021 20:03:44 +0000 (UTC) Received: by mail-lj1-f178.google.com with SMTP id l5so8237217lja.13 for ; Tue, 19 Oct 2021 13:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DfGhAHT9HhtqeTpI2TYryH6uFTCkzU6q0SGRJXp8/6w=; b=gCRm1I8UHyDh7Mi8CTU+K3MIul4qxwvNzh0Ij1H6xm95MW00t7BiwXquwR0X7cgHwj ArlZ0SIMAiyoiWadSJTfCevxdOFU84GJu+4mFCD3CSATO/QwyMDx/UJy35eBz9r7qzft QuGRgjjA4D9Dq69peRhx0vqHfiIGricAiY1wmqvS9F5zKst3bh3NzKlkt4dDmPZ0TT3I j9bsZL1/TnO5QKdZcJ8SdlN4xT3yvpSGbw3FXc6ypi5maL3g4PBHM220xi+XS0bYuzaL +qqGzod2mROnt/MeAxtoA895HOcPk7PqDA8Td3He8iv4+glZAzLW2Ena2Is1cvXFZmWt 7BZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DfGhAHT9HhtqeTpI2TYryH6uFTCkzU6q0SGRJXp8/6w=; b=OFyc9d+qnlbBJ4mqJ83c4gai8f0ScVyIcnVeWaWf+H+MMO9iLaSkr8g8sA/ar1M8X7 TXDEMnXnumpjq16G/n9jC5CCQ+oSCsJRl8M3aMfI3bK8/OsxH8rIJzaa0XZRUqaOG6/c OK6maFsPALaPQaEDnRGkztbO/xinmZso16sCeM024PXem2HJCXuQ6JuzAGwc1dNBiB4o Coj9EIwuFbp68FzwMstx7JO5d3miluUviGY6ysaHSjOoEszV1dL3AVb11VKhMZ1c3JZd h5LZRn0QyxCEjMfSL11HAl8NRyhLYWgrVI5NWRuqWmDNBZM0gjig97uxuBUH9G+AQpmB gxjA== X-Gm-Message-State: AOAM531BE7JLOOk3OObt1gt3s/AK43uKDDTJmI2eWu/iJC4ThEbbQom4 49EpgkMdWLQmupxxI4UtzPyJCKMtNI39wW1iCFS3mg== X-Google-Smtp-Source: ABdhPJzd3sf9ZX+bEMFP3ZIWLmMCxMegHItpioGJBTww8iDfLZtbroMLSbgbN9AmLjemI+SHFKSwrT2Bf6BlAifbDEg= X-Received: by 2002:a05:651c:1793:: with SMTP id bn19mr8820477ljb.475.1634673823685; Tue, 19 Oct 2021 13:03:43 -0700 (PDT) MIME-Version: 1.0 References: <20211019153408.2916808-1-shakeelb@google.com> <20211019125147.0ad010f318bbd8233cadcdae@linux-foundation.org> In-Reply-To: <20211019125147.0ad010f318bbd8233cadcdae@linux-foundation.org> From: Shakeel Butt Date: Tue, 19 Oct 2021 13:03:32 -0700 Message-ID: Subject: Re: [PATCH v3] memcg, kmem: further deprecate kmem.limit_in_bytes To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Vasily Averin , Roman Gushchin , Cgroups , Linux MM , LKML , Michal Hocko , Muchun Song Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4497870000AD X-Stat-Signature: oit89jq838oxk6uga73jbh9th1fj54sq Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=gCRm1I8U; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=shakeelb@google.com X-HE-Tag: 1634673824-542983 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 19, 2021 at 12:51 PM Andrew Morton wrote: > > On Tue, 19 Oct 2021 08:34:08 -0700 Shakeel Butt wrote: > > > The deprecation process of kmem.limit_in_bytes started with the commit > > 0158115f702 ("memcg, kmem: deprecate kmem.limit_in_bytes") which also > > explains in detail the motivation behind the deprecation. To summarize, > > it is the unexpected behavior on hitting the kmem limit. This patch > > moves the deprecation process to the next stage by disallowing to set > > the kmem limit. In future we might just remove the kmem.limit_in_bytes > > file completely. > > > > ... > > > > @@ -3791,10 +3766,8 @@ static ssize_t mem_cgroup_write(struct kernfs_open_file *of, > > ret = mem_cgroup_resize_max(memcg, nr_pages, true); > > break; > > case _KMEM: > > - pr_warn_once("kmem.limit_in_bytes is deprecated and will be removed. " > > - "Please report your usecase to linux-mm@kvack.org if you " > > - "depend on this functionality.\n"); > > - ret = memcg_update_kmem_max(memcg, nr_pages); > > + /* kmem.limit_in_bytes is deprecated. */ > > + ret = -ENOTSUPP; > > break; > > case _TCP: > > ret = memcg_update_tcp_max(memcg, nr_pages); > > checkpatch said "ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP"? I should have run checkpatch and Andrew, please replace ENOTSUPP with EOPNOTSUPP. Thanks for catching this.