From: Shakeel Butt <shakeelb@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vasily Averin <vvs@virtuozzo.com>, Roman Gushchin <guro@fb.com>,
Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.com>,
Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v3] memcg, kmem: further deprecate kmem.limit_in_bytes
Date: Tue, 19 Oct 2021 13:03:32 -0700 [thread overview]
Message-ID: <CALvZod7QPR1Zz3XcN1CJvm_DuWomoR7MrS7uEyCBHNMX5c8AiQ@mail.gmail.com> (raw)
In-Reply-To: <20211019125147.0ad010f318bbd8233cadcdae@linux-foundation.org>
On Tue, Oct 19, 2021 at 12:51 PM Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> On Tue, 19 Oct 2021 08:34:08 -0700 Shakeel Butt <shakeelb@google.com> wrote:
>
> > The deprecation process of kmem.limit_in_bytes started with the commit
> > 0158115f702 ("memcg, kmem: deprecate kmem.limit_in_bytes") which also
> > explains in detail the motivation behind the deprecation. To summarize,
> > it is the unexpected behavior on hitting the kmem limit. This patch
> > moves the deprecation process to the next stage by disallowing to set
> > the kmem limit. In future we might just remove the kmem.limit_in_bytes
> > file completely.
> >
> > ...
> >
> > @@ -3791,10 +3766,8 @@ static ssize_t mem_cgroup_write(struct kernfs_open_file *of,
> > ret = mem_cgroup_resize_max(memcg, nr_pages, true);
> > break;
> > case _KMEM:
> > - pr_warn_once("kmem.limit_in_bytes is deprecated and will be removed. "
> > - "Please report your usecase to linux-mm@kvack.org if you "
> > - "depend on this functionality.\n");
> > - ret = memcg_update_kmem_max(memcg, nr_pages);
> > + /* kmem.limit_in_bytes is deprecated. */
> > + ret = -ENOTSUPP;
> > break;
> > case _TCP:
> > ret = memcg_update_tcp_max(memcg, nr_pages);
>
> checkpatch said "ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP"?
I should have run checkpatch and Andrew, please replace ENOTSUPP with
EOPNOTSUPP. Thanks for catching this.
prev parent reply other threads:[~2021-10-19 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 15:34 Shakeel Butt
2021-10-19 19:51 ` Andrew Morton
2021-10-19 20:03 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod7QPR1Zz3XcN1CJvm_DuWomoR7MrS7uEyCBHNMX5c8AiQ@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=songmuchun@bytedance.com \
--cc=vvs@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox