From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FEADC433F5 for ; Fri, 18 Feb 2022 18:40:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFAD56B0074; Fri, 18 Feb 2022 13:40:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DA9B56B0075; Fri, 18 Feb 2022 13:40:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4AFF6B0078; Fri, 18 Feb 2022 13:40:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id B12C56B0074 for ; Fri, 18 Feb 2022 13:40:15 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6DBCE181843CD for ; Fri, 18 Feb 2022 18:40:15 +0000 (UTC) X-FDA: 79156765590.08.A178C8E Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf03.hostedemail.com (Postfix) with ESMTP id 123C320005 for ; Fri, 18 Feb 2022 18:40:14 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id b11so7033313lfb.12 for ; Fri, 18 Feb 2022 10:40:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JG7CBAmO1pjbLUUkaVNCRR+CekFRKgJLo0xYPxAI1lw=; b=P/EPFiUa21gKmNj7gaOV4hyboq1mh+5Kwu1Zzsh/B+dv3dHVY/RAViisL/ZO3ek6yK QDakcXkEH72XrDe7zvdXxjOijB4CbhWy4rm+hFVdoaJGMxDEZsXAKE4h1RVoW5QNmzUx xWKNe3jLE5H0KVn7YdrxL5nDSOAeAc9HS5/+QnUU85/JFkQz4WD4wUJbV55sdOYrb/Fn kRX1jgJNzMVN1nygaY40Y4N6V5OqaRnKM8myWEhGQZSvP4ZejRmOWnIzB6LCwPihIEPY w/mgMpYfQAkrK+ebvEaBYKIsG/66BdH7WrBc8sr9OtPhTJybesZ8RAnqOTLP01OM4dr8 fl5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JG7CBAmO1pjbLUUkaVNCRR+CekFRKgJLo0xYPxAI1lw=; b=Yhbn84oIbruJ7la0+yrlNsE8gdmzh0yT+hYqszC0PI3D4pG4Sq6rMS0ftIUwy3SCGD wADNDHoAhXZqtkkevROFqHo20OiX/J3nyudlcFr6zvPM6OUBJqioqra3AlJJOVjNRDfw flKT5vP1U1VBYQWVZ9j2hveU27eZNOwvXdozQbRAcdiIVMu7Z3GH0uLBInd+1d7gBKSC OzrwHXKOTP//77GAkEVXkRIzMzmDnvODOdfcb83rT07ZN7Od7pgP59A9Pbted/c0PMx1 Lv8T52CdSk6uwmWTJjQb2VaSfzRfvza6jeXOhkO6n56q4M4PRtt7mNc/qm5LTJ/C36Cz vbpg== X-Gm-Message-State: AOAM530mgCY+4D8IOVtkN1YnVgRujkHL8z3FMsSv5MCyT5BUTqyxV1uN aWhBth37/N9Bzwmi+qNOJEL6dz+yGPXDNfIsUFD/Vw== X-Google-Smtp-Source: ABdhPJx9PZ6JxhsrPBmRnz4aiPMRblHlFiegZ4TwoHa84jB+WzSk9gnsC70uTF2ZIwKDHAfRBz2De62SX3bJBAwtvxU= X-Received: by 2002:a05:6512:3131:b0:443:3f0f:754b with SMTP id p17-20020a056512313100b004433f0f754bmr6245792lfd.494.1645209613255; Fri, 18 Feb 2022 10:40:13 -0800 (PST) MIME-Version: 1.0 References: <20220217094802.3644569-1-bigeasy@linutronix.de> <20220217094802.3644569-5-bigeasy@linutronix.de> In-Reply-To: <20220217094802.3644569-5-bigeasy@linutronix.de> From: Shakeel Butt Date: Fri, 18 Feb 2022 10:40:01 -0800 Message-ID: Subject: Re: [PATCH v3 4/5] mm/memcg: Opencode the inner part of obj_cgroup_uncharge_pages() in drain_obj_stock() To: Sebastian Andrzej Siewior Cc: Cgroups , Linux MM , Andrew Morton , Johannes Weiner , Michal Hocko , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Peter Zijlstra , Thomas Gleixner , Vladimir Davydov , Waiman Long Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 123C320005 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="P/EPFiUa"; spf=pass (imf03.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: d3pborknxmkpjfgnawf93g7asd8hxmsa X-HE-Tag: 1645209614-875130 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 17, 2022 at 1:48 AM Sebastian Andrzej Siewior wrote: > > From: Johannes Weiner > > Provide the inner part of refill_stock() as __refill_stock() without > disabling interrupts. This eases the integration of local_lock_t where > recursive locking must be avoided. > Open code obj_cgroup_uncharge_pages() in drain_obj_stock() and use > __refill_stock(). The caller of drain_obj_stock() already disables > interrupts. > > [bigeasy: Patch body around Johannes' diff ] > > Signed-off-by: Johannes Weiner > Signed-off-by: Sebastian Andrzej Siewior Reviewed-by: Shakeel Butt