From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E3DACD6E66 for ; Wed, 11 Oct 2023 12:46:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3ECD8D0103; Wed, 11 Oct 2023 08:46:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEF348D0002; Wed, 11 Oct 2023 08:46:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADD678D0103; Wed, 11 Oct 2023 08:46:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A06408D0002 for ; Wed, 11 Oct 2023 08:46:13 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 62C16120116 for ; Wed, 11 Oct 2023 12:46:13 +0000 (UTC) X-FDA: 81333153426.09.F265F2B Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf25.hostedemail.com (Postfix) with ESMTP id 8FAAFA0010 for ; Wed, 11 Oct 2023 12:46:11 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HbTtRQxA; spf=pass (imf25.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697028371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vRxnYW++U+8TlQsWmKaGw4xOnyl04ESkzrCSiOYHMOw=; b=ecDYiMEUznFjCoKX/4ei6vKrUEJM18mRp/pRGEuup160jnAdlmoj8CdG6pjQcI3kex9H3X w0+Au877lzDy5612dYp1ReOuGLDgWAIGk+oSKiwyPJm1rmE+7y6aV59/ZYWP0bBJfSwoLr T4+OMcZhwPUrB+lQGbeQQhzXvnTTspc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697028371; a=rsa-sha256; cv=none; b=Y6913813T65GZS/hT7/VALUpNeNy3Z/aperdG9eaMTLHGCJ13Yf6EiWA/eYbsuUAtl+4vW YEVkMe49ILz4O6OS3PiVhq8vp7RYsX/WxwhFGSyIOnlmMIWqrsSMLlMGEc+ZphCvV90IMH xDIp7MbqOlPPTBd+UUCCu6114PC2YYw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=HbTtRQxA; spf=pass (imf25.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1c9c145bb5bso137925ad.1 for ; Wed, 11 Oct 2023 05:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697028370; x=1697633170; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vRxnYW++U+8TlQsWmKaGw4xOnyl04ESkzrCSiOYHMOw=; b=HbTtRQxA4poLP1S79LcWoO2ghiJxvo4R0c50zARoBEoKzid14V3EYsYRWkqLRQYq2i O22p/CUUnUKXjzDV+22wYpBIP34zAOMuRBvw0haogniAjkymTxWHuQLXMqVvvYkfjCBQ ZNeHwpRWFr44WEUmqM2+YN65eozRFDgqy7E6yTMrfJNeEz/aL0BJV314IMoy6BNFPXH9 2lHn1L6OqkL1RxXTsxAq52DYGvGZuCNMEq3NSXQeS//swwkFjRrHUWtuM8ySDeXEzXx1 cNpF4zyNzfy/0N0G3JobjrB6uO3eNfE2wO5bd+UWcEolJex9hVYWx0+QzsewmyUtt3Dm 85vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697028370; x=1697633170; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vRxnYW++U+8TlQsWmKaGw4xOnyl04ESkzrCSiOYHMOw=; b=GVSHrblKDtXy08+7ik8WhTo8aeVB8HikXD8Xii08qM2e2nH3V5C4M/ONXL2k+8m/zk Ox0330zAI91AUhDuYRWTbFVrjDu3W7Cqg/z8ad8R7Vak8tm62tYN+Qh8JT4DYIpKLQnb n/v2+krZOmpyZcQRJVsaFM7qFBO2rl5Mut9S9EQJ8OK98syT0y26L6QhrQYSz9WCAk9L 2uqRI0/qmSl5tsuuapsPVyDBJVfjVzAD788/pJxiUfeWTI69vhEgoGO0P1Nui+z5P+tQ 5DfTJ3MSNUmSq6DGoxFO5IIEA6LJqkpO2wKIqb1T7ADdbbHBCeRXGdOfiU8IEdeWx5nn Z7Ow== X-Gm-Message-State: AOJu0YyGsy0CbIFIvUYAfG149ao2TCIb5tG8xJohc2Wq4ChoUliRJEWG MSOb7nn6gDNJ8XA/Q6hkdigqwnyP3ImuKKQWuPDCcQ== X-Google-Smtp-Source: AGHT+IHSO7IpzlUaTsA99RK2xosy3goKI41ZEFNsKGFVZUUg12a2Etj4aZSQgVylWCCjwh0GKeVN7byl8b9dfg6R6Zs= X-Received: by 2002:a17:902:ecc9:b0:1c6:212f:c8e5 with SMTP id a9-20020a170902ecc900b001c6212fc8e5mr218432plh.26.1697028370195; Wed, 11 Oct 2023 05:46:10 -0700 (PDT) MIME-Version: 1.0 References: <20231010032117.1577496-1-yosryahmed@google.com> <20231010032117.1577496-4-yosryahmed@google.com> <20231011003646.dt5rlqmnq6ybrlnd@google.com> In-Reply-To: From: Shakeel Butt Date: Wed, 11 Oct 2023 05:45:58 -0700 Message-ID: Subject: Re: [PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Waiman Long , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8FAAFA0010 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1bkzn9t93d5hwg9r9wk6wtpyfgdog4nb X-HE-Tag: 1697028371-507407 X-HE-Meta: U2FsdGVkX1/IUMlo9HZkISVpGHTgrl151T79a0l/1YWEYC0wvUIp2EtPQSBLbgYMlhAPV+flg6IOat2abc0aptT6pbUCP43pMWvTSXoR/amTPRzwudlG95jrGRg507kzOl3IomwgbRGXG5wpTO8986besniaBVKczUX5uTGvUTrbkRZc+WP+nA3+GuVb4+bP0QdLt4qE7pEcmZrQfdMp75gYDqhzhiEmhJaugu8L55XtNr8yIgoLyq+Gjql/KtU88mr2w8HhdrvCb0rgGWhXuMPB3niIyMtyMDmslSUGlyApsWhi4u4LPow8Oq/EHCFUemIY71rDlMFfTrUrlUSSlU6F9dEC2xoWsFPkM7DBEY9FRRmVNTza2dz8WpCmPLQZx4y3cKADBxPItDcrWuCDswWK9nQvGZIFZzMa10eAsZXsE9WF2YfpY1eZ3txuHih3ZYGuWp8Vu7NMq9Ve1JcakTspZlUZ79JPMMxNE6jLt5MFLkt5E1NU7NWiqBCETpM4tHndM//bawxp7jdQ8ufxZW3fDyVJwgWORyu1WJUT3294Zh+oCO8CGY3wOs+iGRZ0+igNP+XDINVrilDq1RkGwlscgvEmALxQDfU1xD0o440ZAEKEnNIHpdzNpkWRwhg3/1l4ku7RBuyvOD+oazXhZIgYBTMfJMw425IIZVIvoe0QSRp1LgVVsNc7nyDjuGUtPHQtBTKSAhJRaZMZk8v31My+7YnxdKtVhlJKFHCzeBbSp4QkEXR6XSaAr9IkdF1L3PMJlyVEIbb8SKlxuF5GKlUzjksF0lJGFPwwy4RCBRzGz8OBAiTb+tBW6MIkQwdZD8PmNWhnj6kDuamxzh5D43eLvao9JBHSrVGuov91biiiwmUbpuuuLFCBb09Vsaa4QdFr7jAapqbljR6kUBLQSSqFwIed7ZEype49VeXzZRLeZMWd/8CfdxgDU90GwqtkZxmICk/2+OiAUzggVHi u7kz7DFf Ti6hkk7HQ/ZBTHuOaHdEoDENk+iXnxtKlYdYLOJIk83pcYUaEzU475Iae2aNwKt9SpKjL/pWPcYJpt4qtILIyXaqfrtr+RahfG3uMBfpaQGEdrNBmVYMJjipte5xus4K8Xo9v7lXgcxCG3Wme/H/oU3d+c3gQI4c8CSccWHRd/5Gw/Ub7dxkve7EP85Lb+4sGKvNMLhv0XmTKV56UuejMYCHSci1Wf6g1uDRXSymmPvfECj7Vxz9slgbuVeJ7gs+9I8r2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001736, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 10, 2023 at 6:48=E2=80=AFPM Yosry Ahmed = wrote: > > On Tue, Oct 10, 2023 at 5:36=E2=80=AFPM Shakeel Butt wrote: > > > > On Tue, Oct 10, 2023 at 03:21:47PM -0700, Yosry Ahmed wrote: > > [...] > > > > > > I tried this on a machine with 72 cpus (also ixion), running both > > > netserver and netperf in /sys/fs/cgroup/a/b/c/d as follows: > > > # echo "+memory" > /sys/fs/cgroup/cgroup.subtree_control > > > # mkdir /sys/fs/cgroup/a > > > # echo "+memory" > /sys/fs/cgroup/a/cgroup.subtree_control > > > # mkdir /sys/fs/cgroup/a/b > > > # echo "+memory" > /sys/fs/cgroup/a/b/cgroup.subtree_control > > > # mkdir /sys/fs/cgroup/a/b/c > > > # echo "+memory" > /sys/fs/cgroup/a/b/c/cgroup.subtree_control > > > # mkdir /sys/fs/cgroup/a/b/c/d > > > # echo 0 > /sys/fs/cgroup/a/b/c/d/cgroup.procs > > > # ./netserver -6 > > > > > > # echo 0 > /sys/fs/cgroup/a/b/c/d/cgroup.procs > > > # for i in $(seq 10); do ./netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- > > > -m 10K; done > > > > You are missing '&' at the end. Use something like below: > > > > #!/bin/bash > > for i in {1..22} > > do > > /data/tmp/netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K & > > done > > wait > > > > Oh sorry I missed the fact that you are running instances in parallel, my= bad. > > So I ran 36 instances on a machine with 72 cpus. I did this 10 times > and got an average from all instances for all runs to reduce noise: > > #!/bin/bash > > ITER=3D10 > NR_INSTANCES=3D36 > > for i in $(seq $ITER); do > echo "iteration $i" > for j in $(seq $NR_INSTANCES); do > echo "iteration $i" >> "out$j" > ./netperf -6 -H ::1 -l 60 -t TCP_SENDFILE -- -m 10K >> "out$j" & > done > wait > done > > cat out* | grep 540000 | awk '{sum +=3D $5} END {print sum/NR}' > > Base: 22169 mbps > Patched: 21331.9 mbps > > The difference is ~3.7% in my runs. I am not sure what's different. > Perhaps it's the number of runs? My base kernel is next-20231009 and I am running experiments with hyperthreading disabled.