From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.0 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 359E8C07E99 for ; Fri, 9 Jul 2021 16:00:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B8C56613B5 for ; Fri, 9 Jul 2021 16:00:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8C56613B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8C2956B0073; Fri, 9 Jul 2021 12:00:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 872EA6B0074; Fri, 9 Jul 2021 12:00:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 713468D0001; Fri, 9 Jul 2021 12:00:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 48E016B0073 for ; Fri, 9 Jul 2021 12:00:54 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6C2F5824C429 for ; Fri, 9 Jul 2021 16:00:53 +0000 (UTC) X-FDA: 78343512786.27.E8C83B7 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf05.hostedemail.com (Postfix) with ESMTP id 12343500B071 for ; Fri, 9 Jul 2021 16:00:52 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id q18so24207198lfc.7 for ; Fri, 09 Jul 2021 09:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/xZI0OajFf5/ziUaY+H5m9Nzo8ghS9n7erS+9RJcXYI=; b=W8p7yxoX3G5IefHMsRi4RO40HwPkUuZKO3Wv0ZsSnEGlWk9UWvnKmQGYINVPYcChA9 WqVnGAT7Ht7kptj0cHK+RO8ue80geR+dn9mK06BE+MSmBWZxzpFqj2liQKKsHQHwEm8/ 9adlW2sI8CwSPhxv6HJlqtEhnnly5kd4B07uwGmd8xdOgTfH1L2I0TPxkaJjN8DDlkDD 1YtUnGHXQCYRub16v4ymPOdl3+c8L4KyEZjjF4acYce5MxvCBZ1TeeoUX+rWBAMUwjrR qfVOlkfEB974p6LhdqPzqpMyry1nWccBFX0SbgLebwQ9nEFcv5nZaY0H5dTUUHBoyq0a k+qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/xZI0OajFf5/ziUaY+H5m9Nzo8ghS9n7erS+9RJcXYI=; b=A1FcbiUAKqyabiUswFljE6E8LbG8GvBux5oB+fm5rbBpdWKTNpFFpWnHEO0q8mqGTc YjtDhoCvIqbN75EpiazliRFWZwMfyB/rE/zgPWjZbsG1hcIkBw1qn2W1jpi15F7BGggo nHI9MuAYtDVjacIdGyby5LbZomdbimnmTW8zXiKK5c6uR/OTWMTo7aMEpd85Q1hQeuDm 2EtXVsXwbWNJDjPl5eNS/OXCRmvEU2jgXGZ2Uo7lXJfkdBJwivGWabvixFRaFmdhVdDc yD01Fv+tjnBlSrBrdehgc/FjdGrAPFYkK1Ze5W+1rZt8WYoLauGcL2GYxets8BuWL3Wi 4KwA== X-Gm-Message-State: AOAM531IA693+1Gu+muO+ClZnc1IAUh9vztrJSDvDYMEGmJpSlkhIdzS S/i7wPNEpu8tSckEF1bGwrPRXaijWobIncjWEyTNhw== X-Google-Smtp-Source: ABdhPJzHHw49xv/agytETvqSChc4oU4k6Uy1gyLX68+KTNT1rad2pHALpVI3rzlltSe/tgTntSYsjF1LYD8VqnNkNdo= X-Received: by 2002:a19:ad4d:: with SMTP id s13mr13304956lfd.432.1625846451059; Fri, 09 Jul 2021 09:00:51 -0700 (PDT) MIME-Version: 1.0 References: <20210709000509.2618345-1-surenb@google.com> <20210709000509.2618345-2-surenb@google.com> In-Reply-To: <20210709000509.2618345-2-surenb@google.com> From: Shakeel Butt Date: Fri, 9 Jul 2021 09:00:39 -0700 Message-ID: Subject: Re: [PATCH 1/3] mm, memcg: add mem_cgroup_disabled checks in vmpressure and swap-related functions To: Suren Baghdasaryan Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Muchun Song , Yang Shi , alexs@kernel.org, Alexander Duyck , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , Matthew Wilcox , Alistair Popple , Minchan Kim , Miaohe Lin , LKML , Cgroups , Linux MM , kernel-team Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=W8p7yxoX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Stat-Signature: 98ttyucq1ebuj3scoawpecd5kgtib4os X-Rspamd-Queue-Id: 12343500B071 X-Rspamd-Server: rspam05 X-HE-Tag: 1625846452-586709 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 8, 2021 at 5:05 PM Suren Baghdasaryan wrote: > [...] > --- a/mm/vmpressure.c > +++ b/mm/vmpressure.c > @@ -240,7 +240,12 @@ static void vmpressure_work_fn(struct work_struct *work) > void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, bool tree, > unsigned long scanned, unsigned long reclaimed) > { > - struct vmpressure *vmpr = memcg_to_vmpressure(memcg); > + struct vmpressure *vmpr; > + > + if (mem_cgroup_disabled()) > + return; > + > + vmpr = memcg_to_vmpressure(memcg); I was wondering why this was not crashing but realized that we allocate root_mem_cgroup even in cgroup_disable=memory case. Reviewed-by: Shakeel Butt