From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4982DC433F5 for ; Tue, 12 Oct 2021 16:08:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C52E86103D for ; Tue, 12 Oct 2021 16:08:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C52E86103D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3EFC1900003; Tue, 12 Oct 2021 12:08:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39F36900002; Tue, 12 Oct 2021 12:08:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28E13900003; Tue, 12 Oct 2021 12:08:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 165F3900002 for ; Tue, 12 Oct 2021 12:08:55 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BB9A88249980 for ; Tue, 12 Oct 2021 16:08:54 +0000 (UTC) X-FDA: 78688268988.20.53DBE93 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf08.hostedemail.com (Postfix) with ESMTP id 643B030000A8 for ; Tue, 12 Oct 2021 16:08:54 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id x27so89455294lfa.9 for ; Tue, 12 Oct 2021 09:08:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SUSRBbgEONe1rUoJU8RUgo+k+yVw3zQ7WDhpeBulOJo=; b=U2adeNOvUPaST/L3dSzVje06TwnmZra9J3YOC3Ib1CnFQxFgTZmUh+QSJm10Oc5t9V 3XiOM53aTlVLZ+rZhOyYQ3hcLSToUPIHsMGF0LCNQn86Gn/x14THrcqcwrrDrBZLriR8 5SOd7yfJTgEdDoEiCreoIErh2BIJI4DfV9DAY6U5MGG1phvpd4fOzymvLrXfZ+X3c1Oz RuQbvFSJBA8XgOGS741rhWf+98RLMOt0k7375Ww4+8WdRix5eXzY68cRbtp1Q97C0sBZ 3bLzwD7cZ+yveWz4jdGqUZRUSkRuwauS9FSALhacAiA90OpBjhp6R0NstWF885Z2TPcv NnQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SUSRBbgEONe1rUoJU8RUgo+k+yVw3zQ7WDhpeBulOJo=; b=bUtzhR8R8OONr8BrTdkN5oLg4EDjSQLAQHKozKJXvRPPtBZm8pqh2nIuQFn/JtXFhR FC0oqFNArg5jgq01gQsmAYRPzu+9PHhaexO8MvTkn0p8xLb/vgyb115wrUDDV5hDYe7I UqH18aG7yLF1sF0l1mYamtYv2yvVf9YZ8q1GkbizyvqUZFtvfTMR1BPhe3wPhYk7p8bM r0WC45wb+GIj0IJGtTKnPVxbP/ePPL8+fciu9kH2GdC0rlPsrfdCyso9v5bkDqOuJ9gl 4i9BO/8Z0738LjD+YZHR3YRrzQ0y7bcKSZ2aZTfS6ub4Zh7U5qUr+JrhWFKlPcMm8hno 8rTg== X-Gm-Message-State: AOAM530oo4TNQozQVE2t5+1IrXamOdKydnvRvFVXMYI7+nXplGBCjdFP SQ1ImbqNTLjsGIfHRZg2F40yOozVvUvlgHX/9i84Gg== X-Google-Smtp-Source: ABdhPJyIpHMQgAoe2Q9DOIypcQAwWCMAYb9SmwCY4mmtBZZasOUiUymZkJcmy0t2UQMhnDHgK+ax0uiYswOB7r5Did0= X-Received: by 2002:a05:6512:3b0a:: with SMTP id f10mr15565240lfv.8.1634054929389; Tue, 12 Oct 2021 09:08:49 -0700 (PDT) MIME-Version: 1.0 References: <0baa2b26-a41b-acab-b75d-72ec241f5151@virtuozzo.com> <60df0efd-f458-a13c-7c89-749bdab21d1d@virtuozzo.com> In-Reply-To: From: Shakeel Butt Date: Tue, 12 Oct 2021 09:08:38 -0700 Message-ID: Subject: Re: [PATCH mm v3] memcg: enable memory accounting in __alloc_pages_bulk To: Michal Hocko Cc: Vasily Averin , Johannes Weiner , Vladimir Davydov , Andrew Morton , Mel Gorman , Roman Gushchin , Uladzislau Rezki , Vlastimil Babka , Cgroups , Linux MM , LKML , kernel@openvz.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 643B030000A8 X-Stat-Signature: p8ztwz3jyh75wms6a3w18stat4pst65y Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=U2adeNOv; spf=pass (imf08.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1634054934-365959 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 12, 2021 at 8:36 AM Michal Hocko wrote: > > On Tue 12-10-21 17:58:21, Vasily Averin wrote: > > Enable memory accounting for bulk page allocator. > > ENOCHANGELOG > > And I have to say I am not very happy about the solution. It adds a very > tricky code where it splits different charging steps apart. > > Would it be just too inefficient to charge page-by-page once all pages > are already taken away from the pcp lists? This bulk should be small so > this shouldn't really cause massive problems. I mean something like > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index b37435c274cf..8bcd69195ef5 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5308,6 +5308,10 @@ unsigned long __alloc_pages_bulk(gfp_t gfp, int preferred_nid, > > local_unlock_irqrestore(&pagesets.lock, flags); > > + if (memcg_kmem_enabled() && (gfp & __GFP_ACCOUNT)) { > + /* charge pages here */ > + } It is not that simple because __alloc_pages_bulk only allocate pages for empty slots in the page_array provided by the caller. The failure handling for post charging would be more complicated.