From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6908FC433DB for ; Mon, 8 Mar 2021 21:57:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE9556509D for ; Mon, 8 Mar 2021 21:57:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE9556509D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6268B6B00E7; Mon, 8 Mar 2021 16:57:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D6C06B00E8; Mon, 8 Mar 2021 16:57:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 477398D001D; Mon, 8 Mar 2021 16:57:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 2D0286B00E7 for ; Mon, 8 Mar 2021 16:57:23 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E3F9C181AF5F7 for ; Mon, 8 Mar 2021 21:57:22 +0000 (UTC) X-FDA: 77898068724.11.E8D1225 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf14.hostedemail.com (Postfix) with ESMTP id 95AE9C0007D1 for ; Mon, 8 Mar 2021 21:57:18 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id x4so16843192lfu.7 for ; Mon, 08 Mar 2021 13:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=khP6ZcxYFVDRWDYG0T+rbHb6YKkL+/NsAq7MfcJL/3k=; b=DAuY2SnkTq4kpznO/OR8hpixQWW/2Z9iRHBq2QFf3hMnIXGIFb03qdLXNtJxwrhNGd 3izsTWnjGrT67Huo9kgm3bJSkk8jBNm2Fy0lQccrE8yEp3sGHlzxuKdoGe5B8gypbEZs PgguuAqFFpsJwemWMW9ZYiC9flS1cdAsb3YWVwmNyGTU294MM+n0e6SASQ1RL8zKeMHY TBbz6GmWAzgwRIUeOJxS9jx/lNMJUfQa6EstM5U8eWNqc7ZqRvIE35Qovzzfc7LtQX3+ zCB6QbIYWpKRmOg5SrsCB84iOf99jFLmgmRJhgG5ndhSLC5ILGtzRAvNz8eBtux+l04v vpiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=khP6ZcxYFVDRWDYG0T+rbHb6YKkL+/NsAq7MfcJL/3k=; b=h9bXa38A86jBlXChaVSLMxyFmovraka2zKWdDx5XH+3j6eCpD/YiMUkPZwcd6np7bh T1pskye1E4p4w+/yTRZ7gyb9WpmmeSzU2IvGjOAxSL1p9A3cFVg9PuwozD9Rom9FtseV Wd8SB/LGY+ZpShVm+QQxrIiixENnTWOJxLWSE1jSrYQxa2UIcfbRi69ON7qIC56fysJ8 S5FEdjIUurmrG+jaSL8z5SDIrWN0R0+pHrE1Bd9qOQu0dq+yXqstPi3RlW5/t9tj0x2i 1JLazXRPiENcY7BW0UGcMxHSGQNGOfrRIFvZrIWZqJFvsrF5bIUEQJINY8ypD1ARmajK elIg== X-Gm-Message-State: AOAM532Ih/jZa5KWuieG3ha7azq7kMAml/kCnZLM/8eJU5nChRw+8y7h o5UzmeNiVnDTDqtRRJw3flZsAgLdW//oBw5mRCXjyg== X-Google-Smtp-Source: ABdhPJwJKP9j6TADl4BG8Z3lqly76Sb5BltQAcueClPCVCtYYwOA6NDC7q4ME8VtgpxXEhBkyFAjORyMMciln0a+Tmo= X-Received: by 2002:a19:f50e:: with SMTP id j14mr5587045lfb.299.1615240640883; Mon, 08 Mar 2021 13:57:20 -0800 (PST) MIME-Version: 1.0 References: <20210217001322.2226796-1-shy828301@gmail.com> <20210217001322.2226796-12-shy828301@gmail.com> In-Reply-To: <20210217001322.2226796-12-shy828301@gmail.com> From: Shakeel Butt Date: Mon, 8 Mar 2021 13:57:06 -0800 Message-ID: Subject: Re: [v8 PATCH 11/13] mm: vmscan: don't need allocate shrinker->nr_deferred for memcg aware shrinkers To: Yang Shi Cc: Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: nxn6am4ephxdejc37zfn5ao9jfheiegz X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 95AE9C0007D1 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail-lf1-f42.google.com; client-ip=209.85.167.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615240638-627727 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 16, 2021 at 4:13 PM Yang Shi wrote: > > Now nr_deferred is available on per memcg level for memcg aware shrinkers, so don't need > allocate shrinker->nr_deferred for such shrinkers anymore. > > The prealloc_memcg_shrinker() would return -ENOSYS if !CONFIG_MEMCG or memcg is disabled > by kernel command line, then shrinker's SHRINKER_MEMCG_AWARE flag would be cleared. > This makes the implementation of this patch simpler. > > Acked-by: Vlastimil Babka > Reviewed-by: Kirill Tkhai > Acked-by: Roman Gushchin > Signed-off-by: Yang Shi Reviewed-by: Shakeel Butt