From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18EBCC46CA0 for ; Thu, 30 Nov 2023 21:52:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 952648D0056; Thu, 30 Nov 2023 16:52:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 901C68D0001; Thu, 30 Nov 2023 16:52:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C9028D0056; Thu, 30 Nov 2023 16:52:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6EA2C8D0001 for ; Thu, 30 Nov 2023 16:52:41 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 43271120132 for ; Thu, 30 Nov 2023 21:52:41 +0000 (UTC) X-FDA: 81515970522.19.83553D7 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf28.hostedemail.com (Postfix) with ESMTP id 81D1EC0009 for ; Thu, 30 Nov 2023 21:52:39 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=itBjMix4; spf=pass (imf28.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701381159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sfe9+yUHQWvFF1MBxcyQEWLBB5xhP4R/v24MyHrer70=; b=NR52N/+891sTwS7+E1ClhqP3qxQOTlvCOxrR9WA8aJVfC7vuC1yupJGktqXSixk7WAUU0o 7k4Mu0odbJKuSlnSZBA5+C/UBKlYRuMfQfw0ghL79HXauVoeL5Ih6jK1HZbqQO+x2mn5SW 4GEhaSNqB3qH1N/vxdZopCZ4l5XNLNs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701381159; a=rsa-sha256; cv=none; b=PJAs4V6QaFCR4AdRofOzL6WT5YMtFcNq5BWW3weSonRm3XchoRhZ07aJaqVvrBupfpDyhd Wx/mZN/YCAY9CvAzb02b6tBbKP/gDFM4pV78695PTNT9v8+Q/1G8steqFKBx2V4bYRH5lq lDMgOoOd9Hu00169ID+3FTwFM/yWBoY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=itBjMix4; spf=pass (imf28.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1cfd76c5f03so53225ad.0 for ; Thu, 30 Nov 2023 13:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701381158; x=1701985958; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Sfe9+yUHQWvFF1MBxcyQEWLBB5xhP4R/v24MyHrer70=; b=itBjMix4d+/GzGEDwhJqxofURB+gszkBTIqj3lGtCNBMpZCFggL86qsNZojJ0ie0lh m6iHW5KTOwdWbYP2fA/iIqqssec+qTZbnzeyOs4yiHHjI5EkjNVjK4XawezHBAObCVV9 vgNAiJqAGMQvw7zZeTfbjS0wPq0rL1uT4QZJ6USx/Y76sAutUeOi79xqrtESw5SmYn7U Nsqk9g/0H2rWMabb6JXmY45T4VUza+tnDAxFt4F9WJaVdeyEcZIzRIL5OnAPVBJlotmW laWqVcw4sk1LNTbS2eqeyzES0ldlctJHBR1ANfKjzGW8Goq16eQbBjZkIsJNejYcYKd5 Dw/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701381158; x=1701985958; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sfe9+yUHQWvFF1MBxcyQEWLBB5xhP4R/v24MyHrer70=; b=wYZwISyvgPz45+b34k+YlqsaCqoAYNjBMfLo0u3ojpQEbYmGQUC3drCCmR9cUs0qKP rXWbn8Tqjet0FDkfIjl6Cj2DGjdQHfLXpGpljE6P8uGq5XBgdJh1O5OKJqlpw6r/0UXy sZ3Q5c4i/JD2FNpdVetHeV3PJivrhdtWZkSHboWAZlT2ZewyN7vTX50T9imjq6XIDQy/ nWPMZy+3ozXxkaUUqyj1ZCRCKWsT8EuiQR3quCeaz9GpuGWXNnEXVrDZAIaNFyMDAPEd 78tbgA5IpZ57zxEw0JmirIYUILzZtJD89itY12Y3eG+qm2c5kcZlfUD2pZJf49QjriI2 fFxA== X-Gm-Message-State: AOJu0Yxev0j2KjUAt0CnD2QYndVo6zIMEc/+HvbVKAXYy36FiX735X74 vRiSmlnBGPkPSTb4cYQroiXqdaGrxIkYmYpTY63Chw== X-Google-Smtp-Source: AGHT+IEScePdJsCv50KSaFJEK6pXwpZ9MhWwQ6fW0VE537kDsUCVBfYIWXio57IpD3sjKnP6BGpD7VHJg69DMzuDouE= X-Received: by 2002:a17:902:b684:b0:1cf:b218:25c7 with SMTP id c4-20020a170902b68400b001cfb21825c7mr39731pls.0.1701381157613; Thu, 30 Nov 2023 13:52:37 -0800 (PST) MIME-Version: 1.0 References: <20231130153658.527556-1-schatzberg.dan@gmail.com> <20231130165642.GA386439@cmpxchg.org> In-Reply-To: From: Shakeel Butt Date: Thu, 30 Nov 2023 13:52:26 -0800 Message-ID: Subject: Re: [PATCH 0/1] Add swappiness argument to memory.reclaim To: Dan Schatzberg Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Yosry Ahmed , Huan Yang , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Muchun Song , Andrew Morton , David Hildenbrand , Matthew Wilcox , Huang Ying , Kefeng Wang , Peter Xu , "Vishal Moola (Oracle)" , Yue Zhao , Hugh Dickins Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: k3hwjtd5sdq74tyspkmnxbinrtakhnyu X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 81D1EC0009 X-Rspam-User: X-HE-Tag: 1701381159-445723 X-HE-Meta: U2FsdGVkX1/2PZUu2fR/ybro+eKZtRrLsGs6ERRlTepSkM6bHm9r/ARn4G242LbpCf1+o6VH9fM8gQE79xso7rZxPqdRXHtfacFG/7dtnuNV0R8WUTOw3EKwQnkSAAihs3m5/Sf/s1h6WGj9ipCeBZP9LAbo3VJLHLetgmfIfDNkb/dqDhuWLPi0aoI4iRiGMwnsRiqp289biZUo8MvqPOURGpohfUGAFZ4zFkiNE03cLoe1d1f9E+nzauRHQWlA6bv1VSrCeIfNjQR8W2vFe8uv9bCThPVAYWSzPwbq6ZHcotej0yLjWkMf9fVhjyWZZhN9KyJ84+g22YgT5ooyL23fx3VeLlaLWK1FC5jWIbqoubmSTFPwjXxNis6OijhgbIVTdlyBdCYVnuLy0Y31WeJYa8QOeixJhrwqz/NSyn7wvEnMfzKTuQJjqsufsrGH3vuD/MOSLwbcvp6yXABoWdkyAydoaGvy0Kw8LbxRqcbgUTJ3vAJnT/PFGN2rl5vXEmQ43Co/bkfbfp5k+bAHdbVZDAbgk9MznaGfonx4JbwW3bWvPJtukvyeYbCZMhfMSthFxuZ6fnFUKAujLa9NZOSGjURruyIaUYqYBInqyCfFrvmE4NZpofjQeB6K2a25ZKKAVRLILbyd+ZAsSm6hm3EAhnJUcNT65/0ALtVcMOu/TUET3ZiFbLnWuXr4oXcRE2r3uSWziVx/KrcL4+HXVSEidshIvxqrpRrARR+mlxDYM91iehJ16mED9nbCbYtZ6meBzI3K4qSVmDtY0r3wO+06tGarxVq92jGMT0SenMnERqfZyl7PFjeAZ5b3OIaqLryTXjDuqP4Ccd1mqSz/ZjHIiBqMcE4Qx8/XANu1abMLTZdTqJOEV1EKYzxCBukryCqvmbNTaD67uxyEDbf5UVzftncQ8/Dw1XK6o9OgS4kknuK2fLyZ0knp7ApeG4Pv+tropwsFslDpLENVRqQ P1K4zUyv rz8Tf8ztDxTbk+hrUnaX1K7JiOQRnbEwfXX0/znSxdCdoD10SnR+LGCtN+fxMTbzLaqjpRPMcEY6Qq7MjAFLUFz47q/1Dcrmz36yCO9vSDZM5DpGWUKXrONde1J4LXw5HF/EbfyHkAU7aZ4TjKm+Tr7y+NgJDWMcpShBXt6MF17vBz+cdBz4gUT2RaUG1j/AOyOgQBvWaigZ0QrV0Gf1LsgdKWvKmbTD0EVoJXd4FjtipWvGJLLttEhebuk5T4j2Maie7ArRoau682/GbXNdy53Evj+E9GMlks7qSu/A9BqCqbAJEHkBLLNX7iw38GEJC3vfR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 30, 2023 at 1:37=E2=80=AFPM Dan Schatzberg wrote: > > On Thu, Nov 30, 2023 at 12:30:27PM -0800, Shakeel Butt wrote: > > On Thu, Nov 30, 2023 at 11:47=E2=80=AFAM Dan Schatzberg > > wrote: > > > > > > On Thu, Nov 30, 2023 at 11:56:42AM -0500, Johannes Weiner wrote: > > > > [...] > > > > So I wouldn't say it's merely a reclaim hint. It controls a very > > > > concrete and influential factor in VM decision making. And since th= e > > > > global swappiness is long-established ABI, I don't expect its meani= ng > > > > to change significantly any time soon. > > > > > > I want to add to this last point. While swappiness does not have > > > terribly well-defined semantics - it is the (only?) existing mechanis= m > > > to control balance between anon and file reclaim. I'm merely > > > advocating for the ability to adjust swappiness during proactive > > > reclaim separately from reactive reclaim. To what degree the behavior > > > and semantics of swappiness change is a bit orthogonal here. > > > > Let me ask my question in this chain as it might have been missed: > > > > Whatever the semantics of swappiness are (including the edge cases > > like no swap, file_is_tiny, trim cache), should the reclaim code treat > > the global swappiness and user-provided swappiness differently? > > I can't think of any reason why we would want swappiness interpreted > differently if it's provided at proactive reclaim time vs > globally. Did you have something in mind here? Nah just wanted to know what you are aiming for.