From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05F1FC433EF for ; Mon, 13 Sep 2021 20:14:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B75360E8B for ; Mon, 13 Sep 2021 20:14:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8B75360E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 25AAD6B006C; Mon, 13 Sep 2021 16:14:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 209A16B0071; Mon, 13 Sep 2021 16:14:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AB4E900002; Mon, 13 Sep 2021 16:14:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id EBF726B006C for ; Mon, 13 Sep 2021 16:14:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A6C3182499A8 for ; Mon, 13 Sep 2021 20:14:10 +0000 (UTC) X-FDA: 78583651860.07.D59C309 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf09.hostedemail.com (Postfix) with ESMTP id 482643000104 for ; Mon, 13 Sep 2021 20:14:10 +0000 (UTC) Received: by mail-lj1-f171.google.com with SMTP id p15so19460798ljn.3 for ; Mon, 13 Sep 2021 13:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TFTu7i7tglTtOKjDBcC9nmGq/Wxog3yPftPLyMBlrng=; b=KWNwuwaNQr+7SRzLqx1Ow/Hdp9oPj6ocOQ2nsmKYN9cZLRkBI/Hv4/znREvl77lHn0 m08q9e3Zbe5EyWd7pYglZjLKjTUmhZVypq8EZy6Pqeze6LfuxRelwE4v4447DcsFa1h5 DMQUdpK8zA1H3rB2ZnZay55j3BNkWQmNQ9IrloYumykcFjHTRiZyP6XxCz5X8HxGhWgv MVv6cvaaaVbD4tY/HwzWhvQ47vYTNPbutha5oh5TtNU1pBtY7z0Zo2bUUhx4ltptgUEn 8Qj4b7Gogx2ExFy4CaojIzA8WbQ0TsU+PaUy2vjVNpvnz5pVbxrxySVpi99XOyedjYEp sUWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TFTu7i7tglTtOKjDBcC9nmGq/Wxog3yPftPLyMBlrng=; b=378x3V97Z6oOKAGOuxzq5mr0l2H+HRMvAdrhsVQ8O3uB3pYSZ1kxLyaVWRfybnlppq EmuLv0b/KWlbTLjNlNq+5QAkqOpRAjReHYmXGpxwAvFaVPqvgxBJx+eUfHpJCdDpuKT5 ZI0AftKSeomwisR8/PyfSY1p9/8kbH19ilIZ63YVEyoWm+GkItk1953qu1FkAOQ/7qtl 6BspL7N/z06G1JDWDQcjMYKWKonhqnamuotRrCOqQpB3Rx0ldO+2NnznJZzG2XZ5MTXO CQjok7is+lUL7OAf8U7cPTKu8MiBuRykQ565fNkjx6CK2+OcSVJMRhcw+GHyGs3wfgWp 48kA== X-Gm-Message-State: AOAM530NFVaxaWx7iNNmboByrm1izDbcF4jXIScmLyrfz+PCR+ZWo/Qm xUarBV8YDuciu1EA21ttKTCZTOQfoXgPYMCrooD2Pg== X-Google-Smtp-Source: ABdhPJynmxXZYWW7JPUI3h584TVaD1TqBxmocx5ejgb70V1LLe1DVNrZcKCPnyNoPmkyAcNQHtpQf8sM3W2XoyW8GGQ= X-Received: by 2002:a2e:964b:: with SMTP id z11mr11833962ljh.91.1631564048561; Mon, 13 Sep 2021 13:14:08 -0700 (PDT) MIME-Version: 1.0 References: <20210905124439.GA15026@xsang-OptiPlex-9020> <20210907033000.GA88160@shbuild999.sh.intel.com> <20210912111756.4158-1-hdanton@sina.com> <20210912132914.GA56674@shbuild999.sh.intel.com> In-Reply-To: From: Shakeel Butt Date: Mon, 13 Sep 2021 13:13:57 -0700 Message-ID: Subject: Re: [memcg] 45208c9105: aim7.jobs-per-min -14.0% regression To: Tejun Heo Cc: Feng Tang , Hillf Danton , LKML , Xing Zhengjun , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 482643000104 X-Stat-Signature: 68z7rcuedakcd8ws65u55kfwefimho1x Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=KWNwuwaN; spf=pass (imf09.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1631564050-464490 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 13, 2021 at 1:10 PM Tejun Heo wrote: > > On Mon, Sep 13, 2021 at 01:09:11PM -0700, Shakeel Butt wrote: > > Thanks a lot for the explanation. Are there any concerns to call > > cgroup_rstat_flush_irqsafe(root_mem_cgroup->css.cgroup) in system_wq? > > This will be called every 2 seconds, so, we can assume the updated > > tree would be small most of the time. > > I can't think of a reason why this would be problematic. > Thanks again. Feng, is it possible to re-run these benchmarks with queue_work(system_wq) instead of queue_work(system_unbound_wq)?