From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f200.google.com (mail-qk0-f200.google.com [209.85.220.200]) by kanga.kvack.org (Postfix) with ESMTP id 31B4B6B0253 for ; Mon, 2 Oct 2017 16:09:35 -0400 (EDT) Received: by mail-qk0-f200.google.com with SMTP id r18so2507613qkh.4 for ; Mon, 02 Oct 2017 13:09:35 -0700 (PDT) Received: from mail-sor-f41.google.com (mail-sor-f41.google.com. [209.85.220.41]) by mx.google.com with SMTPS id r63sor482318ybf.51.2017.10.02.13.09.34 for (Google Transport Security); Mon, 02 Oct 2017 13:09:34 -0700 (PDT) MIME-Version: 1.0 References: <20170927074319.o3k26kja43rfqmvb@dhcp22.suse.cz> <20170927162300.GA5623@castle.DHCP.thefacebook.com> <20171002122434.llbaarb6yw3o3mx3@dhcp22.suse.cz> <20171002192814.sad75tqklp3nmr4m@dhcp22.suse.cz> <20171002195601.3jeocmmzyf2jl3dw@dhcp22.suse.cz> In-Reply-To: From: Shakeel Butt Date: Mon, 02 Oct 2017 20:09:23 +0000 Message-ID: Subject: Re: [v8 0/4] cgroup-aware OOM killer Content-Type: multipart/alternative; boundary="001a1148b520015ff0055a95f48b" Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , Tim Hockin Cc: Andrew Morton , Cgroups , David Rientjes , Johannes Weiner , Linux MM , Roman Gushchin , Tejun Heo , Tetsuo Handa , Vladimir Davydov , kernel-team@fb.com, linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" --001a1148b520015ff0055a95f48b Content-Type: text/plain; charset="UTF-8" On Mon, Oct 2, 2017 at 1:01 PM Tim Hockin wrote: > In the example above: > > root > / \ > A D > / \ > B C > > Does oom_group allow me to express "compare A and D; if A is chosen > compare B and C; kill the loser" ? As I understand the proposal (from > reading thread, not patch) it does not. It will let you compare A and D and if A is chosen then kill A, B and C. > > On Mon, Oct 2, 2017 at 12:56 PM, Michal Hocko wrote: > > On Mon 02-10-17 12:45:18, Shakeel Butt wrote: > >> > I am sorry to cut the rest of your proposal because it simply goes > over > >> > the scope of the proposed solution while the usecase you are > mentioning > >> > is still possible. If we want to compare intermediate nodes (which > seems > >> > to be the case) then we can always provide a knob to opt-in - be it > your > >> > oom_gang or others. > >> > >> In the Roman's proposed solution we can already force the comparison > >> of intermediate nodes using 'oom_group', I am just requesting to > >> separate the killall semantics from it. > > > > oom_group _is_ about killall semantic. And comparing killable entities > > is just a natural thing to do. So I am not sure what you mean > > > > -- > > Michal Hocko > > SUSE Labs > --001a1148b520015ff0055a95f48b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Mon, Oct 2, 2017 a= t 1:01 PM Tim Hockin <thockin@hock= in.org> wrote:
In the exampl= e above:

=C2=A0 =C2=A0 =C2=A0 =C2=A0root
=C2=A0 =C2=A0 =C2=A0 =C2=A0/=C2=A0 =C2=A0 \
=C2=A0 =C2=A0 =C2=A0A=C2=A0 =C2=A0 =C2=A0 D
=C2=A0 =C2=A0 =C2=A0/ \
=C2=A0 =C2=A0B=C2=A0 =C2=A0C

Does oom_group allow me to express "compare A and D; if A is chosen compare B and C; kill the loser" ?=C2=A0 As I understand the proposal = (from
reading thread, not patch) it does not.

<= /div>
It will let you compare A and D and if A is chosen t= hen kill A, B and C.



On Mon, Oct 2, 2017 at 12:56 PM, Michal Hocko <mhocko@kernel.org> wrote:
> On Mon 02-10-17 12:45:18, Shakeel Butt wrote:
>> > I am sorry to cut the rest of your proposal because it simply= goes over
>> > the scope of the proposed solution while the usecase you are = mentioning
>> > is still possible. If we want to compare intermediate nodes (= which seems
>> > to be the case) then we can always provide a knob to opt-in -= be it your
>> > oom_gang or others.
>>
>> In the Roman's proposed solution we can already force the comp= arison
>> of intermediate nodes using 'oom_group', I am just request= ing to
>> separate the killall semantics from it.
>
> oom_group _is_ about killall semantic.=C2=A0 And comparing killable en= tities
> is just a natural thing to do. So I am not sure what you mean
>
> --
> Michal Hocko
> SUSE Labs
--001a1148b520015ff0055a95f48b-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org