From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D3AC433DB for ; Mon, 8 Mar 2021 17:48:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3B70265298 for ; Mon, 8 Mar 2021 17:48:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B70265298 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F28F6B00DA; Mon, 8 Mar 2021 12:48:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A2298D001D; Mon, 8 Mar 2021 12:48:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F5236B00DC; Mon, 8 Mar 2021 12:48:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 2E4DD6B00DA for ; Mon, 8 Mar 2021 12:48:52 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E03D4181AF5C3 for ; Mon, 8 Mar 2021 17:48:51 +0000 (UTC) X-FDA: 77897442462.24.59DB54D Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf06.hostedemail.com (Postfix) with ESMTP id 1CD11C0007E9 for ; Mon, 8 Mar 2021 17:48:38 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id p21so22320411lfu.11 for ; Mon, 08 Mar 2021 09:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=giD8jSsyZJtO1DBnfL0AaLcvwbpWQ52I68uSxFCyz/k=; b=QPpLMFgSpH9WgV4NcTrB7d+hZtjE/5GT3F2G644kSvUU9b3EGps3rmRAaXpJdfSNrw nBbGd4eLyVIbdTkY7G9viNOngWpUPb8hF3N6jNc8xSGecRsOjJJ18VOIDrclO79YnIej M+KgZzdCA1b5KoWhpxEZz0iXTRSimI/UDdN7cNiISFBjW9ksoNl6GN+FvNbU8wYWq6zk h7K3H4Ih+dZSluL+jMFMYRNXk+3Nv02Ztvu/bvSes259hNSUnyW9tNlloRckDhyGcL26 +f9oprjrH1qwP+ILRdp54S1RPGcKQvitB+ByslpCOaMXBdB3UJXh/MvLiCoFJH04MSVA Y7Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=giD8jSsyZJtO1DBnfL0AaLcvwbpWQ52I68uSxFCyz/k=; b=Xk4pqxIA7Blzwa8eTUMtqUzHkzpIH+9oOAufw2YAkia5hrxX8c3Q8UaaJUO2v7O2lH nVgGtscnir1pC5oYf282V8zfJiy0qCVLyvi3Um3S6lzPHy95NbGCY4Mt3E1F9zJhdXy3 avrQcpPIuImH/rSg9k4dE4tAC7Ez3bJxtoxwPXDFOh9+UWP8Pk9LJZeNLordCkketT1q gIwo/iYZ/kErTZMGJSkOW/ucyWRWAiKwddEKh8PRnUqoX6OO34vQind1mKGKQMhCZ2pq JKWVelNb9hJTAOx/YlymEaJMJV9ud83C5ZeGF9YEMVIh+haXmPhyn1DYY7oRLJ0qDCqr iGRg== X-Gm-Message-State: AOAM531Lt3nHiWFFHOrPl3N2wUWobLWb14fqBYbJ66LV4kxLptFKkIjV 0bLT/84nG4PCbaQx+3wwAqGCD9uo1+6nFvMRtQr9dQ== X-Google-Smtp-Source: ABdhPJw7Hi0i7dAd1dfvZWz3HJ1oxl9iDjYmhMQmd2hfeQvGJcpHO+DIsojeXKaCQlDDTS3CbgYU6Vn1r2LSkTkJuX0= X-Received: by 2002:a05:6512:6c6:: with SMTP id u6mr14739762lff.347.1615225717126; Mon, 08 Mar 2021 09:48:37 -0800 (PST) MIME-Version: 1.0 References: <20210217001322.2226796-1-shy828301@gmail.com> <20210217001322.2226796-9-shy828301@gmail.com> In-Reply-To: <20210217001322.2226796-9-shy828301@gmail.com> From: Shakeel Butt Date: Mon, 8 Mar 2021 09:48:22 -0800 Message-ID: Subject: Re: [v8 PATCH 08/13] mm: vmscan: use a new flag to indicate shrinker is registered To: Yang Shi Cc: Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: mf3qryt9tz44kcwu79dsn394r379nqt8 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1CD11C0007E9 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail-lf1-f41.google.com; client-ip=209.85.167.41 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615225718-202804 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 16, 2021 at 4:13 PM Yang Shi wrote: > > Currently registered shrinker is indicated by non-NULL shrinker->nr_deferred. > This approach is fine with nr_deferred at the shrinker level, but the following > patches will move MEMCG_AWARE shrinkers' nr_deferred to memcg level, so their > shrinker->nr_deferred would always be NULL. This would prevent the shrinkers > from unregistering correctly. > > Remove SHRINKER_REGISTERING since we could check if shrinker is registered > successfully by the new flag. > > Acked-by: Kirill Tkhai > Acked-by: Vlastimil Babka > Signed-off-by: Yang Shi Reviewed-by: Shakeel Butt