From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C0EBC433DF for ; Mon, 20 Jul 2020 17:53:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 64D8E20709 for ; Mon, 20 Jul 2020 17:53:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SX8NYsOL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64D8E20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DEA826B0002; Mon, 20 Jul 2020 13:53:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9A7F6B0005; Mon, 20 Jul 2020 13:53:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C89E66B0006; Mon, 20 Jul 2020 13:53:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id B3BDF6B0002 for ; Mon, 20 Jul 2020 13:53:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 244111803F9C0 for ; Mon, 20 Jul 2020 17:53:10 +0000 (UTC) X-FDA: 77059200540.07.rub75_321460b26f26 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 0040E1825B3ED for ; Mon, 20 Jul 2020 17:53:09 +0000 (UTC) X-HE-Tag: rub75_321460b26f26 X-Filterd-Recvd-Size: 4237 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jul 2020 17:53:09 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id x9so21184060ljc.5 for ; Mon, 20 Jul 2020 10:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kya9ou2H4xCIeg2jTugLQPDLPsUiSPAXkhjVJRHMDG8=; b=SX8NYsOLgCeGmFxjb3Z0RzsYrlrHY6Njtfv46WXbScI3rw3tkdMvNy7qsqcNAy91ok EmnOsjkBbRSUSYO4/Q+Cx/xTEf85/D7y3ubLVL9GrTTaC883stkN/jVXYzE2FCCqF7eB 9s7gGZej8MgWwlJIFwC85V0qxylpm5PoPDao/u8vX7pBu4QWu3w4EYzNHhOsY3D9UTQv wZ7VKxvMYrxM6QJlB3KwFInEXd5SELo26Gs2/yM5C+3lGgUkJm4gOG1yFNX6CZ+WQun4 2A746f0YswL5r2QB7a0ry1PuFLvHVFwRkJvX+AeFb1QZo7ouw1eWDpQA/DMeKnb180Pl r/LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kya9ou2H4xCIeg2jTugLQPDLPsUiSPAXkhjVJRHMDG8=; b=njOzH1x0m5AQVbPGmPsXvQRVwQkeB+qlAegLIGY9h/i7ihffnt3Epd6z0l9EFtQXaR x9U8syMMZ8XVz1Gym12V0VZG+r1Ynap71oqR1uQS7Oi2rJUDlJTBX6nI0Dx0yZtN4Fxl 4CA301mkUXRR4e6C4AL/8boJPq/ugakQnrcMwckVebJGXknUOIBAnyRvZOh1ZdEOAcSO 1KhwugXcRP6UVF5mAYsmESb48j7HzKtFore8LeT5g+pJrV9p6lhr5hfbIO8dXvh2wMde KisVt7zmU7kPeoQD9zRfqJiIsTTdVBcc3reGSeua21dKwzy9Ilxn6upDBRboRAZgAzjV rDuw== X-Gm-Message-State: AOAM531kCbfZEHp1/ZhUaj5SJGdeEHkZ2ryz0GaHNfUYPKH3Ju6N1MoT 1EnbCLMVfLfQskHtqzHUkWwWp8SUG7abdk84J3H9EA== X-Google-Smtp-Source: ABdhPJxVEb/gDZEkvQ7LMo203fIZqznHvbPDVwx5Y0R9jHwZ6CsaSCd83ZH/mrB+5f45z4TkFHBNvGDSXrXZqTZC034= X-Received: by 2002:a2e:8e36:: with SMTP id r22mr10983662ljk.77.1595267587620; Mon, 20 Jul 2020 10:53:07 -0700 (PDT) MIME-Version: 1.0 References: <20200720075148.172156-1-hch@lst.de> <20200720075148.172156-12-hch@lst.de> In-Reply-To: <20200720075148.172156-12-hch@lst.de> From: Shakeel Butt Date: Mon, 20 Jul 2020 10:52:55 -0700 Message-ID: Subject: Re: [PATCH 11/14] mm: use SWP_SYNCHRONOUS_IO more intelligently To: Christoph Hellwig , Minchan Kim Cc: Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , linux-mtd@lists.infradead.org, dm-devel@redhat.com, "open list:BLOCK LAYER" , LKML , drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel , Linux MM , Cgroups Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0040E1825B3ED X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: +Minchan Kim On Mon, Jul 20, 2020 at 12:52 AM Christoph Hellwig wrote: > > There is no point in trying to call bdev_read_page if SWP_SYNCHRONOUS_IO > is not set, as the device won't support it. Also there is no point in > trying a bio submission if bdev_read_page failed. This will at least break the failure path of zram_rw_page(). > > Signed-off-by: Christoph Hellwig > --- > mm/page_io.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/mm/page_io.c b/mm/page_io.c > index ccda7679008851..63b44b8221af0f 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -403,8 +403,11 @@ int swap_readpage(struct page *page, bool synchronous) > goto out; > } > > - ret = bdev_read_page(sis->bdev, swap_page_sector(page), page); > - if (!ret) { > + if (sis->flags & SWP_SYNCHRONOUS_IO) { > + ret = bdev_read_page(sis->bdev, swap_page_sector(page), page); > + if (ret) > + goto out; > + > if (trylock_page(page)) { > swap_slot_free_notify(page); > unlock_page(page); > -- > 2.27.0 >