From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6C0FC77B73 for ; Thu, 20 Apr 2023 19:40:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BD74900003; Thu, 20 Apr 2023 15:40:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36C2C900002; Thu, 20 Apr 2023 15:40:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2340F900003; Thu, 20 Apr 2023 15:40:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 159D1900002 for ; Thu, 20 Apr 2023 15:40:38 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DAE9616020D for ; Thu, 20 Apr 2023 19:40:37 +0000 (UTC) X-FDA: 80702786514.17.BB7977F Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf05.hostedemail.com (Postfix) with ESMTP id E6E01100016 for ; Thu, 20 Apr 2023 19:40:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="5/j+YFuZ"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682019636; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DWz8KeUWsabxybWxiN5KihW65aZnZuzamu2iaxIUYWQ=; b=tP66OfP7zBTEV5+VphRLVBzNccEdpU9KhBLfKosGJoE13uPeam70SkH6p9FHkEwdqzZMO7 QDCUIv7e1P6mnbRN0a+MoY+V+1vgq4zVdugqDSd7mlhlyp/PGTLOvwL37AUlM6JZZSiCJ4 tVRR6afQ6i/M588BDstZgOsCVrHiJxg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="5/j+YFuZ"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682019636; a=rsa-sha256; cv=none; b=2H/eMw1vkSuewkIoh7q4ZFuKfziUym9DdhJL1beEGeeysb2zWQU1C2xpL9EtP5aJnRx5Px 4F2LTnCW9c0VhOKngy4nedak2uOZJSZRzm6FMLUS8+l5Cw6NlCEc962z4ljwodr8xK1LlT zkHzCP0gh5sk+M1qlTXfB67fqmyXNBU= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-3ef31924c64so912011cf.1 for ; Thu, 20 Apr 2023 12:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682019635; x=1684611635; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DWz8KeUWsabxybWxiN5KihW65aZnZuzamu2iaxIUYWQ=; b=5/j+YFuZMStm9e2iO/ipkrsa2LdUF1SNvtLNHwugoyYSsCQKMQue9JXQIakK2Sw0WU Wwjir2Vk1OMmOskjWngO0ESKAMDsptNSuo09gV/5QRZW5W8BQ9iMjvumS1k8RQnoXgOL 7QkKMY/J5LQkz6+5J4PH84vnF85GhfActqCsLNHBVsQFYF+PvYs6ns1u/RYEmGSx5mPD AkN24JBdy2Ucvj2bMd5NJup/cObu22q8uICbnabF/uvOP7KNKI9LF9Jbp+9EshGpOaYQ /uKWf57USSlHvXnbQWfPzv0CMy0Ikth4sL9Oquuoc8TlAAtalyron/zEhtRI2r8h4bJv 5HEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682019635; x=1684611635; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DWz8KeUWsabxybWxiN5KihW65aZnZuzamu2iaxIUYWQ=; b=NTJMEiuC5eeV+owSmuY/mr6K9Y7Prtq9Vatk3DWgWGm35xc6gkobcnrozDipWMqRc+ d3w7N1Yp9RdBT7WrGPm+eHPFRuqm5F4qf6ryEUi+rDBy/fAyToEUQyKzCtjObnzExsaa mOeMESTA26UwG2pLhLhUMZEyRpPJikMpg1Tc2vhNTKh2PjSHLFrPQYPrG7jMrowDXxbK XdGVRq2FkHQMCmWZZCvM/EgSFWZDCPIhz0eSvlUdAEsercgl8HlO4ihW2MqEbvOAlHQv rerTZsSzC1qhDQcVJlYetW88qppMZ4M3G0w2LhyUeGXHmUIP0DMjqwDWl6wo68zkAzFx UiwQ== X-Gm-Message-State: AAQBX9eIMn3tLZHfHgYPkryFPH+asv5Kd+rJ3ITVgL3hBRU/WEfQW449 /f5awWKuW2tljOLQ++65OMasZgDUK85U0HPTlvZ1qA== X-Google-Smtp-Source: AKy350YYyjDLnJOis5cVdCyQaWcXXZnjOis+Z+PsGdBsYf9K1xzOaD9kfB7G8dc8h9ipA4aFgcl7ilcahwxepQqFxP4= X-Received: by 2002:a05:622a:1043:b0:3de:b0b0:557c with SMTP id f3-20020a05622a104300b003deb0b0557cmr47259qte.18.1682019634988; Thu, 20 Apr 2023 12:40:34 -0700 (PDT) MIME-Version: 1.0 References: <20230403220337.443510-1-yosryahmed@google.com> <20230403220337.443510-6-yosryahmed@google.com> In-Reply-To: <20230403220337.443510-6-yosryahmed@google.com> From: Shakeel Butt Date: Thu, 20 Apr 2023 12:40:24 -0700 Message-ID: Subject: Re: [PATCH mm-unstable RFC 5/5] cgroup: remove cgroup_rstat_flush_atomic() To: Yosry Ahmed , Tejun Heo Cc: Alexander Viro , Christian Brauner , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E6E01100016 X-Stat-Signature: pm57ng5uc1b3x6151w1q4u7ugad59cza X-HE-Tag: 1682019635-291757 X-HE-Meta: U2FsdGVkX1/CMVKeCfxN51QUFXqtOCzJ+pNl23s80/kyjutxwTPIN9xWdrhnt7JRR8wr83mKyoep3HKzVNbb3jfgAYGoqQSTjW+p2F0E6tU04p9uGwseNRiwa85vbf7kJryfD/ECF0mpt++5qxOBHswVX0Y8ajT6RIsi8tlaD2VGiUebUJ1ZlYaf33Y7TELIPKMRgjezY1dwyFk6l+igLj5Kt8iVPDPA324YP89KaiOVLo0rPzOV5gHWEGnHk80ExoGHu5JUEuOzc3RX/EtlbJY8S9zXn1pkQ2Dk4HDhGX3ldp+6UwEBj/9KioSj//CgSFXzf6pOquzOGr3UR0o2bosE+xNzeUKCy7FVezvyMPz18GwgtcgNDO9ES59IrSChVTJR4/NnO7tn6eEQ2A9jyZIUnEWhfZnPORhULVBAD6mf6lkS3wNKeGclsMJxfdmCWIxubtfKP4k9a5I25TUKhYO8CWEsB09Dfm08J8SShu3HpSSiU4xc9gJ5ubCjN1JkyGJFabzviqMczW0Prn0RKwnenyap2HmHYnbjquKLBUedrQE9cf3SS6QBFSNv6HC47wXluwxFEaBg0rBTzeHejFOhqWrhykTwOnCVbQXXCSpfD/uDnhzQDacTRrHyTNqMLbt3m4OTwKIIWBS1fSETWT1qllf62rm4xN9kgMFm6XZIW3F4wL6UZEV2HhwuFiXQ4qSsRX667+C98H1aQkw3+ynf6M3hgUn9Kzd6QCsVXnpXBFLfNEpfRezdhAeI2LQvjRzvgFSsVkMoMD//6mLRT0c2+l6KX6Jm1keROP0V80HYunA4wQrurYaCrH87gMWQosEYKSymMk7xugm2wD4kdWtc/SvHlJPvATI72bk9v2d/gXze45XJoXRVVJLF9xje8e+470Bjrpc0e9lVGkGilS2ttILenmYPUQactLOLvMzVHZ4r6jhTJgXm8kCXHF4pJJ1yiyDwPgAyeiX+m6E +utgNuDh 34EkRssfhiLHQJdlbkX1Cd75lK1iktTY3E2R5vB1ngDdy/KOIloPTbdRn5qcOFysSclI+b/UKWozqDZWcX8hqGpdu4ER935O7+Hz7eDHZl6jsmr8/4jZqimSOyIFLmABa1h4TfLyaL8WZRfLnQTgRw+eHMBGTX6N2kvZ+P13vSUGl3RWIpsXkP2lDexJeoqLs1MGvbiSnl5EnCekN5iATHqwEu67cHctds5v8qCkGA5s/RDyYwSWIal8oSMTIOVQnAdMyBEnI3j/vXmeWkVAtPNQWp+tut8i76J1ErGraRlzx1IQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: +Tejun On Mon, Apr 3, 2023 at 3:03=E2=80=AFPM Yosry Ahmed = wrote: > > Previous patches removed the only caller of cgroup_rstat_flush_atomic(). > Remove the function and simplify the code. I would say let cgroup maintainers decide this and this patch can be decoupled from the series. > > Signed-off-by: Yosry Ahmed > --- > include/linux/cgroup.h | 1 - > kernel/cgroup/rstat.c | 26 +++++--------------------- > 2 files changed, 5 insertions(+), 22 deletions(-) > > diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h > index 885f5395fcd04..567c547cf371f 100644 > --- a/include/linux/cgroup.h > +++ b/include/linux/cgroup.h > @@ -692,7 +692,6 @@ static inline void cgroup_path_from_kernfs_id(u64 id,= char *buf, size_t buflen) > */ > void cgroup_rstat_updated(struct cgroup *cgrp, int cpu); > void cgroup_rstat_flush(struct cgroup *cgrp); > -void cgroup_rstat_flush_atomic(struct cgroup *cgrp); > void cgroup_rstat_flush_hold(struct cgroup *cgrp); > void cgroup_rstat_flush_release(void); > > diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c > index d3252b0416b69..f9ad33f117c82 100644 > --- a/kernel/cgroup/rstat.c > +++ b/kernel/cgroup/rstat.c > @@ -171,7 +171,7 @@ __weak noinline void bpf_rstat_flush(struct cgroup *c= grp, > __diag_pop(); > > /* see cgroup_rstat_flush() */ > -static void cgroup_rstat_flush_locked(struct cgroup *cgrp, bool may_slee= p) > +static void cgroup_rstat_flush_locked(struct cgroup *cgrp) > __releases(&cgroup_rstat_lock) __acquires(&cgroup_rstat_lock) > { > int cpu; > @@ -207,9 +207,8 @@ static void cgroup_rstat_flush_locked(struct cgroup *= cgrp, bool may_sleep) > } > raw_spin_unlock_irqrestore(cpu_lock, flags); > > - /* if @may_sleep, play nice and yield if necessary */ > - if (may_sleep && (need_resched() || > - spin_needbreak(&cgroup_rstat_lock))) { > + /* play nice and yield if necessary */ > + if (need_resched() || spin_needbreak(&cgroup_rstat_lock))= { > spin_unlock_irq(&cgroup_rstat_lock); > if (!cond_resched()) > cpu_relax(); > @@ -236,25 +235,10 @@ __bpf_kfunc void cgroup_rstat_flush(struct cgroup *= cgrp) > might_sleep(); > > spin_lock_irq(&cgroup_rstat_lock); > - cgroup_rstat_flush_locked(cgrp, true); > + cgroup_rstat_flush_locked(cgrp); > spin_unlock_irq(&cgroup_rstat_lock); > } > > -/** > - * cgroup_rstat_flush_atomic- atomic version of cgroup_rstat_flush() > - * @cgrp: target cgroup > - * > - * This function can be called from any context. > - */ > -void cgroup_rstat_flush_atomic(struct cgroup *cgrp) > -{ > - unsigned long flags; > - > - spin_lock_irqsave(&cgroup_rstat_lock, flags); > - cgroup_rstat_flush_locked(cgrp, false); > - spin_unlock_irqrestore(&cgroup_rstat_lock, flags); > -} > - > /** > * cgroup_rstat_flush_hold - flush stats in @cgrp's subtree and hold > * @cgrp: target cgroup > @@ -269,7 +253,7 @@ void cgroup_rstat_flush_hold(struct cgroup *cgrp) > { > might_sleep(); > spin_lock_irq(&cgroup_rstat_lock); > - cgroup_rstat_flush_locked(cgrp, true); > + cgroup_rstat_flush_locked(cgrp); > } > > /** > -- > 2.40.0.348.gf938b09366-goog >