From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 659D6ECAAD3 for ; Fri, 9 Sep 2022 16:12:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 021D66B0071; Fri, 9 Sep 2022 12:12:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F13996B0072; Fri, 9 Sep 2022 12:12:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8DB98D0001; Fri, 9 Sep 2022 12:12:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C98386B0071 for ; Fri, 9 Sep 2022 12:12:01 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 95698A0561 for ; Fri, 9 Sep 2022 16:12:01 +0000 (UTC) X-FDA: 79893038442.01.365764A Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf16.hostedemail.com (Postfix) with ESMTP id 1E94F18007F for ; Fri, 9 Sep 2022 16:12:00 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id q3so1955234pjg.3 for ; Fri, 09 Sep 2022 09:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=eDrfYVwDQC+B+QpEvQ41UIS7OrQEnld5CNSxZdpZPgA=; b=F0wkqBGJL1xYRFxmN2T75z4AIhNt1UbmivRoZwZ3KboiF5oDQtO7ium3Kzq9dCV+3L RP2ICzUpgzxqrq8hUXPMY0eGLmRwA+zAdDYSuZh9GUeWrGuwZqUh08H8pA77P9iEsPGp b6pnj6Rb9wFZ+c+JdoNtMdcrNCB7NeeWChdxumtbo3jnTMvn/m+9Yh9o+8/jqU14NYlo Uq/uY6XTV/gnfIa8IZ92OH+bqS6ePdD+EGQoRQq+nYue9IGW4Px3jClughrHNWAxX7uT XPnuvp8oyCH45KSg9104v6Oi+FYeivUUTm11neuKW+KDrm0old9h/hl2dytqCvmymdak rzBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=eDrfYVwDQC+B+QpEvQ41UIS7OrQEnld5CNSxZdpZPgA=; b=HsGgs+jOj+923Ma7sLf5BXjxq9OS65GvxZSkFim2D9h0Hiq22O3X8C6QHbPLyUQymR WZTY0NIY8uYNztv25gF4tWGlP6okVIQIkntQeuf2ibeydaE2D9zSosqrziz8AWpyGv1K LC4HHRsXe1KWcd+oRAVwrclvIo6yrr/Z99Q0LmHMabrYi/Cw5HOYLL5WhIhURhiwQCHk bc29n+b5GuF/sGmiXAm/daquNPBBTrCcHBvzsZo9fNZEpTfyQopGn5uNwrpm2cApFQKR xNyXurYaxd/yojOZqPfjo9LjEePSSQ4N3oxclk3T1bf/5D6oTSE48UFxiINNLce6NUYK /S6A== X-Gm-Message-State: ACgBeo3W7ffzIb9C7uap/GqLK4SiOUYtw+QfC1NiaRViLxumAZMdeey+ 9tvl7TQy7/NXV4cQ4jGVcB7SlSrZLI28ou4MFxOR6w== X-Google-Smtp-Source: AA6agR6o1k8OYU6c3VZsjtmoi4GU+j620+63W9MswFegv3cf067xiW0Q2ntmP7g7tJsYUNwDAHlv3rflaFDJncKmQIQ= X-Received: by 2002:a17:902:b410:b0:172:c9d1:7501 with SMTP id x16-20020a170902b41000b00172c9d17501mr14547983plr.106.1662739919860; Fri, 09 Sep 2022 09:11:59 -0700 (PDT) MIME-Version: 1.0 References: <20220907043537.3457014-1-shakeelb@google.com> <20220907043537.3457014-2-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Fri, 9 Sep 2022 09:11:48 -0700 Message-ID: Subject: Re: [PATCH 1/3] memcg: extract memcg_vmstats from struct mem_cgroup To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662739921; a=rsa-sha256; cv=none; b=Gtnx2LzMmgs1c2hpPMgbfCEXa+6qJDEdcakt6pKVRnMLDLz4vwEDhMOhZPXDhxlqii3XYs NC6ittcKlvSn3afxo3cmQv6DKwP/5fBQSVx+1tIGxEITtUJIIDzfdQOFPOX4btHBUb3c9s 0zjzgHfAlcyX6gcY/wlvLphxakQzhKM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=F0wkqBGJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of shakeelb@google.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662739921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eDrfYVwDQC+B+QpEvQ41UIS7OrQEnld5CNSxZdpZPgA=; b=k17sj2vABeM556YHRGmR4XLIG66z33oJUXHBPFE0AiUf6MyEG553Q1TPhmlTDVz1PIuDDG EKEOTXp3TeDaufL1BZnQxB+m/sngAv87UYqEDep82/v6NV5lnLmpaOio0cO+ILL0Djfsqu VDkOSo8kiIU90+5Cf1MZZuvD/j6DT8s= X-Stat-Signature: t365ujd79dwpzgbioyoopjreeux1ss4g X-Rspamd-Queue-Id: 1E94F18007F X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=F0wkqBGJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf16.hostedemail.com: domain of shakeelb@google.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspamd-Server: rspam12 X-HE-Tag: 1662739920-268753 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 8, 2022 at 5:26 PM Michal Koutn=C3=BD wrote: > > Hi. > > On Wed, Sep 07, 2022 at 04:35:35AM +0000, Shakeel Butt wrote: > > This is a preparatory patch to reduce the memory overhead of memory > > cgroup. The struct memcg_vmstats is the largest object embedded into th= e > > struct mem_cgroup. > > This patch extracts struct memcg_vmstats from struct > > mem_cgroup to ease the following patches in reducing the size of struct > > memcg_vmstats. > > Is the reason for the extraction just moving things away from the header > file? > Or is the separate allocation+indirection somehow beneficial wrt, e.g. > fragmentation? > The main reason was to move away from the head file. I have not yet measured the performance impact of these changes. I am planning to rearrange struct mem_cgroup and will do some performance tests after that.