From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5BB8C43461 for ; Fri, 11 Sep 2020 15:55:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E51B208E4 for ; Fri, 11 Sep 2020 15:55:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="K5fRpESJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E51B208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 903766B0003; Fri, 11 Sep 2020 11:55:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B14C6B005A; Fri, 11 Sep 2020 11:55:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A0676B005D; Fri, 11 Sep 2020 11:55:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id 63DA26B0003 for ; Fri, 11 Sep 2020 11:55:48 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1B905181AEF1F for ; Fri, 11 Sep 2020 15:55:48 +0000 (UTC) X-FDA: 77251231176.09.bikes10_320a42b270ef Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id EBACE180AD811 for ; Fri, 11 Sep 2020 15:55:47 +0000 (UTC) X-HE-Tag: bikes10_320a42b270ef X-Filterd-Recvd-Size: 3567 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Fri, 11 Sep 2020 15:55:47 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id b12so6324384lfp.9 for ; Fri, 11 Sep 2020 08:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/8h3iMEyFX6QewzjKstBqsXqbnz4eLSjULf7zqd77Io=; b=K5fRpESJbY0J2ZllnGRok9NGNm70giUMtrP8Frc6f8UWBaz4M8hpQ/5a2wWgh8XyzZ 6rLN/sG5qBPy+9e03ECdD4AzRCmP9RaPn1m1/OsHh/hsH7AgbzvhgV1S2hZcBASCM/le CpwlEYVGVmnzFVsTdBULF39HA/kbL1x8w7NNyHi0kGf+XJx6MW5Jm04vrvFqqMUxCemV hFyNb8QBWvIKmfyFkNeKLNNuyot42p+XGAoJnXVd44yKZ2Ku2NIJa7Ai6NYhLY4SMCde 4uaBKTDBABwPBRJ0n0BcZQa/xeDeqhxEWyZmhtGKA6pmxus2DRUtIIZRVqetwgndH0fV eOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/8h3iMEyFX6QewzjKstBqsXqbnz4eLSjULf7zqd77Io=; b=pSGRlEajQkIEz2GhYCWIdzxph3xY8QjXliiKDKARJ2Oqa6qiV2f/uikdPV9Yh5+GML t9kBYLjRlZwsh3MKdSNhHiGHbdgK+W9c2qLX0aTG+WwKdj0ejaVZ4dIqhTdgA8OEMkze YDRzTjwwGzGy6TOdKtc3DDc/5zR93mEl1N85XomFLBnd/QW3Z0ZEMEDXXyNSoYPfVvHk hHZz6aLEdM6EmKPXtytoBdM452Dty3MzsChfcXkhQF/8rTD7gV1WG9C7T6ZV+4n2uJ2q Xnqe8jwPJ9mP5CggOadCnEqCaiaCQZRCSSu1xGVkScz3XQByu0aGCL21odiYVp6+ZNL7 y4Cg== X-Gm-Message-State: AOAM532lX9Ct6TqC7c6QMRWf0Yg2P6/P0sFeeU+dNOpOOE3q3F0JO2pz agXnZ4JPIIhirZPiVAm7AsKHnD0MRGQnaSyhLXUW3w== X-Google-Smtp-Source: ABdhPJyclL4RnPGvosl5BRR+2mfGotvjWG9Mhr6L3INTzBqTvtjxRCbnlpPGfo6VVDf8sgmAC5lLL5d1173/oMO2qek= X-Received: by 2002:a19:2346:: with SMTP id j67mr453183lfj.449.1599839745555; Fri, 11 Sep 2020 08:55:45 -0700 (PDT) MIME-Version: 1.0 References: <20200910084258.22293-1-songmuchun@bytedance.com> In-Reply-To: From: Shakeel Butt Date: Fri, 11 Sep 2020 08:55:34 -0700 Message-ID: Subject: Re: [External] Re: [PATCH] mm: memcontrol: Add the missing numa stat of anon and file for cgroup v2 To: Muchun Song Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EBACE180AD811 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 11, 2020 at 8:48 AM Muchun Song wrote: > [snip] > > I got it, thanks. Because the "state" interface exposes the anon and > file information. So I think that we also should expose the anon and > file for "numa_stat" per node instead of the lru statistics. Maybe it is > better that we expose both of all the information. > Sure, go ahead and please do update the doc file as well in the next version.